Re: 答复: 答复: [PATCH 7/7] drm/amdgpu:map/unmap static csa accordingly

2017-01-10 Thread Christian König
as "amdgpu_vm_bo_update" in sequence in "amdgpu_vm_bo_update" ? BR Monk *发件人:* Christian König *发送时间:* 2017年1月10日 17:44:21 *收件人:* Liu, Monk; amd-gfx@lists.freedesktop.org *主题:* Re: 答复: [PATCH 7/7] drm/amdgpu

答复: 答复: [PATCH 7/7] drm/amdgpu:map/unmap static csa accordingly

2017-01-10 Thread Liu, Monk
ly call "amdgpu_vm_bo_map" as well as "amdgpu_vm_bo_update" in sequence in "amdgpu_vm_bo_update" ? BR Monk 发件人: Christian König 发送时间: 2017年1月10日 17:44:21 收件人: Liu, Monk; amd-gfx@lists.freedesktop.org 主题: Re: 答复: [PATCH 7/7] drm/amd

Re: 答复: [PATCH 7/7] drm/amdgpu:map/unmap static csa accordingly

2017-01-10 Thread Christian König
Adding the BO and it's mapping is VM specific code, we should initialize that directly in amdgpu_vm_init() and not call any helper to delegate the work. Especially don't call from the VM code into the virt code and back into the VM code. If you really want to keep that in amdgpu_virt. an alt

答复: [PATCH 7/7] drm/amdgpu:map/unmap static csa accordingly

2017-01-09 Thread Liu, Monk
why you want to drop that "adev->virt.map_csa()" calling ? without that calling you don't have CSA's initialized bo_va and mappings as well, and without bo_va and mappings how you can make "amdgpu_vm_bo_update()" invoke work ? Monk 发件人: Christian König 发送时间