Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

> >> > When this feature enabled, the performance in watt is improved in >> most case(low activity and Multimedia) from pplib's test. I do not >> find compute test result. >> > >> > So there is a question: >> > >> > When compute ring begin, if we just fix sclk i

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

- > *From:* Kuehling, Felix > *Sent:* Thursday, March 1, 2018 1:13:58 AM > *To:* Zhu, Rex; Alex Deucher; Huang, JinHuiEric > *Cc:* Russell, Kent; amd-gfx@lists.freedesktop.org > *Subject:* Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch > sysfs >   &

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

Kuehling, Felix > Sent: Wednesday, February 28, 2018 2:55 AM > To: Alex Deucher; Huang, JinHuiEric > Cc: Zhu, Rex; Russell, Kent; amd-gfx list > Subject: Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs > > On 2018-02-27 11:27 AM, Alex Deucher wrote: >> On Tue,

RE: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

, Felix Sent: Wednesday, February 28, 2018 2:55 AM To: Alex Deucher; Huang, JinHuiEric Cc: Zhu, Rex; Russell, Kent; amd-gfx list Subject: Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs On 2018-02-27 11:27 AM, Alex Deucher wrote: > On Tue, Feb 27, 2018 at 11:22 AM, Eric Hu

RE: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

, February 27, 2018 10:52 AM To: Alex Deucher; Zhu, Rex; Russell, Kent; Huang, JinHuiEric Cc: amd-gfx list Subject: Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs [+Eric] Compute profile switching code as well as KFD compute support for most GPUs is not upstream yet

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

On 2018-02-27 11:27 AM, Alex Deucher wrote: > On Tue, Feb 27, 2018 at 11:22 AM, Eric Huang wrote: >> As I mentioned in code review for new power profile, old gfx/compute power >> profile have two scenarios for auto switching. One is >> gfx->compute(default)->gfx and

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

Yes. That is a solution. Eric On 2018-02-27 11:27 AM, Alex Deucher wrote: On Tue, Feb 27, 2018 at 11:22 AM, Eric Huang wrote: As I mentioned in code review for new power profile, old gfx/compute power profile have two scenarios for auto switching. One is

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

On Tue, Feb 27, 2018 at 11:22 AM, Eric Huang wrote: > As I mentioned in code review for new power profile, old gfx/compute power > profile have two scenarios for auto switching. One is > gfx->compute(default)->gfx and other is gfx->compute(custom)->gfx. New power >

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

As I mentioned in code review for new power profile, old gfx/compute power profile have two scenarios for auto switching. One is gfx->compute(default)->gfx and other is gfx->compute(custom)->gfx. New power profile only satisfies first one, but in second one for user debugging, user setting of

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

[+Eric] Compute profile switching code as well as KFD compute support for most GPUs is not upstream yet. As such, there is probably no requirement (yet) to keep the compute profile API stable, that we added specifically for KFD. Once we are upstream that will change. If you change it now, we'll

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

+ Kent and Felix for comment On Tue, Feb 27, 2018 at 6:21 AM, Rex Zhu wrote: > The gfx/compute profiling mode switch is only for internally > test. Not a complete solution and unexpectly upstream. > so revert it. > > Change-Id: I1af1b64a63b6fc12c24cf73df03b083b3661ca02 >

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

Am 27.02.2018 um 12:21 schrieb Rex Zhu: The gfx/compute profiling mode switch is only for internally test. Not a complete solution and unexpectly upstream. so revert it. Change-Id: I1af1b64a63b6fc12c24cf73df03b083b3661ca02 Signed-off-by: Rex Zhu Patch is Acked-by: Christian