RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-28 Thread Deng, Emily
>-Original Message- >From: Koenig, Christian >Sent: Tuesday, May 28, 2019 3:43 PM >To: Deng, Emily ; Quan, Evan >; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > >Am 28.05.19 um 09:38 schrieb Deng, Emily: &

Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-28 Thread Koenig, Christian
Am 28.05.19 um 09:38 schrieb Deng, Emily: >> -Original Message- >> From: Koenig, Christian >> Sent: Tuesday, May 28, 2019 3:04 PM >> To: Quan, Evan ; Deng, Emily >> ; amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH] drm/amdgpu: Don't need to call

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-28 Thread Deng, Emily
>-Original Message- >From: Koenig, Christian >Sent: Tuesday, May 28, 2019 3:04 PM >To: Quan, Evan ; Deng, Emily >; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > >Ok in this case the patch is a NAK. > >T

Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-28 Thread Koenig, Christian
onday, May 27, 2019 7:02 PM >> To: Deng, Emily ; amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin >> >> Am 27.05.19 um 10:41 schrieb Emily Deng: >>> As it will destroy clear_state_obj, and also will unpin it in the >

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Quan, Evan
p.org > Subject: Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > > Am 27.05.19 um 10:41 schrieb Emily Deng: > > As it will destroy clear_state_obj, and also will unpin it in the > > gfx_v9_0_sw_fini, so don't need to call csb_vram unpin in > > gfx_v9_0_hw_fini,

Re: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Christian König
Am 27.05.19 um 10:41 schrieb Emily Deng: As it will destroy clear_state_obj, and also will unpin it in the gfx_v9_0_sw_fini, so don't need to call csb_vram unpin in gfx_v9_0_hw_fini, or it will have unpin warning. v2: For suspend, still need to do unpin Signed-off-by: Emily Deng ---

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Emily Deng > Sent: Monday, May 27, 2019 4:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > > As it will destroy clear_state_obj,

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-27 Thread Quan, Evan
Did you ever test S3 suspend/resume? On S3 suspend/resume path, only hw_fini was called. > -Original Message- > From: amd-gfx On Behalf Of > Deng, Emily > Sent: Monday, May 27, 2019 11:09 AM > To: Deng, Emily ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/

RE: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin

2019-05-26 Thread Deng, Emily
Ping.. Best wishes Emily Deng >-Original Message- >From: amd-gfx On Behalf Of Emily >Deng >Sent: Friday, May 24, 2019 6:33 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deng, Emily >Subject: [PATCH] drm/amdgpu: Don't need to call csb_vram_unpin > >[CAUTION: External Email] > >As it