RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-27 Thread Chen, Guchun
: Grodzovsky, Andrey Sent: Monday, August 23, 2021 10:42 PM To: Christian König ; Chen, Guchun ; Alex Deucher ; Mike Lothian ; Koenig, Christian Cc: amd-gfx list ; Gao, Likun ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-23 Thread Andrey Grodzovsky
-Original Message- From: Alex Deucher Sent: Friday, August 20, 2021 2:13 AM To: Mike Lothian Cc: Grodzovsky, Andrey ; Chen, Guchun ; amd-gfx list ; Gao, Likun ; Koenig, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-23 Thread Christian König
, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) Please go ahead. Thanks! Alex On Thu, Aug 19, 2021 at 8:05 AM Mike Lothian wrote: Hi Do I need to open a new bug report for this? Cheers Mike On Wed, 18 Aug 2021 at 06:26

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-23 Thread Chen, Guchun
; Gao, Likun ; Koenig, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) Please go ahead. Thanks! Alex On Thu, Aug 19, 2021 at 8:05 AM Mike Lothian wrote: > > Hi > > Do I need to open a ne

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-19 Thread Alex Deucher
Please go ahead. Thanks! Alex On Thu, Aug 19, 2021 at 8:05 AM Mike Lothian wrote: > > Hi > > Do I need to open a new bug report for this? > > Cheers > > Mike > > On Wed, 18 Aug 2021 at 06:26, Andrey Grodzovsky > wrote: >> >> >> On 2021-08-02 1:16 a.m., Guchun Chen wrote: >> > In

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-19 Thread Mike Lothian
Hi Do I need to open a new bug report for this? Cheers Mike On Wed, 18 Aug 2021 at 06:26, Andrey Grodzovsky wrote: > > On 2021-08-02 1:16 a.m., Guchun Chen wrote: > > In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop > > scheduler in s3 test, otherwise, fence related

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Andrey Grodzovsky
On 2021-08-02 1:16 a.m., Guchun Chen wrote: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Mike Lothian
op.org; Gao, Likun ; Koenig, > Christian ; Zhang, Hawking < > hawking.zh...@amd.com>; Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in > s3 test (v2) > > On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: > > >

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Chen, Guchun
, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: > > [Public] > > Thank you, Christian. > > Regarding fence_drv.initialized, it looks

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Mike Lothian
; to the commit message. > > Alex > > > > > Regards, > > Guchun > > > > -Original Message- > > From: Christian König > > Sent: Monday, August 2, 2021 2:56 PM > > To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; > Gao, Likun ; Koenig, Chri

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Alex Deucher
esktop.org; Gao, > Likun ; Koenig, Christian ; > Zhang, Hawking ; Deucher, Alexander > > Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 > test (v2) > > Am 02.08.21 um 07:16 schrieb Guchun Chen: > > In amdgpu_fence_driver_hw_fini, no need t

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Chen, Guchun
; Koenig, Christian ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2) Am 02.08.21 um 07:16 schrieb Guchun Chen: > In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop > scheduler in s3 test, oth

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Christian König
Am 02.08.21 um 07:16 schrieb Guchun Chen: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence related failure will arrive after resume. To fix this and for a better clean up, move drm_sched_fini from fence_hw_fini to fence_sw_fini, as

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test

2021-07-29 Thread Chen, Guchun
König Sent: Thursday, July 29, 2021 8:50 PM To: Chen, Guchun ; Koenig, Christian ; amd-gfx@lists.freedesktop.org; Gao, Likun ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test Hi Guchun, see below. Am 29.07.21 um 14:39

RE: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test

2021-07-29 Thread Chen, Guchun
esume case. Regards, Guchun -Original Message- From: Koenig, Christian Sent: Thursday, July 29, 2021 7:11 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Gao, Likun ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test

2021-07-29 Thread Christian König
Am 29.07.21 um 12:49 schrieb Guchun Chen: In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop scheduler in s3 test, otherwise, fence errors will occur after resume. So introduce a new parameter to distingiush the case in this API. NAK, the problem is rather that

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test

2021-07-29 Thread Christian König
al Message- From: Koenig, Christian Sent: Thursday, July 29, 2021 7:11 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Gao, Likun ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test Am 29.07.21 um 12:49

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test

2021-07-29 Thread Christian König
nig, Christian Sent: Thursday, July 29, 2021 7:11 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Gao, Likun ; Zhang, Hawking ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test Am 29.07.21 um 12:49 schrieb Guchun Chen: In amdgpu_fence_dri