Re: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-07-03 Thread Christian König
Am 03.07.20 um 08:05 schrieb Felix Kuehling: Am 2020-07-01 um 10:34 a.m. schrieb Li, Dennis: [AMD Official Use Only - Internal Distribution Only] Hi, Christian and Alex Not only amdgpu ioctls, but amdkfd ioctls also have the same issue. Most KFD ioctls don't access HW directly. The

Re: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-07-03 Thread Felix Kuehling
Am 2020-07-01 um 10:34 a.m. schrieb Li, Dennis: > [AMD Official Use Only - Internal Distribution Only] > > Hi, Christian and Alex > Not only amdgpu ioctls, but amdkfd ioctls also have the same issue. Most KFD ioctls don't access HW directly. The only place that interacts with HW in KFD is

RE: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-07-01 Thread Li, Dennis
[AMD Official Use Only - Internal Distribution Only] Hi, Christian and Alex Not only amdgpu ioctls, but amdkfd ioctls also have the same issue. Best Regards Dennis Li -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, July 1, 2020 4:20 PM To: Alex

Re: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-07-01 Thread Christian König
I don't think this is a good idea, we should probably rather wait for the GPU reset to finish by taking the appropriate lock. Christian. Am 01.07.20 um 07:33 schrieb Alex Deucher: ping? On Fri, Jun 26, 2020 at 10:04 AM Alex Deucher wrote: When the GPU is in reset, accessing the hw is

Re: [PATCH] drm/amdgpu: return an error for hw access in INFO ioctl when in reset

2020-06-30 Thread Alex Deucher
ping? On Fri, Jun 26, 2020 at 10:04 AM Alex Deucher wrote: > > When the GPU is in reset, accessing the hw is unreliable and could > interfere with the reset. Return an error in those cases. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 ++ > 1 file