Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-06-08 Thread Nirmoy
org *Subject:* Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini [AMD Public Use] Looks good to me. Reviewed-by: Alex Deucher <mailto:alexander.deuc...@amd.com>> *From:*Christian König <ma

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-06-08 Thread Nirmoy
egards Dennis Li *From:* amd-gfx *On Behalf Of *Deucher, Alexander *Sent:* Thursday, February 27, 2020 11:18 PM *To:* Christian König ; Das, Nirmoy ; amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini [AMD Public Use] Looks good to me. Re

RE: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-28 Thread Li, Dennis
AM To: Das, Nirmoy mailto:nirmoy@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>>; Deucher, Alexander mailto:alexander.deuc...@amd.com>> Subject: Re: [PATCH] drm/amdgpu: stop disable the scheduler dur

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-27 Thread Deucher, Alexander
[AMD Public Use] Looks good to me. Reviewed-by: Alex Deucher From: Christian König Sent: Thursday, February 27, 2020 9:50 AM To: Das, Nirmoy ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: stop disable the scheduler during

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-27 Thread Christian König
Alex any comment on this? Am 25.02.20 um 14:16 schrieb Nirmoy: Acked-by: Nirmoy Das On 2/25/20 2:07 PM, Christian König wrote: When we stop the HW for example for GPU reset we should not stop the front-end scheduler. Otherwise we run into intermediate failures during command submission. The

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-25 Thread Nirmoy
On 2/25/20 2:16 PM, Nirmoy wrote: Acked-by: Nirmoy Das Please change that to Tested-by: Nirmoy Das ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-25 Thread Nirmoy
Hi Dennis, Can you please test this patch on vega20 for SWDEV-223117 Regards, Nirmoy On 2/25/20 2:07 PM, Christian König wrote: When we stop the HW for example for GPU reset we should not stop the front-end scheduler. Otherwise we run into intermediate failures during command submission.

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-25 Thread Nirmoy
Hi Christian, I tested with amdgpu_test which does a GPU reset as well because of deadlock_tests. Reset was fine I could run amdgpu_test multiple times. dmesg: Feb 25 14:32:20 brihaspati kernel: [drm:gfx_v9_0_priv_reg_irq [amdgpu]] *ERROR* Illegal register access in command stream Feb 25

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-25 Thread Christian König
Am 25.02.20 um 14:16 schrieb Nirmoy: Acked-by: Nirmoy Das Could you test it as well? I only did a quick round of smoke tests, but somebody should probably run a gpu reset test as well. Thanks in advance, Christian. On 2/25/20 2:07 PM, Christian König wrote: When we stop the HW for

Re: [PATCH] drm/amdgpu: stop disable the scheduler during HW fini

2020-02-25 Thread Nirmoy
Acked-by: Nirmoy Das On 2/25/20 2:07 PM, Christian König wrote: When we stop the HW for example for GPU reset we should not stop the front-end scheduler. Otherwise we run into intermediate failures during command submission. The scheduler should only be stopped in very few cases: 1. We can't