RE: [PATCH] drm/kfd: fix a system crash issue during GPU recovery

2020-09-02 Thread Li, Dennis
u. Best Regards Dennis Li -Original Message- From: Kuehling, Felix Sent: Wednesday, September 2, 2020 11:26 AM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Koenig, Christian Subject: Re: [PATCH] drm/kfd: fix a system crash issue during GPU recov

Re: [PATCH] drm/kfd: fix a system crash issue during GPU recovery

2020-09-01 Thread Felix Kuehling
nal Message- From: Kuehling, Felix Sent: Tuesday, September 1, 2020 9:26 PM To: Li, Dennis ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Koenig, Christian Subject: Re: [PATCH] drm/kfd: fix a system crash issue during GPU recovery I'm not sure how the bug you're fix

RE: [PATCH] drm/kfd: fix a system crash issue during GPU recovery

2020-09-01 Thread Li, Dennis
ian Subject: Re: [PATCH] drm/kfd: fix a system crash issue during GPU recovery I'm not sure how the bug you're fixing is caused, but your fix is clearly in the wrong place. A queue being disabled is not the same thing as a queue being destroyed. Queues can be disabled for legitimate reas

Re: [PATCH] drm/kfd: fix a system crash issue during GPU recovery

2020-09-01 Thread Felix Kuehling
I'm not sure how the bug you're fixing is caused, but your fix is clearly in the wrong place. A queue being disabled is not the same thing as a queue being destroyed. Queues can be disabled for legitimate reasons, but they still should exist and be in the qpd->queues_list. If a destroyed queue