Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Andrey Grodzovsky
ginal Message- From: Grodzovsky, Andrey Sent: Thursday, August 26, 2021 11:05 AM To: Liu, Monk ; Christian König ; amd-gfx@lists.freedesktop.org; dri-devel Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2) On 2021-08-25 10:31 p.m., Liu, Monk wrote: [AMD Official Use On

RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Liu, Monk
--- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Grodzovsky, Andrey Sent: Thursday, August 26, 2021 11:05 AM To: Liu, Monk ; Christian König ; amd-gfx@lists.freedesktop.org; dri-devel Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v

Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Andrey Grodzovsky
Thursday, August 26, 2021 2:20 AM To: Christian König ; Liu, Monk ; amd-gfx@lists.freedesktop.org; dri-devel Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2) On 2021-08-25 8:11 a.m., Christian König wrote: No, this would break that logic here. See drm_sched_start_timeo

RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Liu, Monk
M To: Christian König ; Liu, Monk ; amd-gfx@lists.freedesktop.org; dri-devel Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2) On 2021-08-25 8:11 a.m., Christian König wrote: > No, this would break that logic here. > > See drm_sched_start_timeout() can be called mult

RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Liu, Monk
Liu | Cloud-GPU Core team -- -----Original Message----- From: Christian König Sent: Wednesday, August 25, 2021 8:11 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2) No, th

Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Andrey Grodzovsky
-- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Christian König Sent: Wednesday, August 25, 2021 2:32 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2) Well NAK to that approach. Fir

Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Alex Deucher
Please cc dri-devel on all scheduler patches. It's core functionality. Alex On Wed, Aug 25, 2021 at 12:14 AM Monk Liu wrote: > > the original logic is wrong that the timeout will not be retriggerd > after the previous job siganled, and that lead to the scenario that all > jobs in the same sched

Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Christian König
Core team -- -Original Message- From: Liu, Monk Sent: Wednesday, August 25, 2021 7:55 PM To: 'Christian König' ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/sched: fix the bug of time out calculation(v2) [AMD Official Use Only] The timeout started by que

RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Liu, Monk
y Thanks -- Monk Liu | Cloud-GPU Core team -- -Original Message- From: Liu, Monk Sent: Wednesday, August 25, 2021 7:55 PM To: 'Christian König' ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/sched: fix the bug of time out calculatio

RE: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-25 Thread Liu, Monk
-- -Original Message- From: Christian König Sent: Wednesday, August 25, 2021 2:32 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/sched: fix the bug of time out calculation(v2) Well NAK to that approach. First of all your bug analyses

Re: [PATCH] drm/sched: fix the bug of time out calculation(v2)

2021-08-24 Thread Christian König
Well NAK to that approach. First of all your bug analyses is incorrect. The timeout started by queue_delayed_work() in drm_sched_start_timeout() is paired with the cancel_delayed_work() in drm_sched_get_cleanup_job(). So you must have something else going on here. Then please don't use mod_de