Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-28 Thread Nirmoy
On 8/28/20 9:29 AM, Liu, Monk wrote: [AMD Official Use Only - Internal Distribution Only] Please don't change those code unless you have a full stress test and a solid reason (what bug fixed or what new feature introduced ) Otherwise if it's a pure personal refactor or cleanup it will be

RE: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-28 Thread Gu, JiaWei (Will)
, Monk Subject: Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov On 8/28/20 8:58 AM, Gu, JiaWei (Will) wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Nirmoy, > > I also found amdgpu_device_ip_reinit_late_sriov() part is missed. > Will push another

RE: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-28 Thread Liu, Monk
[AMD Official Use Only - Internal Distribution Only] Please don't change those code unless you have a full stress test and a solid reason (what bug fixed or what new feature introduced ) Otherwise if it's a pure personal refactor or cleanup it will be not necessary

Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-28 Thread Nirmoy
-Original Message- From: Das, Nirmoy Sent: Friday, August 28, 2020 2:33 PM To: Deng, Emily ; Das, Nirmoy ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Monk ; Gu, JiaWei (Will) Subject: Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov On 8/28/20 3:16 AM, Deng, Emily

RE: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-28 Thread Gu, JiaWei (Will)
To: Deng, Emily ; Das, Nirmoy ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Monk ; Gu, JiaWei (Will) Subject: Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov On 8/28/20 3:16 AM, Deng, Emily wrote: > [AMD Official Use Only - Internal Distribution Only] > >

Re: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-28 Thread Nirmoy
On 8/28/20 3:16 AM, Deng, Emily wrote: [AMD Official Use Only - Internal Distribution Only] Hi Nirmoy, Still think the original logical is more clear. No problem but we should at least make sure amdgpu_device_ip_reinit_late_sriov() and amdgpu_device_ip_reinit_early_sriov() are

RE: [PATCH 1/1] drm/amdgpu: rework ip block reinit for sriov

2020-08-27 Thread Deng, Emily
[AMD Official Use Only - Internal Distribution Only] Hi Nirmoy, Still think the original logical is more clear. Best wishes Emily Deng >-Original Message- >From: Das, Nirmoy >Sent: Thursday, August 27, 2020 11:19 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ;