Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-29 Thread Pelloux-prayer, Pierre-eric
Hi Christian, The series is: Tested-by: Pierre-Eric Pelloux-Prayer Pierre-Eric On 29/05/2019 14:27, Christian König wrote: > This avoids OOM situations when we have lots of threads > submitting at the same time. > > v3: apply this to the whole driver, not just CS > > Signed-off-by:

RE: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-29 Thread Zhou, David(ChunMing)
Patch #1,#5,#6,#8,#9,#10 are Reviewed-by: Chunming Zhou Patch #2,#3,#4 are Acked-by: Chunming Zhou -David > -Original Message- > From: dri-devel On Behalf Of > Christian K?nig > Sent: Wednesday, May 29, 2019 8:27 PM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org

Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-27 Thread Koenig, Christian
Am 24.05.19 um 23:34 schrieb Kuehling, Felix: > On 2019-05-23 5:06 a.m., Christian König wrote: >> [CAUTION: External Email] >> >> Leaving BOs on the LRU is harmless. We always did this for VM page table >> and per VM BOs. >> >> The key point is that BOs which couldn't be reserved can't be

Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-24 Thread Kuehling, Felix
On 2019-05-23 5:06 a.m., Christian König wrote: > [CAUTION: External Email] > > Leaving BOs on the LRU is harmless. We always did this for VM page table > and per VM BOs. > > The key point is that BOs which couldn't be reserved can't be evicted. > So what happened is that an application used

Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-23 Thread Christian König
Leaving BOs on the LRU is harmless. We always did this for VM page table and per VM BOs. The key point is that BOs which couldn't be reserved can't be evicted. So what happened is that an application used basically all of VRAM during CS and because of this X server couldn't pin a BO for

RE: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-23 Thread Liang, Prike
Hi, Christian Thanks for you patch .Those patches can fix amdgpu bo pinned failed issue during perform dm_plane_helper_prepare_fb and Abaqus performance seems improved. But there some error message can be observer. Do we need drop amdgpu_vm_validate_pt_bos() error message and other warning

Re: [PATCH 10/10] drm/amdgpu: stop removing BOs from the LRU v3

2019-05-22 Thread Kuehling, Felix
Can you explain how this avoids OOM situations? When is it safe to leave a reserved BO on the LRU list? Could we do the same thing in amdgpu_amdkfd_gpuvm.c? And if we did, what would be the expected side effects or consequences? Thanks,   Felix On 2019-05-22 8:59 a.m., Christian König wrote: