RE: [PATCH 4/4] drm/amdgpu: add RAS support for the gfx block of Arcturus

2020-01-18 Thread Li, Dennis
gfx@lists.freedesktop.org; Deucher, Alexander ; Zhou1, Tao ; Zhang, Hawking Cc: Li, Dennis Subject: RE: [PATCH 4/4] drm/amdgpu: add RAS support for the gfx block of Arcturus [AMD Public Use] + switch (adev->asic_type) + { Please correct the coding style. '{' should stay at the sam

RE: [PATCH 4/4] drm/amdgpu: add RAS support for the gfx block of Arcturus

2020-01-18 Thread Chen, Guchun
[AMD Public Use] + switch (adev->asic_type) + { Please correct the coding style. '{' should stay at the same line of switch. + mutex_unlock(>grbm_idx_mutex); + + gfx_v9_4_query_utc_edc_status(adev, err_data); Is it necessary to move gfx_v9_4_query_utc_edc_status calling