The patch is fine. But i can not see where amdgpu_ucode_init_bo is called on resume.
Regards, Evan > -----Original Message----- > From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Rex > Zhu > Sent: 2018年9月30日 0:15 > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex <rex....@amd.com> > Subject: [PATCH 4/6] drm/amdgpu: Don't allocate memory for ucode when > suspend > > driver don't release the ucode memory when suspend. so don't need to > allocate bo when resume back. > > Signed-off-by: Rex Zhu <rex....@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > index fb2bdf3..e7dafa1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c > @@ -432,7 +432,7 @@ int amdgpu_ucode_init_bo(struct amdgpu_device > *adev) > return 0; > } > > - if (!adev->in_gpu_reset) { > + if (!adev->in_gpu_reset && !adev->in_suspend) { > err = amdgpu_bo_create_kernel(adev, adev- > >firmware.fw_size, PAGE_SIZE, > amdgpu_sriov_vf(adev) ? > AMDGPU_GEM_DOMAIN_VRAM : AMDGPU_GEM_DOMAIN_GTT, > &adev->firmware.fw_buf, > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx