Re: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2)

2017-08-08 Thread Christian König
merged with bo_free() BR Monk -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Monday, August 7, 2017 11:03 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2) Am 07.08.2017 um 16:35 s

RE: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2)

2017-08-07 Thread Liu, Monk
önig' ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2) Christian See below code (if it is what you mean) and it shows why I don't understand your point: (1) I assume you tend to change to below logic: /* The buffer

RE: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2)

2017-08-07 Thread Liu, Monk
and I don't want to change UMD at all Bo_reference have no way to merge with bo_free_internal, while bo_free_internal() can be merged with bo_free() BR Monk -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Monday, August 7, 2017 11:03 PM To: Liu, Monk ; amd-g

RE: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2)

2017-08-07 Thread Liu, Monk
x27;s your suggestion ? thanks BR Monk -Original Message- From: Christian König [mailto:deathsim...@vodafone.de] Sent: Monday, August 7, 2017 11:03 PM To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2) Am 07.08.2017 u

Re: [PATCH libdrm 2/2] drm:fix race issue between two bo functions(v2)

2017-08-07 Thread Christian König
Am 07.08.2017 um 16:35 schrieb Monk Liu: From: Monk Liu there is race issue between two threads on amdgpu_bo_reference and amdgpu_bo_import, this patch tends to fix it by moving the pthread_mutex_lock out of bo_free_internal and move to bo_reference to cover the update_reference part. The mute