Re: [PATCH] drm/amdgpu: move amdgpu ttm structures to amdgpu_ttm.h

2018-08-12 Thread Zhang, Jerry (Junwei)
On 08/10/2018 10:21 PM, Christian König wrote: Well NAK, that is intentionally kept local to the amdgpu_ttm.c file. This way we can make sure that we don't accidentally leak the structure somewhere else. Thanks to explain that. I thought those were left in the file accidentally. Then fine to

Re: [PATCH] drm/amdgpu: move amdgpu ttm structures to amdgpu_ttm.h

2018-08-10 Thread Christian König
Well NAK, that is intentionally kept local to the amdgpu_ttm.c file. This way we can make sure that we don't accidentally leak the structure somewhere else. What you could do is to move it to the beginning of the file. Christian. Am 10.08.2018 um 07:44 schrieb Junwei Zhang: code cleanup

Re: [PATCH] drm/amdgpu: move amdgpu ttm structures to amdgpu_ttm.h

2018-08-10 Thread Huang Rui
On Fri, Aug 10, 2018 at 01:44:28PM +0800, Junwei Zhang wrote: > code cleanup for amdgpu ttm structures > > Signed-off-by: Junwei Zhang Acked-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 20 > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 17