Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Zhu, Rex
> From: Alex Deucher <alexdeuc...@gmail.com> > Sent: Tuesday, January 30, 2018 2:02 AM > > To: Zhu, Rex > Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_force_performance_level >

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Alex Deucher
ail.com> > Sent: Tuesday, January 30, 2018 2:02 AM > > To: Zhu, Rex > Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_force_performance_level > > On Mon, Jan 29, 2018 at 7:03 AM, Zhu, Rex <rex.

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Zhu, Rex
setting will be removed. >> >> >>>One more reason why allowing the user to set pp_dpm_sckl/mclk >>>shouldn't be allowed in auto-mode. >> >> this is an old logic, maybe ref radeon driver. >> Driver can allow to set pp_dpm_sclk/mclk range in auto/high/low mode. >> >> Best Regards

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Alex Deucher
ile. that can happen automatically if the user sets the force_performance level to auto. Alex > > > Best Regards > Rex > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Saturday, January 27, 2018 7:51 AM > To: Zhu, Rex > Cc: Kueh

RE: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-29 Thread Zhu, Rex
t; > Best Regards > Rex > > From: Kuehling, Felix > Sent: Saturday, January 27, 2018 3:32 AM > To: Zhu, Rex; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_force_performance_leve

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Alex Deucher
ling, Felix > Sent: Saturday, January 27, 2018 3:32 AM > To: Zhu, Rex; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_force_performance_level > > On 2018-01-26 02:20 PM, Zhu, Rex wrote: >> >> >1. You're breaking th

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Zhu, Rex
ing, Felix Sent: Saturday, January 27, 2018 3:32 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-26 02:20 PM, Zhu, Rex wrote: > > >1. You're breaking the semantics of the existi

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Felix Kuehling
------- > *From:* Kuehling, Felix > *Sent:* Saturday, January 27, 2018 12:49 AM > *To:* Zhu, Rex; amd-gfx@lists.freedesktop.org > *Subject:* Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_force_performance_level >   > Hi Rex, > > I t

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Zhu, Rex
driver still can set min sclk/mclk. Best Regards Rex From: Kuehling, Felix Sent: Saturday, January 27, 2018 12:49 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level Hi Rex

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Felix Kuehling
; > > > ------------ > *From:* Kuehling, Felix > *Sent:* Friday, January 26, 2018 8:26 AM > *To:* Zhu, Rex; amd-gfx@lists.freedesktop.org > *Subject:* Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_forc

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-26 Thread Zhu, Rex
t: Friday, January 26, 2018 8:26 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-25 07:07 PM, Zhu, Rex wrote: > I also think about this problem. > just think user should unforced clk level

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-25 Thread Felix Kuehling
-- > *From:* Kuehling, Felix > *Sent:* Friday, January 26, 2018 12:55:19 AM > *To:* amd-gfx@lists.freedesktop.org; Zhu, Rex > *Subject:* Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for > power_dpm_force_performance_level >   > This patch breaks unforc

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-25 Thread Zhu, Rex
From: Kuehling, Felix Sent: Friday, January 26, 2018 12:55:19 AM To: amd-gfx@lists.freedesktop.org; Zhu, Rex Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level This patch breaks unforcing of clocks, which is currently done

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

2018-01-25 Thread Felix Kuehling
This patch breaks unforcing of clocks, which is currently done by switching back from "manual" to "auto". By removing "manual" mode, you remove the ability to unset forced clocks. Regards,   Felix On 2018-01-25 06:26 AM, Rex Zhu wrote: > Driver do not maintain manual mode for