Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-13 Thread Luben Tuikov
On 2022-09-13 22:34, Zhu, Jiadong wrote: >> + >> + r_rptr = amdgpu_ring_get_rptr(mux->real_ring); >> + r_wptr = amdgpu_ring_get_wptr(mux->real_ring); >> These names are very much the same to a human. How about writep and readp? > r_rptr for real ring's read ptr differed from sw_rptr.

RE: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-13 Thread Zhu, Jiadong
: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3) Inlined: On 2022-09-08 21:50, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > The software ring is created to support priority context while there > is only one hardware queue for gfx. > > Every software rings ha

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-13 Thread Luben Tuikov
Inlined: On 2022-09-08 21:50, jiadong@amd.com wrote: > From: "Jiadong.Zhu" > > The software ring is created to support priority > context while there is only one hardware queue > for gfx. > > Every software rings has its fence driver and could > be used as an ordinary ring for the

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-13 Thread Andrey Grodzovsky
I guess, but this is kind of implicit assumption which is not really documented and easily overlooked. Anyway - for this code it's not directly relevant. Andrey On 2022-09-13 03:25, Christian König wrote: Am 13.09.22 um 04:00 schrieb Andrey Grodzovsky: [SNIP] You are right for scheduler

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-13 Thread Christian König
Am 13.09.22 um 04:00 schrieb Andrey Grodzovsky: [SNIP] You are right for scheduler mediated submissions (executing through drm_sched_backend_ops.run_job hook) , I am talking about direct submissions without gpu scheduler (using amdgpu_job_submit_direct) Andrey Direct submission is only

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Andrey Grodzovsky
On 2022-09-12 21:44, Zhu, Jiadong wrote: [AMD Official Use Only - General] -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, September 13, 2022 12:45 AM To: Christian König ; Zhu, Jiadong ; amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: Re: [PATCH 1/4] drm/amdgpu

RE: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Zhu, Jiadong
[AMD Official Use Only - General] -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, September 13, 2022 12:45 AM To: Christian König ; Zhu, Jiadong ; amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3) On 2022-09

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Andrey Grodzovsky
On 2022-09-12 12:22, Christian König wrote: Am 12.09.22 um 17:34 schrieb Andrey Grodzovsky: On 2022-09-12 09:27, Christian König wrote: Am 12.09.22 um 15:22 schrieb Andrey Grodzovsky: On 2022-09-12 06:20, Christian König wrote: Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Christian König
@lists.freedesktop.org Cc: Huang, Ray Subject: Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3) On 2022-09-12 09:27, Christian König wrote: Am 12.09.22 um 15:22 schrieb Andrey Grodzovsky: On 2022-09-12 06:20, Christian König wrote: Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On 2022-09-08 21

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Christian König
Am 12.09.22 um 17:34 schrieb Andrey Grodzovsky: On 2022-09-12 09:27, Christian König wrote: Am 12.09.22 um 15:22 schrieb Andrey Grodzovsky: On 2022-09-12 06:20, Christian König wrote: Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On 2022-09-08 21:50, jiadong@amd.com wrote: From:

RE: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Liu, Shaoyun
, September 12, 2022 11:34 AM To: Christian König ; Zhu, Jiadong ; amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3) On 2022-09-12 09:27, Christian König wrote: > Am 12.09.22 um 15:22 schrieb Andrey Grodzovsky: >> >> On 2

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Andrey Grodzovsky
On 2022-09-12 09:27, Christian König wrote: Am 12.09.22 um 15:22 schrieb Andrey Grodzovsky: On 2022-09-12 06:20, Christian König wrote: Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On 2022-09-08 21:50, jiadong@amd.com wrote: From: "Jiadong.Zhu" The software ring is created to

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Luben Tuikov
No problem Christian--will do today. Thanks. Regards, Luben On 2022-09-09 10:24, Christian König wrote: > Andrey and Luben please take a look at this set here and help with > reviewing it. > > Thanks, > Christian. > > Am 09.09.22 um 03:50 schrieb jiadong@amd.com: >> From: "Jiadong.Zhu"

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Christian König
Am 12.09.22 um 15:22 schrieb Andrey Grodzovsky: On 2022-09-12 06:20, Christian König wrote: Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On 2022-09-08 21:50, jiadong@amd.com wrote: From: "Jiadong.Zhu" The software ring is created to support priority context while there is only one

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Andrey Grodzovsky
On 2022-09-12 06:20, Christian König wrote: Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On 2022-09-08 21:50, jiadong@amd.com wrote: From: "Jiadong.Zhu" The software ring is created to support priority context while there is only one hardware queue for gfx. Every software rings

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-12 Thread Christian König
Am 09.09.22 um 18:45 schrieb Andrey Grodzovsky: On 2022-09-08 21:50, jiadong@amd.com wrote: From: "Jiadong.Zhu" The software ring is created to support priority context while there is only one hardware queue for gfx. Every software rings has its fence driver and could be used as an

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-09 Thread Andrey Grodzovsky
On 2022-09-08 21:50, jiadong@amd.com wrote: From: "Jiadong.Zhu" The software ring is created to support priority context while there is only one hardware queue for gfx. Every software rings has its fence driver and could be used as an ordinary ring for the gpu_scheduler. Multiple

Re: [PATCH 1/4] drm/amdgpu: Introduce gfx software ring(v3)

2022-09-09 Thread Christian König
Andrey and Luben please take a look at this set here and help with reviewing it. Thanks, Christian. Am 09.09.22 um 03:50 schrieb jiadong@amd.com: From: "Jiadong.Zhu" The software ring is created to support priority context while there is only one hardware queue for gfx. Every software