Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module

2018-03-09 Thread Christian König
: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module On Fri, Mar 9, 2018 at 2:45 AM, Christian König <ckoenig.leichtzumer...@gmail.com <mailto:ckoenig.leichtzumer...@gmail.com>> wrote: Hi Rex, I think still initializing the PSP even when you don't need it for fir

Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module

2018-03-09 Thread Zhu, Rex
all gpu. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Saturday, March 10, 2018 1:02 AM To: Koenig, Christian Cc: Zhu, Rex; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module On Fri,

Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module

2018-03-08 Thread Christian König
Hi Rex, I think still initializing the PSP even when you don't need it for firmware upload sounds like a good idea to me. But take that with a grain of salt since I really on don't know that part of the hardware so well. Christian. Am 09.03.2018 um 06:10 schrieb Zhu, Rex: Hi Alex, How

Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module

2018-03-08 Thread Zhu, Rex
Hi Alex, How about keep the firmware type checking in set_ip_blocks. and remove the same check code in psp module. also no need to change load type if psp load firmware failed in psp module. Please review the attached patch. Best Regards Rex From: amd-gfx