Re: [PATCH 2/4] drm/ttm: consistently use reservation_object_unlock

2017-11-08 Thread Christian König
Am 08.11.2017 um 18:37 schrieb Michel Dänzer: On 08/11/17 05:41 PM, Christian König wrote: Am 08.11.2017 um 17:36 schrieb Michel Dänzer: On 08/11/17 03:59 PM, Christian König wrote: Instead of having a pointless wrapper or call the underlying ww_mutex function directly. Not sure I can agree

Re: [PATCH 2/4] drm/ttm: consistently use reservation_object_unlock

2017-11-08 Thread Michel Dänzer
On 08/11/17 05:41 PM, Christian König wrote: > Am 08.11.2017 um 17:36 schrieb Michel Dänzer: >> On 08/11/17 03:59 PM, Christian König wrote: >>> Instead of having a pointless wrapper or call the underlying ww_mutex >>> function directly. >> Not sure I can agree it's pointless, since it recently

Re: [PATCH 2/4] drm/ttm: consistently use reservation_object_unlock

2017-11-08 Thread Christian König
Am 08.11.2017 um 17:36 schrieb Michel Dänzer: On 08/11/17 03:59 PM, Christian König wrote: Instead of having a pointless wrapper or call the underlying ww_mutex function directly. Not sure I can agree it's pointless, since it recently took me a while to realize that unlocking bo->resv is

Re: [PATCH 2/4] drm/ttm: consistently use reservation_object_unlock

2017-11-08 Thread Michel Dänzer
On 08/11/17 03:59 PM, Christian König wrote: > Instead of having a pointless wrapper or call the underlying ww_mutex > function directly. Not sure I can agree it's pointless, since it recently took me a while to realize that unlocking bo->resv is essentially the same as unreserving the BO.