RE: [PATCH 2/8] drm/amdgpu: create new files for arcturus ih

2020-03-19 Thread Zhang, Hawking
ts.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Subject: Re: [PATCH 2/8] drm/amdgpu: create new files for arcturus ih How much overlap is there between arcturus_ih and nave10_ih? Given that they both use the same register map, could they share

Re: [PATCH 2/8] drm/amdgpu: create new files for arcturus ih

2020-03-18 Thread Deucher, Alexander
From: amd-gfx on behalf of Felix Kuehling Sent: Wednesday, March 18, 2020 7:33 PM To: Sierra Guiza, Alejandro (Alex) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/8] drm/amdgpu: create new files for arcturus ih How much overlap is there between arcturus_ih and nave10_ih

Re: [PATCH 2/8] drm/amdgpu: create new files for arcturus ih

2020-03-18 Thread Felix Kuehling
How much overlap is there between arcturus_ih and nave10_ih? Given that they both use the same register map, could they share the same driver code with only minor differences? If they're almost the same, maybe you could rename navi10_ih.[ch] to osssys_v5_0.[ch] and use it for both navi10 and