Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-21 Thread Rodrigo Siqueira Jordao
On 2021-10-11 11:16 a.m., Simon Ser wrote: Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") changed the atomic validation code to forbid the overlay plane from being used if it doesn't cover the whole CRTC. The motivation is that ChromeOS uses the atomic

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-14 Thread Simon Ser
On Tuesday, October 12th, 2021 at 23:03, Alex Deucher wrote: > > > @Harry Wentland, @Simon Ser Do you have a preference on whether we > > > apply this patch or revert ddab8bd788f5? I'm fine with either. I'd prefer to revert because (1) the ChromeOS team seems to be okay with that (2) they can

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Alex Deucher
On Tue, Oct 12, 2021 at 4:57 PM Harry Wentland wrote: > > > > On 10/12/21 3:57 PM, Alex Deucher wrote: > > On Tue, Oct 12, 2021 at 10:39 AM Harry Wentland > > wrote: > >> > >> On 2021-10-11 11:16, Simon Ser wrote: > >>> Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when >

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Harry Wentland
On 10/12/21 3:57 PM, Alex Deucher wrote: On Tue, Oct 12, 2021 at 10:39 AM Harry Wentland wrote: On 2021-10-11 11:16, Simon Ser wrote: Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") changed the atomic validation code to forbid the overlay plane from

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Alex Deucher
On Tue, Oct 12, 2021 at 10:39 AM Harry Wentland wrote: > > On 2021-10-11 11:16, Simon Ser wrote: > > Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when > > using overlay") changed the atomic validation code to forbid the > > overlay plane from being used if it doesn't cover

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Harry Wentland
On 2021-10-11 11:16, Simon Ser wrote: > Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when > using overlay") changed the atomic validation code to forbid the > overlay plane from being used if it doesn't cover the whole CRTC. The > motivation is that ChromeOS uses the atomic

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Simon Ser
On Tuesday, October 12th, 2021 at 11:24, Paul Menzel wrote: > Thank you for the explanation. Then I misunderstood commit ddab8bd7 > (drm/amd/display: Fix two cursor duplication when using overlay) from > the Fixes tag, as commit ddab8bd7 does not mention Chrome OS, and also > does not carry a

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Paul Menzel
Dear Simon, Am 12.10.21 um 11:15 schrieb Simon Ser: On Tuesday, October 12th, 2021 at 11:08, Paul Menzel wrote: the cursor plane (which uses the legacy API). Thus amdgpu must always be prepared to enable/disable/move the cursor plane at any time without failing (or else ChromeOS will trip

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Simon Ser
On Tuesday, October 12th, 2021 at 11:08, Paul Menzel wrote: > > the cursor plane (which uses the legacy API). Thus amdgpu must always > > be prepared to enable/disable/move the cursor plane at any time without > > failing (or else ChromeOS will trip over). > > What ChromeOS version did you test

Re: [PATCH v5] amd/display: only require overlay plane to cover whole CRTC on ChromeOS

2021-10-12 Thread Paul Menzel
Dear Simon, Am 11.10.21 um 17:16 schrieb Simon Ser: Commit ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") changed the atomic validation code to forbid the overlay plane from being used if it doesn't cover the whole CRTC. The motivation is that ChromeOS uses the