Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-07-04 Thread Marek Olšák
On Tue, Jul 4, 2017 at 10:09 AM, Michel Dänzer wrote: > On 03/07/17 10:03 PM, Marek Olšák wrote: >> On Mon, Jul 3, 2017 at 12:08 PM, Michel Dänzer wrote: >>> On 30/06/17 08:43 PM, Marek Olšák wrote: I don't know what is being talked about here

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-07-04 Thread Michel Dänzer
On 03/07/17 10:03 PM, Marek Olšák wrote: > On Mon, Jul 3, 2017 at 12:08 PM, Michel Dänzer wrote: >> On 30/06/17 08:43 PM, Marek Olšák wrote: >>> >>> I don't know what is being talked about here anymore, but I wouldn't >>> like to use CPU_ACCESS_REQUIRED or

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-07-03 Thread Marek Olšák
On Mon, Jul 3, 2017 at 12:08 PM, Michel Dänzer wrote: > On 30/06/17 08:43 PM, Marek Olšák wrote: >> >> I don't know what is being talked about here anymore, but I wouldn't >> like to use CPU_ACCESS_REQUIRED or CPU_ACCESS_REALLY_REQUIRED in >> userspace. The reason is that

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-07-03 Thread Michel Dänzer
On 30/06/17 08:43 PM, Marek Olšák wrote: > > I don't know what is being talked about here anymore, but I wouldn't > like to use CPU_ACCESS_REQUIRED or CPU_ACCESS_REALLY_REQUIRED in > userspace. The reason is that userspace doesn't and can't know whether > CPU access will be required, and the

[PATCH RFC 0/2] Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-30 Thread John Brooks
> On 30/06/17 03:59 PM, Christian König wrote: >> Am 30.06.2017 um 08:51 schrieb Michel Dänzer: >>> We can deal with that internally in the kernel, while fixing the >>> existing flag for userspace. >> And as I said, NAK to that approach. I'm not going to add a >> CPU_ACCESS_REALLY_REQUIRED flag in

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-30 Thread Marek Olšák
On Fri, Jun 30, 2017 at 12:34 PM, Christian König wrote: > Am 30.06.2017 um 09:14 schrieb Michel Dänzer: >> >> On 30/06/17 03:59 PM, Christian König wrote: >>> >>> Am 30.06.2017 um 08:51 schrieb Michel Dänzer: We can deal with that internally in the kernel,

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-30 Thread Christian König
Am 30.06.2017 um 09:14 schrieb Michel Dänzer: On 30/06/17 03:59 PM, Christian König wrote: Am 30.06.2017 um 08:51 schrieb Michel Dänzer: We can deal with that internally in the kernel, while fixing the existing flag for userspace. And as I said, NAK to that approach. I'm not going to add a

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-30 Thread Michel Dänzer
On 30/06/17 03:59 PM, Christian König wrote: > Am 30.06.2017 um 08:51 schrieb Michel Dänzer: >> We can deal with that internally in the kernel, while fixing the >> existing flag for userspace. > > And as I said, NAK to that approach. I'm not going to add a > CPU_ACCESS_REALLY_REQUIRED flag in the

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-30 Thread Christian König
Am 30.06.2017 um 08:51 schrieb Michel Dänzer: We can deal with that internally in the kernel, while fixing the existing flag for userspace. And as I said, NAK to that approach. I'm not going to add a CPU_ACCESS_REALLY_REQUIRED flag in the kernel just because mesa has messed up it's use case.

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-30 Thread Christian König
Am 30.06.2017 um 03:36 schrieb Michel Dänzer: On 30/06/17 12:03 AM, Marek Olšák wrote: Do you have any concern if we also stop using the CPU_ACCESS flag on radeon? No concern from my side for radeon. On Thu, Jun 29, 2017 at 4:51 PM, Christian König wrote: Yeah, I

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-29 Thread Mao, David
Sounds good! One thing to confirm, If the original location is already in the invisible, will the notifier callback to move the bo from invisible to visible? if it is true and the logic is already available in the kernel, can we use NO_CPU_ACCESS flag by default to accomplish the similar

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-29 Thread Michel Dänzer
On 30/06/17 10:55 AM, Mao, David wrote: > Vulkan allows the application to decide whether it wants the allocation > to be host visible and device local. > If we drop the flag, what will happen if we did not set the > NO_CPU_ACCESS flag? > Will it fail the map in case the allocation could be

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-29 Thread Mao, David
Vulkan allows the application to decide whether it wants the allocation to be host visible and device local. If we drop the flag, what will happen if we did not set the NO_CPU_ACCESS flag? Will it fail the map in case the allocation could be placed in invisible heap then? Thanks. Best Regards,

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-29 Thread Michel Dänzer
On 30/06/17 12:03 AM, Marek Olšák wrote: > Do you have any concern if we also stop using the CPU_ACCESS flag on radeon? No concern from my side for radeon. > On Thu, Jun 29, 2017 at 4:51 PM, Christian König > wrote: >> Yeah, I was thinking something similar. >> >> See

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-29 Thread Marek Olšák
Do you have any concern if we also stop using the CPU_ACCESS flag on radeon? Thanks, Marek On Thu, Jun 29, 2017 at 4:51 PM, Christian König wrote: > Yeah, I was thinking something similar. > > See the intention behind CPU_ACCESS_REQUIRED is to always guarantee that CPU

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

2017-06-29 Thread Christian König
Yeah, I was thinking something similar. See the intention behind CPU_ACCESS_REQUIRED is to always guarantee that CPU access is immediately possible. If you ask me that is not really useful for the UMD and was never meant to be used by Mesa (only the closed source UMD and some kernel internal