Re: PRT support for amdgpu v3

2017-02-13 Thread Christian König
Hi Nicolai, that one should be fixed by "drm/amdgpu: fix PRT cleanup order in the VM". Please test and/or review. Thanks, Christian. Am 12.02.2017 um 12:36 schrieb Nicolai Hähnle: Hi, Some more testing uncovered a bug in cleanup paths. When the application segfaults while PRT mappings

Re: PRT support for amdgpu v3

2017-02-12 Thread Nicolai Hähnle
Hi, Some more testing uncovered a bug in cleanup paths. When the application segfaults while PRT mappings exist, I get a WARN_ON (which seems fairly straightforward) and occasionally also an RCU error warning -- see the attached dmesg logs. Regular application shutdown works fine, though.

Re: PRT support for amdgpu v3

2017-02-09 Thread Bas Nieuwenhuizen
Tested on amd-staging-4.9 + these patches, and it works for me too. Thanks, Bas Nieuwenhuizen On Wed, Feb 8, 2017, at 16:04, Christian König wrote: > Hi guys, > > ok I finally found time to write an unit test for this and hammered out > the last few bugs. > > Seems to work fine on my Tonga

Re: PRT support for amdgpu v3

2017-02-09 Thread Christian König
Am 09.02.2017 um 11:11 schrieb Nicolai Hähnle: On 08.02.2017 16:04, Christian König wrote: Hi guys, ok I finally found time to write an unit test for this and hammered out the last few bugs. Seems to work fine on my Tonga now. Please note that this set is based on "fix race in GEM VA map

Re: PRT support for amdgpu v3

2017-02-09 Thread Nicolai Hähnle
On 08.02.2017 16:04, Christian König wrote: Hi guys, ok I finally found time to write an unit test for this and hammered out the last few bugs. Seems to work fine on my Tonga now. Please note that this set is based on "fix race in GEM VA map IOCTL v2", without that patch you will run into a

Re: PRT support for amdgpu v2

2017-02-02 Thread Bas Nieuwenhuizen
What branch is this based on? It fails to apply for me on drm-next-4.11-wip of Alex' git repo. On Thu, Feb 2, 2017, at 11:25, Christian König wrote: > Hi guys, > > a bunch of bug fixes, but still completely untested since I'm on sick > leave. > > Bas maybe you could give it a try with radv. >

Re: PRT support for amdgpu

2017-02-02 Thread Christian König
Am 02.02.2017 um 10:33 schrieb Nicolai Hähnle: On 02.02.2017 10:29, Bas Nieuwenhuizen wrote: On Thu, Feb 2, 2017, at 10:18, Nicolai Hähnle wrote: On 02.02.2017 02:49, Dave Airlie wrote: I think we would require a fully open source user for this sort of thing, there are way to many corner

Re: PRT support for amdgpu

2017-02-02 Thread Nicolai Hähnle
On 02.02.2017 10:29, Bas Nieuwenhuizen wrote: On Thu, Feb 2, 2017, at 10:18, Nicolai Hähnle wrote: On 02.02.2017 02:49, Dave Airlie wrote: I think we would require a fully open source user for this sort of thing, there are way to many corner cases for us to fall down here, prematurely pushing

Re: PRT support for amdgpu

2017-02-02 Thread Bas Nieuwenhuizen
On Thu, Feb 2, 2017, at 10:18, Nicolai Hähnle wrote: > [ ceterum censeo, + John for addrlib :P ] > > On 02.02.2017 02:49, Dave Airlie wrote: > >>> answered better by Dave. > >> > >> > >> Yeah, though so as well. Dave can you comment? > > > > I think we would require a fully open source user for

Re: PRT support for amdgpu

2017-02-02 Thread Nicolai Hähnle
[ ceterum censeo, + John for addrlib :P ] On 02.02.2017 02:49, Dave Airlie wrote: answered better by Dave. Yeah, though so as well. Dave can you comment? I think we would require a fully open source user for this sort of thing, there are way to many corner cases for us to fall down here,

Re: PRT support for amdgpu

2017-02-01 Thread Dave Airlie
>> answered better by Dave. > > > Yeah, though so as well. Dave can you comment? I think we would require a fully open source user for this sort of thing, there are way to many corner cases for us to fall down here, prematurely pushing the API without a proven test suite running on it would be

Re: PRT support for amdgpu

2017-02-01 Thread Nicolai Hähnle
On 31.01.2017 17:28, Christian König wrote: Am 31.01.2017 um 14:06 schrieb Bas Nieuwenhuizen: So this API seems usable, and I think this is something we can use for radv. However, I'm not sure how much time it takes for us to implement, as the TFE variants are not in LLVM yet and I haven't

Re: PRT support for amdgpu

2017-01-31 Thread Christian König
Am 31.01.2017 um 17:09 schrieb Alex Deucher: On Mon, Jan 30, 2017 at 7:57 AM, Christian König wrote: Hi Dave and Bas, Hi Dave and Bas, the following set of patches is a proposal for adding support for partial resident textures (PRT) to the amdgpu kernel module. The

Re: PRT support for amdgpu

2017-01-31 Thread Christian König
Am 31.01.2017 um 14:06 schrieb Bas Nieuwenhuizen: On Mon, Jan 30, 2017, at 13:57, Christian König wrote: Hi Dave and Bas, Hi Dave and Bas, the following set of patches is a proposal for adding support for partial resident textures (PRT) to the amdgpu kernel module. The basic idea behind PRT

Re: PRT support for amdgpu

2017-01-31 Thread Alex Deucher
On Mon, Jan 30, 2017 at 7:57 AM, Christian König wrote: > Hi Dave and Bas, > > Hi Dave and Bas, > > the following set of patches is a proposal for adding support for partial > resident textures (PRT) to the amdgpu kernel module. > > The basic idea behind PRT support is

Re: PRT support for amdgpu

2017-01-31 Thread Bas Nieuwenhuizen
On Mon, Jan 30, 2017, at 13:57, Christian König wrote: > Hi Dave and Bas, > > Hi Dave and Bas, > > the following set of patches is a proposal for adding support for partial > resident textures (PRT) to the amdgpu kernel module. > > The basic idea behind PRT support is that you turn of VM

Re: PRT support for amdgpu

2017-01-30 Thread Nicolai Hähnle
[ Cc John for addrlib ] On 30.01.2017 13:57, Christian König wrote: An open problem with the proposal is that we don't know when or if we want to add the userspace implementation into radeonsi. So price question could you guys use this for radv as well? Or is it sufficient to just write an