[PATCH v2] drm/amd/powerplay: enable power containment features for tonga.

v2: fix build error introduced when fix code style problems. Change-Id: Ifa9bdfd92fe060349cfbf7c10cd75d30d8acb95d Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 24 +-

Kernel deadlock in amdgpu_job_submit

Hi, I have a kernel deadlock here. Piglit tests running at the same time: marek32295 0.0 0.6 472148 50100 ?Ssl 12:53 0:00 /home/marek/dev/piglit/bin/gl-1.0-blend-func -auto -fbo marek32403 0.0 0.6 532528 55908 ?Ssl 12:53 0:00 /home/marek/dev/piglit/bin/tex3d

[PATCH 2/5] drm/amdgpu: fix amdgpu_move_blit on 32bit systems

From: Christian König This bug seems to be present for a very long time. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 4/5] drm/amdgpu: fix sdma_v2_4_ring_test_ib

From: Christian König Typo in checking the return code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c

[PATCH 5/5] drm/amdgpu: fix timeout value check in amd_sched_job_recovery

From: Christian König Could be that we don't actually have a timeout set. Signed-off-by: Christian König --- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Kernel deadlock in amdgpu_job_submit

[11160.387924] [] amd_sched_entity_push_job+0x77/0x110 [amdgpu] [11160.387927] [] ? wake_atomic_t_function+0x60/0x60 [11160.387943] [] amdgpu_job_submit+0x84/0xc0 [amdgpu] [11160.387953] [] amdgpu_copy_buffer+0x14a/0x1c0 [amdgpu] [11160.387963] [] amdgpu_move_blit+0x9d/0x140 [amdgpu] It's

Re: [PATCH 0/8] shadow page table support V5 ---> shadow bo support

Why not be consistent and add a DRM_ERROR on all paths that include an error? e.g. instead of if (r) goto error_free; Throw a DRM_ERROR("") in there. Tom From: amd-gfx on behalf of Christian König

[PATCH xserver 4/6] modesetting: exclude DRI2 and Present page flip

Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/dri2.c| 13 +++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 3 +++ hw/xfree86/drivers/modesetting/present.c | 15 +++ 3 files changed, 29 insertions(+), 2 deletions(-)

Re: [PATCH 0/8] shadow page table support V5 ---> shadow bo support

Errors should actually be reported by the caller, not here. So we should probably remove that DRM_ERROR here as well. Christian. Am 17.08.2016 um 16:10 schrieb StDenis, Tom: Why not be consistent and add a DRM_ERROR on all paths that include an error? e.g. instead of if (r) goto

RE: [PATCH v2] drm/amd/powerplay: enable power containment features for tonga.

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, August 17, 2016 6:06 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH v2] drm/amd/powerplay: enable power containment > features for tonga. >

Re: [PATCH 1/5] drm/radeon: fix radeon_move_blit on 32bit systems

On Wed, Aug 17, 2016 at 8:26 AM, Christian König wrote: > From: Christian König > > This bug seems to be present for a very long time. > > Signed-off-by: Christian König Patches 1,2,4 are: Reviewed-by: Alex Deucher

Re: [PATCH 0/8] shadow page table support V5 ---> shadow bo support

Patch #1: Could be that we need to add another module parameter to control this, but I think for now that should be sufficient. Patch is Reviewed-by: Christian König Patch #2: + if (direct_submit) { + r = amdgpu_ib_schedule(ring, job->num_ibs,

slowpath warning on Tonga

I just happened to notice this on my Tonga. It's otherwise operating fine. For ref, it's attached to a HDMI KVM which eventually makes it way to a DVI-D monitor. [ 28.579561] [ cut here ] [ 28.579613] WARNING: CPU: 4 PID: 1276 at

RE: [PATCH] drm/amd/amdgpu: Add more debugfs config data

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Wednesday, August 17, 2016 12:13 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/amd/amdgpu: Add more debugfs config data > > Adds

Re: [PATCH 3/5] drm/amdgpu: fix lru size grouping

One suggestion inline [FK]. With that fixed, Reviewed-by: Felix Kuehling Regards, Felix On 16-08-17 08:26 AM, Christian König wrote: > From: Christian König > > Adding a BO can make it the insertion point for larger sizes as well. > >

Re: Random short freezes due to TTM buffer migrations

Actually, I was wrong. The buffers in that app are pretty small. The largest one has 86 MB and others have 52 MB. I must have misread that as 520 MB. At one point, ttm_bo_validate with a 32 MB buffer moved 971 MB. Maybe it's just a VRAM fragmentation issue (i.e. a lack of contiguous free

Re: Random short freezes due to TTM buffer migrations

Sharing buffers between applications is handled by the DRM layer and transparent to the driver. E.g. the driver is not even informed if a sharing is done by DMA-buf or GEM flink, it's just another reference to the BO. So there isn't any change to that at all. Regards, Christian. Am

Re: Random short freezes due to TTM buffer migrations

I think the scatter-gather tables only support system memory. As I understand it, a buffer in VRAM has be migrated to system memory before it can be shared with another driver. I'm more concerned about sharing with the same driver. There is a special code path for that, where we simply add

[pull] amdgpu drm-fixes-4.8

Hi Dave, Just one small fix for amdgpu this week for systems with a gart aperture > 4 GB. The following changes since commit 93b1f14553a5f48104b639d28e41c2bb73c0dc37: Merge tag 'mediatek-drm-fixes-2016-08-12' of git://git.pengutronix.de/git/pza/linux into drm-fixes (2016-08-15 16:07:14

[PATCH 6/8] drm/amdgpu: link all shadow bo

Change-Id: I8af3b42e1b5d84ca04277f95aeca44cbc534ccb2 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 14 +- 3 files changed,

[PATCH 0/8] shadow page table support V5 ---> shadow bo support

Since we cannot ensure VRAM is consistent after a GPU reset, page table shadowing is necessary. Shadowed page tables are, in a sense, a method to recover the consistent state of the page tables before the reset occurred. We need to allocate GTT bo as the shadow of VRAM bo when creating page

[PATCH xserver 6/6] modesetting: remove redundent pixmap destroy

Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/dri2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c index 4cf638e..b18f0b8 100644 --- a/hw/xfree86/drivers/modesetting/dri2.c +++

Re: [PATCH] drm/amdgpu: For virtual_display feature, the vblank_get_counter hook is always return 0 when there's no hardware frame counter which can be used.

On 17/08/16 02:47 PM, Deng, Emily wrote: >> -Original Message- >> From: Michel Dänzer [mailto:mic...@daenzer.net] >> Sent: Wednesday, August 17, 2016 11:50 AM >> To: Deng, Emily >> Cc: amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH] drm/amdgpu: For

[PATCH xserver 0/6] modesetting: add DRI2 page flip support

Hi guys, This patch set is for adding DRI2 page flip support to modesetting driver. I mainly take reference of amdgpu DDX and reuse present page flip code in the modesetting driver. Regards, Qiang Qiang Yu (6): modesetting: make ms_do_pageflip generic for share with DRI2 modesetting: move

[PATCH xserver 2/6] modesetting: move ms_do_pageflip to pageflip.c

Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/Makefile.am | 1 + hw/xfree86/drivers/modesetting/driver.h| 48 ++ hw/xfree86/drivers/modesetting/pageflip.c | 251 hw/xfree86/drivers/modesetting/present.c | 252

[PATCH xserver 3/6] modesetting: add DRI2 page flip support

Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/dri2.c | 260 -- 1 file changed, 251 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c index 83cb3e0..11e0e6f

[PATCH] drm/amd/powerplay: enable power containment features for tonga.

Change-Id: Ibe7ddaea7188d40204b33574402d88bf50acff62 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 24 +- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.h | 11 +-

[PATCH 4/8] drm/amdgpu: update pd shadow while updating pd

Change-Id: Ief33f9539c24e1ab696935e2bfedd3630c07fc67 Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 55 +++--- 2

RE: Random short freezes due to TTM buffer migrations

It becomes regular for application to request a big chunk of memory and do the sub-allocation by itself. I agree Kernel should do better to provide fine grained paging granularity. I don't know whether 1/2 of vram is the biggest single allocation application would like to do, but it is better

[PATCH xserver 1/6] modesetting: make ms_do_pageflip generic for share with DRI2

Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/present.c | 36 +++- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c index

Re: [PATCH 4/5] drm/amdgpu: fix sdma_v2_4_ring_test_ib

On 2016年08月17日 20:26, Christian König wrote: From: Christian König Typo in checking the return code. Signed-off-by: Christian König Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- 1

Re: [PATCH 5/5] drm/amdgpu: fix timeout value check in amd_sched_job_recovery

On 2016年08月17日 20:26, Christian König wrote: From: Christian König Could be that we don't actually have a timeout set. Signed-off-by: Christian König Reviewed-by: Chunming Zhou ---

[PATCH 5/7] drm/amdgpu: update pt shadow while updating pt V2

V2: move shadow parameter to amdgpu_pte_update_params. Change-Id: Ibc8fb4c5c9be38934ebd6d56f1cbd49cb82d53af Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

[PATCH 1/7] drm/amdgpu: add need backup function V2

V2: add checking if need backup in amdgpu_bo_create. Change-Id: I76e2552078c9ae11b7f2a1769025230f61733659 Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +

[PATCH 7/7] drm/amdgpu: recover vram bo from shadow after gpu reset

Change-Id: I963598ba6eb44bc8620d70e026c0175d1a1de120 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 60 +- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 2/3] drm/amdgpu: allow pagelist to be NULL for amdgpu_gart_bind

Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c index 0feea34..03b9fd6 100644 ---

[PATCH 2/7] drm/amdgpu: add direct submision option for copy_buffer

Change-Id: I3acdcf24b0ccb86d5f2b0593ffcf3dad8b6ad29f Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 3 ++-