[PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed

2016-09-14 Thread Monk Liu
Change-Id: Ic4bb5cb748180d60a672f9e160f1f3308397029b Signed-off-by: Monk Liu Conflicts: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Marek Olšák
Hi, This patch causes a massive performance drop (by a factor of 100) followed by GPU hangs with F1 2015 (it needs more than 3GB of memory, the card has 2GB). The game normally works really well (30+ FPS on Polaris11 2GB, 40+ FPS on Tonga 2GB). It should be fixed or the commit should be reverted

Re: [PATCH] drm/amd/powerplay: Partially revert change initialize platform caps

2016-09-14 Thread Alex Deucher
On Wed, Sep 14, 2016 at 4:38 AM, Rex Zhu wrote: > partially revert commit I36f3c9e3a28cbf290652edfb6e19109da660c4f1 > this will lead APU can't work. > > Change-Id: I2233e2f21058540ff782e27e07fa0d0937692ace > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher

RE: [PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed

2016-09-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, September 14, 2016 7:48 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed > >

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Christian König
Thanks for that info, I was busy most of the day bisecting this regression as well. Yeah, the bug is rather obvious, there is a "return 0;" in the good case missing here. So after loading the firmware we release it again. I will hack together a patch, just give me a minute. Christian. Am

Re: [PATCH] drm/amdgpu/si/dpm: fix swapped ck enable

2016-09-14 Thread StDenis, Tom
Yup, that looks better. My apologies. Guess that's the downside of having assertions for enable and disable in the same driver. Reviewed-by: Tom St Denis From: amd-gfx on behalf of Alex Deucher

Re: [PATCH] drm/amdgpu: fix regression in amdgpu_ucode_init_bo

2016-09-14 Thread Alex Deucher
On Wed, Sep 14, 2016 at 10:58 AM, Christian König wrote: > From: Christian König > > Going into the error case when everything works is a bad idea. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher

RE: [PATCH] drm/amd/powerplay: fix potential issue of array access violation

2016-09-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, September 14, 2016 7:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amd/powerplay: fix potential issue of array access > violation

[PATCH 2/4] drm/amdgpu/atif: Send a hotplug event when we get dgpu display request

2016-09-14 Thread Alex Deucher
On PX systems, if the platform supports hotplug events ATIF while the dGPU is powered down, handle the event and alert userspace. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 1/4] drm/amdgpu/atpx: check for ATIF dGPU wake for display events support

2016-09-14 Thread Alex Deucher
Some ATPX laptops implement special circuitry to generate display hotplug events via ACPI when the dGPU is powered off. Check if this is supported. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++

[PATCH 4/4] drm/radeon/atif: Send a hotplug event when we get dgpu display request

2016-09-14 Thread Alex Deucher
On PX systems, if the platform supports hotplug events ATIF while the dGPU is powered down, handle the event and alert userspace. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_acpi.c | 17 + 1 file changed, 17 insertions(+) diff --git

Re: [PATCH xserver] config: fix GPUDevice fail when AutoAddGPU off + BusID

2016-09-14 Thread Michel Dänzer
On 08/09/16 10:24 PM, Qiang Yu wrote: > This fix is for the following xorg.conf can work: > > Section "ServerFlags" > Option "AutoAddGPU" "off" > EndSection > > Section "Device" > Identifier "Amd" > Driver "ati" > BusID "PCI:1:0:0" > EndSection > > Section

Re: [PATCH] drm/amdgpu: gtt offset should be 64 bit

2016-09-14 Thread Flora Cui
yes. i just find it out. it's commit 9040cf0a in 4.6 branch yet not in 4.7. please ignore this commit. On Wed, Sep 14, 2016 at 11:32:32AM +0200, Christian König wrote: > Am 14.09.2016 um 11:13 schrieb Flora Cui: > >Change-Id: I05618a472b1ebf381575d02e226264609bf4db7f > >Signed-off-by: Flora Cui

[PATCH xf86-video-ati 3/4] DRI2: Add interpolated_vblanks in radeon_dri2_get_crtc_msc

2016-09-14 Thread Michel Dänzer
From: Michel Dänzer We need that in radeon_dri2_drawable_crtc as well for priv->vblank_delta to work as intended. radeon_dri2_get_msc was already doing this. Fixes hangs in some cases when using VDPAU via DRI2 and moving the window between CRTCs. (Ported from amdgpu

[PATCH] drm/amdgpu: gtt offset should be 64 bit

2016-09-14 Thread Flora Cui
Change-Id: I05618a472b1ebf381575d02e226264609bf4db7f Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 10 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] drm/amd/powerplay: Partially revert change initialize platform caps

2016-09-14 Thread Huang Rui
On Wed, Sep 14, 2016 at 04:38:37PM +0800, Rex Zhu wrote: > partially revert commit I36f3c9e3a28cbf290652edfb6e19109da660c4f1 > this will lead APU can't work. > > Change-Id: I2233e2f21058540ff782e27e07fa0d0937692ace > Signed-off-by: Rex Zhu Reviewed-by: Huang Rui

Re: [PATCH 3/5] drm/amdgpu:fix RB cost calculator

2016-09-14 Thread Andy Furniss
This has just gone into drm-next-4.9-wip and caused lots of logging noise. Seems to work OK though. Sep 14 23:18:38 ph4 kernel: [drm:gfx_v8_0_ring_emit_fence_gfx [amdgpu]] *ERROR* amdgpu: writing more dwords to the ring than expected! Sep 14 23:18:38 ph4 last message repeated 11 times Sep 14

Re: [PATCH] drm/amdgpu: fix regression in amdgpu_ucode_init_bo

2016-09-14 Thread Huang Rui
On Wed, Sep 14, 2016 at 04:58:21PM +0200, Christian König wrote: > From: Christian König > > Going into the error case when everything works is a bad idea. > > Signed-off-by: Christian König > --- Christian, thanks. Acked-by: Huang Rui