ack/nack on sensors patches please

Hi all, Edward reviewed them but I'd like an AMD'er RB/ACK/NAK as well on the updated series I posted last week please. https://lists.freedesktop.org/archives/amd-gfx/2016-September/002359.html Thanks, Tom ___ amd-gfx mailing list

[PATCH] drm/amdgpu:cleanup virt related define

move virtual machine related structure to amdgpu_virt.h easy for developer to maintain for virualization stuffs Change-Id: I8cd9904a8ec220345f96214ade7c8030cf6a39f3 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 32 +

[PATCH] drm/amdgpu: use powerplay module for dgpu of VI.

delete vi dpm related code and files. Change-Id: I080de47df12d45be06a72fe229695675cf6648d6 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/Makefile | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c | 13 +- drivers/gpu/drm/amd/amdgpu/fiji_dpm.c |

Re: [PATCH] drm/amdgpu:cleanup virt related define

Am 19.09.2016 um 13:04 schrieb Monk Liu: move virtual machine related structure to amdgpu_virt.h easy for developer to maintain for virualization stuffs Change-Id: I8cd9904a8ec220345f96214ade7c8030cf6a39f3 Signed-off-by: Monk Liu Acked-by: Christian König

Re: [PATCH] drm/amdgpu: use powerplay module for dgpu of VI.

So now just pure PP paths for Tonga, Fiji & Topaz. Is there any perf or power usage difference from this change-set across any of these ASIC's? Acked-by: Edward O'Callaghan On 09/19/2016 10:17 PM, Rex Zhu wrote: > delete vi dpm related code and files. > >

[PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v3)

Provides standardized interface to read various sensors. The API is extensible (by adding to the end of the amd_pp_sensors enumeration list. Support has been added to Carrizo/smu7 (v2) Squashed the two sensor patches into one. (v3) Updated to apply to smu7_hwmgr instead Signed-off-by: Tom St

[PATCH 2/2] drm/amd/amdgpu: Hook up read_sensor() to debugfs (v2)

(v2) Tidy'ed up read function. Signed-off-by: Tom St Denis Reviewed-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 31 ++ 1 file changed, 31 insertions(+) diff --git

Re: [PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v3)

On Mon, Sep 19, 2016 at 9:10 AM, Tom St Denis wrote: > Provides standardized interface to read various sensors. > The API is extensible (by adding to the end of the > amd_pp_sensors enumeration list. > > Support has been added to Carrizo/smu7 > > (v2) Squashed the two sensor

Re: [pull] radeon and amdgpu drm-next-4.9

On Sat, Sep 17, 2016 at 6:23 AM, Lukas Wunner wrote: > On Fri, Sep 16, 2016 at 06:07:36PM -0400, Alex Deucher wrote: >> On Fri, Sep 16, 2016 at 5:38 PM, Lukas Wunner wrote: >> > On Fri, Sep 16, 2016 at 04:42:43PM -0400, Alex Deucher wrote: >> >>

RE: [PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v3)

No need. The additional cleanups can come later. Alex From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of StDenis, Tom Sent: Monday, September 19, 2016 11:55 AM To: Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to

Re: [PATCH] drm/amdgpu: use powerplay module for dgpu of VI.

On Mon, Sep 19, 2016 at 8:17 AM, Rex Zhu wrote: > delete vi dpm related code and files. > > Change-Id: I080de47df12d45be06a72fe229695675cf6648d6 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 5 +- >

Re: [PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v3)

Hi Alex, Would you prefer I re-write #1 to avoid churn in the tree? Cheers, Tom From: Alex Deucher Sent: Monday, September 19, 2016 11:53 To: Tom St Denis Cc: amd-gfx list; StDenis, Tom Subject: Re: [PATCH 1/2] drm/amd/powerplay: Add

[PATCH] drm/amd/powerplay: fix mclk not switching back after multi-head was disabled

From: Rex Zhu Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/powerplay/eventmgr/eventactionchains.c | 2 ++

Re: [PATCH] drm/amd/powerplay/smumgr: mark symbols static where possible

Hi Baoyou, On Mon, Sep 19, 2016 at 03:28:39PM +0800, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning: > no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes] >

Re: [PATCH 1/2] drm/amd/powerplay: Add read_sensor() callback to hwmgr (v3)

Yup. I misread your comment thinking there was another datastructure you'd rather I put the callback in. Cheers, Tom From: Deucher, Alexander Sent: Monday, September 19, 2016 11:55 To: StDenis, Tom; Alex Deucher Cc: amd-gfx list Subject: RE: [PATCH 1/2]

Re: [PATCH 0/3] drm/amdgpu: implement raster configuration

On 18/09/16 11:36 AM, Huang Rui wrote: > Hi all, > > This patch set is to introduce the raster configuration for all gfx > generations. What's the motivation for doing this in the kernel? Mesa will write its own values to these registers anyway. -- Earthling Michel Dänzer |

Re: [PATCH 4/6] drm/radeon: Provide page_flip_target hook

On 17/09/16 09:41 PM, Mario Kleiner wrote: > Hi Michel, > > all your patches, both the already merged kernel bits in radeon/amdgpu > and also all the userspace bits in libdrm/ati-ddx/amdgpu-ddx are all > > Reviewed-and-tested-by: Mario Kleiner > > I successfully

RE: [PATCH 1/5] drm/amdgpu:changes of virtualization cases probe (v2)

> -Original Message- > From: Edward O'Callaghan [mailto:funfunc...@folklore1984.net] > Sent: Monday, September 19, 2016 7:38 PM > To: Alex Deucher; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; Liu, Monk > Subject: Re: [PATCH 1/5] drm/amdgpu:changes of virtualization cases probe

RE: [PATCH 5/5] drm/amdgpu/si: add detect_hw_virtualization asic callback

All those 5 patches are : Reviewed-by: Monk Liu -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Tuesday, September 20, 2016 2:36 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

RE: [PATCH] drm/amdgpu/si: remove unused interface which caused build issue

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Huang Rui > Sent: Monday, September 19, 2016 4:12 AM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander; Koenig, Christian > Cc: Wang, Ken; Huang, Ray; Liu, Monk > Subject: [PATCH]

RE: [PATCH 3/3] drm/amdgpu: set gfx clock gating for tonga/polaris.

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Sunday, September 18, 2016 5:44 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 3/3] drm/amdgpu: set gfx clock gating for tonga/polaris. > >

[PATCH 2/5] drm/amdgpu:correct smc fw version error

From: Monk Liu original method get wrong smc fw version. Signed-off-by: Monk Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 10 +++--- 1

Re: [PATCH] drm/amdgpu/dce6: fix off by one in interrupt setup

Looks correct and consistent with the other DCE drivers. Reviewed-by: Tom St Denis From: amd-gfx on behalf of Alex Deucher Sent: Monday, September 19, 2016 12:15 To:

[PATCH 5/5] drm/radeon: narrow asic_init for virtualization

Only needed on CIK+ due to the way pci reset is handled by the GPU. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/radeon/radeon_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/amd/powerplay: Replace per-asic print_performance with generic

Replace per-asic print_current_performance() functions with generic that calls read_sensor. Tested on Tonga and Carrizo for aesthetics and accuracy. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 10 +--

[PATCH 1/5] drm/amdgpu/vi: whitespace fixes

function declaration parens should be a new line. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index

[PATCH 3/5] drm/amdgpu: drop unused function

Not used after Monk's rework. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

[PATCH] drm/amdgpu/si: remove unused interface which caused build issue

From: Huang Rui Fix commit (ed22ee2 drm/amdgpu:changes of virtualization cases probe) regression, remove si_get_virtual_caps because the callback is removed at amdgpu_asic_funcs. Signed-off-by: Huang Rui Cc: Monk Liu ---

Re: [PATCH] drm/amdgpu/si: remove unused interface which caused build issue

On Mon, Sep 19, 2016 at 04:31:18PM +0800, Koenig, Christian wrote: > Am 19.09.2016 um 10:11 schrieb Huang Rui: > > From: Huang Rui > > > > Fix commit (ed22ee2 drm/amdgpu:changes of virtualization cases probe) > > regression, remove si_get_virtual_caps because the callback is

RE: [PATCH] drm/amdgpu/si: remove unused interface which caused build issue

You can add my RB -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Huang Rui Sent: Monday, September 19, 2016 4:12 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Koenig, Christian

Re: [PATCH] drm/amdgpu/si: remove unused interface which caused build issue

Am 19.09.2016 um 10:11 schrieb Huang Rui: From: Huang Rui Fix commit (ed22ee2 drm/amdgpu:changes of virtualization cases probe) regression, remove si_get_virtual_caps because the callback is removed at amdgpu_asic_funcs. Signed-off-by: Huang Rui Cc: Monk

Re: [PATCH 1/5] drm/amdgpu/vi: whitespace fixes

Series is, Reviewed-by: Edward O'Callaghan On 09/20/2016 04:35 AM, Alex Deucher wrote: > function declaration parens should be a new line. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 6 -- > 1 file

Re: [PATCH 2/5] drm/amdgpu: make sriov bios detection generic (v2)

Reviewed-by: Edward O'Callaghan as with the rest of the respective series. On 09/20/2016 04:44 AM, Alex Deucher wrote: > It's not asic specific. > > v2: drop asic macro > > Signed-off-by: Alex Deucher > --- >

Re: [PATCH 1/5] drm/amdgpu:changes of virtualization cases probe (v2)

On 09/20/2016 03:12 AM, Alex Deucher wrote: > From: Monk Liu > > 1,Changes on virtualization detections > 2,Don't load smu & mc firmware if using sr-iov bios > 3,skip vPost for sriov & force vPost if dev pass-through > > v2: agd: fix missed SI case > > Signed-off-by: Monk

Re: [PATCH] drm/amd/powerplay: Replace per-asic print_performance with generic

On Mon, Sep 19, 2016 at 1:45 PM, Tom St Denis wrote: > Replace per-asic print_current_performance() functions with generic > that calls read_sensor. Tested on Tonga and Carrizo for aesthetics > and accuracy. > > Signed-off-by: Tom St Denis