Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

Yup confirmed... [root@fx6 linux]# git bisect good da00756f75422b04befae381e7e48d0cacf299f3 is the first bad commit commit da00756f75422b04befae381e7e48d0cacf299f3 Author: Christian König Date: Wed Oct 5 16:09:32 2016 +0200 drm/amdgpu: move align_mask and nop

Re: [PATCH 1/2] drm/amdgpu: clarify why we evict vram twice on suspend

Am 10.10.2016 um 18:49 schrieb Alex Deucher: Update the comment to explain why we do this. Signed-off-by: Alex Deucher Reviewed-by: Christian König for both. --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - 1 file changed, 4

Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

Hi Andy, Ha, I'm 1 step away (that was my last bad commit) from determining that. I'll finish up for formality sake but I suspect that is the bad one. Cheers, Tom From: Andy Furniss Sent: Tuesday, October 11, 2016 09:10 To: StDenis,

Re: [PATCH] drm/amd/amdgpu: Make debugfs write compliment read

Hi Tom, yeah, the timing issue is a good argument. In this case just go ahead and add my Acked-by to the patch. Regards, Christian. Am 11.10.2016 um 14:19 schrieb StDenis, Tom: Hi Christian, I agree with the crux of your argument but you can crash the system with carefully timed

Re: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

Am 11.10.2016 um 15:13 schrieb Andy Furniss: Christian König wrote: From: Christian König They are constant as well. I die on driver load with this commit on R9285 testing on 4.9-wip. Probably just a typo in the hardware handling. Going to switch to my Tonga in

Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

Actually NAK that, I don't have the cache patch internally. So my Tonga crash is something else. Tom From: amd-gfx on behalf of StDenis, Tom Sent: Tuesday, October 11, 2016 08:11 To: Andy Furniss;

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

It's used by the UMD though they read from 0/*/* when reading the RASTER_CONFIG registers (which may be a bug...) I only added it because the previous interface was either */*/* or x/y/z (where none are *). Now it supports arbitrary bank selections. Tom

Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

StDenis, Tom wrote: Actually NAK that, I don't have the cache patch internally. So my Tonga crash is something else. Yes, seems the boot fail starts with the tip commit = drm/amdgpu: move align_mask and nop into ring funcs as well They are constant as well. Will also reply to that patch.

Re: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

It dies on my Tonga just FYI (save you some trouble). Tom From: amd-gfx on behalf of Christian König Sent: Tuesday, October 11, 2016 09:26 To: Andy Furniss; amd-gfx@lists.freedesktop.org

Re: [PATCH 1/6] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag v3

Am 07.10.2016 um 23:19 schrieb Felix Kuehling: On 16-09-27 05:49 AM, Christian König wrote: --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -1195,6 +1195,15 @@ int amdgpu_cs_sysvm_access_required(struct amdgpu_cs_parser *parser) r =

[PATCH 2/2] drm/radeon: fix modeset tear down code

The ordering caused problems. bug: https://bugs.freedesktop.org/show_bug.cgi?id=98200 Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH] drm/amdgpu: fix broken VCE startup in phys mode

From: Christian König Add type, align_mask and nop to the physical mode VCE funcs as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

Yup, with it I get a normal modprobe. Can add my Ack-By: Tom St Denis From: amd-gfx on behalf of Christian König Sent: Tuesday, October 11, 2016 13:33 To:

RE: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Tuesday, October 11, 2016 1:34 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode > > From: Christian König

Re: [PATCH 8/8] drm/amdgpu: move align_mask and nop into ring funcs as well

Turned out I just missed adding the three lines to the physical mode for VCE on Tonga as well. Please test and review the patch I've just send to the mailing list. Regards, Christian. Am 11.10.2016 um 15:28 schrieb StDenis, Tom: It dies on my Tonga just FYI (save you some trouble). Tom

[PATCH 2/3] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. (v2) Fix broadcast range checking Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

More debugfs entries

Resending the MMIO upgrades for completeness. Christian offered an ACK but I'd like to see a RB or NAK. This also adds a debugfs entry used to read wave data on CZ/VI platforms (tested on my Carrizo). The patch #3 already has a use in reading SQ information from user space so I'd like to

[PATCH 3/3] drm/amd/amdgpu: Make debugfs write compliment read

Add PG lock support as well as bank selection to the MMIO write function. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 43 ++ 1 file changed, 43 insertions(+) diff --git

Re: [PATCH] drm/amdgpu: fix broken VCE startup in phys mode

I can boot OK with this. Christian König wrote: From: Christian König Add type, align_mask and nop to the physical mode VCE funcs as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 3 +++ 1 file changed,

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

On 11/10/16 09:04 PM, Christian König wrote: > Am 11.10.2016 um 05:58 schrieb Michel Dänzer: >> On 07/10/16 09:34 PM, Mike Lothian wrote: >>> This has discussion has gone a little quiet >>> >>> Was there any agreement about what needed doing to get this working >>> for i965/amdgpu? >> Christian,

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

On 11/10/16 09:32 PM, StDenis, Tom wrote: > It's used by the UMD though they read from 0/*/* when reading the > RASTER_CONFIG registers (which may be a bug...) We should probably clarify what userspace is trying to do there, and whether the hardware actually does that. -- Earthling Michel

Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

The boot vce/uvd issue is fixed in 4.9-wip now, so I can boot latest but - The segfault on startx is still there. I still can't shutdown/reboot as in https://bugs.freedesktop.org/show_bug.cgi?id=98200 which is fixed for radeon, but apparently not (for me at least) with amdgpu. Reverting amdgpu

Re: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

+Rex to review this. Alex On Sun, Oct 9, 2016 at 3:23 PM, Grazvydas Ignotas wrote: > Currently the driver crashes if smu7_enable_dpm_tasks() returns early, > which it does if DPM is already active. It seems to be better just to > continue anyway, at least I haven't noticed