Re: [PATCH linux] drm/radeon: define RADEON_TILING_R600_NO_SCANOUT

2017-01-13 Thread Emil Velikov
On 9 January 2017 at 18:34, Andres Rodriguez wrote: > Add the missing definition of RADEON_TILING_R600_NO_SCANOUT. > > This define currently exists in the libdrm radeon_drm.h, but missing > from from the kernel radeon_drm.h. This makes the header update process > inconvenient.

Re: [PATCH libdrm] headers: Sync {amdgpu,radeon}_drm.h with the kernel v2

2017-01-13 Thread Emil Velikov
On 9 January 2017 at 18:34, Andres Rodriguez wrote: > Generated using make headers_install from: > airlied/drm-next 3806a27 Merge tag 'drm-misc-next-2016-12-30' ... > + > drm/radeon: define RADEON_TILING_R600_NO_SCANOUT > > By adding RADEON_TILING_R600_NO_SCANOUT to the kernel

Re: [PATCH 2/2] drm/amdgpu: Report VDDC and MVDD over pp_dpm{sclk,mclk}

2017-01-13 Thread StDenis, Tom
It'd be nicer to move these into the PP_SENSORS framework and then print them from pm_info. But other than that I don't have any strong objections to these patches. Tom From: amd-gfx on behalf of Donny Yang

[PATCH 1/2] drm/amdgpu: Switch error code when bo pin fails. (v3)

2017-01-13 Thread Alex Deucher
From: Andrey Grodzovsky Switching to -ENOMEM resolves a hang in case the driver uses this function in atomic code path. v2: Update commit message. v3: Remove forcing -EINVAL in case of amdgpu_bo_pin fail since there is no apparent reason for not just passing through

[PATCH 2/2] drm/amdgpu: Refactor flip into prepare submit and submit. (v2)

2017-01-13 Thread Alex Deucher
From: Andrey Grodzovsky Make pflip atomic friendly. Split the fuinction into whatever can fail part and the actual flip submit part. Call the pre-submit function before atomic states are swapped so in case of error we can fail the IOCTL. v2: Update due to

Re: [PATCH 2/3] drm/amdgpu:implement META-DATA write routines

2017-01-13 Thread Alex Deucher
On Thu, Jan 12, 2017 at 2:41 AM, Monk Liu wrote: > Change-Id: I66007a7f7e4e27fb129121f36143dce3cfb43738 > Signed-off-by: Monk Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 31 ++ > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 61 >

Re: [PATCH 3/3] drm/amdgpu:invoke meta-data write around cntx_cntl

2017-01-13 Thread Alex Deucher
On Thu, Jan 12, 2017 at 2:41 AM, Monk Liu wrote: > ce's META-DATA write need prior to cntx_cntrl package > and de's should following. > > Change-Id: I2bf436d8a16bae38ce484f846f0b399e16cfe80a > Signed-off-by: Monk Liu Reviewed-by: Alex Deucher

Re: [PATCH 1/2] drm/amdgpu: Switch error code when bo pin fails. (v3)

2017-01-13 Thread Christian König
Am 13.01.2017 um 19:26 schrieb Alex Deucher: From: Andrey Grodzovsky Switching to -ENOMEM resolves a hang in case the driver uses this function in atomic code path. v2: Update commit message. v3: Remove forcing -EINVAL in case of amdgpu_bo_pin fail since there is no

Re: [PATCH 2/2] drm/amdgpu: Refactor flip into prepare submit and submit. (v2)

2017-01-13 Thread Christian König
Am 13.01.2017 um 19:26 schrieb Alex Deucher: From: Andrey Grodzovsky Make pflip atomic friendly. Split the fuinction into whatever can fail part and the actual flip submit part. Call the pre-submit function before atomic states are swapped so in case of error we can

[PATCH] drm/amdgpu: Use signed arithmetic for overdrive clock calculations

2017-01-13 Thread Donny Yang
Signed-off-by: Donny Yang --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 70 +++- 1 file changed, 21 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index

[PATCH 0/2] Report VDDC and MVDD over pp_dpm{sclk,mclk}

2017-01-13 Thread Donny Yang
Tested on a RX480. I'm not sure whether to report VDDCI or MVDD for memory. MVDD felt "more" correct, so that's what I've done. Donny Yang (2): drm/amdgpu: Populate DPMv1 voltage tables drm/amdgpu: Report VDDC and MVDD over pp_dpm{sclk,mclk} drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c

[PATCH 1/2] drm/amdgpu: Populate DPMv1 voltage tables

2017-01-13 Thread Donny Yang
Signed-off-by: Donny Yang --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 46 +--- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index

[PATCH 2/2] drm/amdgpu: Report VDDC and MVDD over pp_dpm{sclk,mclk}

2017-01-13 Thread Donny Yang
Signed-off-by: Donny Yang --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 103e1330..4dd27c28

Re: 答复: [PATCH] drm/amdgpu:put CSA unmap after sched_entity_fini

2017-01-13 Thread Christian König
Ah, in this case please separate the amdgpu_vm_bo_rmv() from setting csa_addr to NULL. Cause amdgpu_vm_bo_rmv() should come before amdgpu_vm_fini() and that in turn should become before waiting for the scheduler so that the MM knows that the memory is about to be freed. Regards, Christian.

[PATCH 5/6] drm/ttm: revert "implement LRU add callbacks v2"

2017-01-13 Thread Christian König
From: Christian König The additional housekeeping had to much CPU overhead, let's use the BO priorities instead. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- drivers/gpu/drm/ast/ast_ttm.c | 2

[PATCH 3/6] drm/amdgpu: user BO priority instead of self coding it

2017-01-13 Thread Christian König
From: Christian König Keeping groups of BOs on the LRU is to time consuming on command submission. Instead use the newly added BO priority to give a certain eviction order. Signed-off-by: Christian König ---

amdgpu: fix performance drop

2017-01-13 Thread Christian König
Hi Roger, as promised the proper fix for the performance drop during command submission. Please test the attached set of patches with your OpenCL test case. Regards, Christian. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

[PATCH 2/6] drm/ttm: add BO priorities for the LRUs

2017-01-13 Thread Christian König
From: Christian König This way the driver can specify a priority for a BO which has the effect that a BO is only evicted when all other BOs with a lower priority are evicted first. Signed-off-by: Christian König ---

[PATCH 6/6] drm/ttm: revert "add optional LRU removal callback v2"

2017-01-13 Thread Christian König
From: Christian König Without the custom LRU management the callback is not used any more. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 12 +--- include/drm/ttm/ttm_bo_driver.h | 6 -- 2 files changed, 5

[PATCH 4/6] drm/amdgpu: double the priority of kernel allocations

2017-01-13 Thread Christian König
From: Christian König Give kernel allocations a higher priority cause it is often more work to swap them back in. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH libdrm] amdgpu: Provide more specific error message if non-privileged user runs amdgpu_test

2017-01-13 Thread Alex Deucher
On Fri, Jan 13, 2017 at 4:20 AM, Christian König wrote: > Am 12.01.2017 um 22:14 schrieb Alex Xie: >> >> Before this change, the error message is: >> "WARNING - Suite initialization failed..." >> People might think this is a driver problem. >> >> Tested with