Re: Plan: BO move throttling for visible VRAM evictions

On 2017年05月14日 05:31, Marek Olšák wrote: On Mon, Apr 17, 2017 at 11:55 AM, Michel Dänzer wrote: On 17/04/17 07:58 AM, Marek Olšák wrote: On Fri, Apr 14, 2017 at 12:14 PM, Michel Dänzer wrote: On 04/04/17 05:11 AM, Marek Olšák wrote: On Fri, Mar 31,

Re: [PATCH 3/3] drm/amdgpu: cleanup adjust_mc_addr handling

On 2017年05月13日 02:57, Felix Kuehling wrote: Hi Christian, One comment inline [FK]. If this is not a problem, then feel free to add my R-B for the whole series. Kent, when we adopt this change, we need to convert the PDE back to an address, because KFD needs to fill just the page directory

Re: [PATCH 3/3] drm/amdgpu: cleanup adjust_mc_addr handling

the series is Reviewed-by: Chunming Zhou On 2017年05月12日 21:48, Christian König wrote: From: Christian König Rename adjust_mc_addr to get_vm_pde, check the address bits in one place and move setting the valid bit in there as well. Signed-off-by:

Re: [PATCH libdrm] amdgpu: add missing extern "C" headers

Hi Michel, This patch was from Nicolai. Though there are two amdgpu.h, one header is in kernel and the other header is in libdrm. But their content are irrelevant. They are not synchronized. I think include/drm/README is not applicable to this case. Thanks, Alex Bin Xie

Re: [PATCH libdrm] amdgpu: add missing extern "C" headers

Hi Michel, It is fine. There is a glitch in my email client. The same email was sent twice, probably because I pressed a special key. I am new to open source review method. Perhaps I did not make thing clear enough. -Alex Bin Xie From: Michel Dänzer

Re: Plan: BO move throttling for visible VRAM evictions

On 14/05/17 06:31 AM, Marek Olšák wrote: > On Mon, Apr 17, 2017 at 11:55 AM, Michel Dänzer wrote: >> On 17/04/17 07:58 AM, Marek Olšák wrote: >>> On Fri, Apr 14, 2017 at 12:14 PM, Michel Dänzer wrote: On 04/04/17 05:11 AM, Marek Olšák wrote: > On

Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

On 13/05/17 12:21 AM, Li, Samuel wrote: > My understanding is this is actually a data file. Similar to amdgpu > firmware, which is also separate from the kernel source code. I don't think the reasons for the linux-firmware repository being separate from linux apply to this file. Please provide

Re: [PATCH libdrm] amdgpu: add missing extern "C" headers

On 15/05/17 11:09 AM, Michel Dänzer wrote: > > BTW, don't send patches for review as HTML. Ideally use git send-email. Sorry Alex, I was confused and thought you sent the patch. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: [PATCH libdrm] amdgpu: add missing extern "C" headers

On 15/05/17 10:10 AM, Xie, AlexBin wrote: > amdgpu/amdgpu.h | 8 > 1 file changed, 8 insertions(+) This header is synchronized with the kernel, see include/drm/README. BTW, don't send patches for review as HTML. Ideally use git send-email. -- Earthling Michel Dänzer |

Re: [PATCH libdrm] amdgpu: add missing extern "C" headers

amdgpu/amdgpu.h | 8 1 file changed, 8 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index fdea905..1901fa8 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -30,20 +30,24 @@ * User wanted to use libdrm_amdgpu functionality must include * this file. * */

Re: [PATCH libdrm] amdgpu: add missing extern "C" headers

amdgpu/amdgpu.h | 8 1 file changed, 8 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index fdea905..1901fa8 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -30,20 +30,24 @@ * User wanted to use libdrm_amdgpu functionality must include * this file. * */

Re: [PATCH libdrm v2 1/1] amdgpu: move asic id table to a separate file

On Sat, May 13, 2017 at 12:50 AM, Li, Samuel wrote: >> If you add this here, you should add the ids file itself and make libdrm >> install it too... > ? Here the ids file is separate from libdrm. It is passed during compilation > so that libdrm knows where to get it. OK