Re: [PATCH 5/5] drm/amdgpu: Don't force BOs into visible VRAM for page faults

On 28/06/17 11:33 AM, John Brooks wrote: > There is no need for page faults to force BOs into visible VRAM if it's > full, and the time it takes to do so is great enough to cause noticeable > stuttering. Add GTT as a possible placement so that if visible VRAM is > full, page faults move BOs to GTT

Re: [PATCH 4/8] ASoC: AMD: added condition checks for CZ specific code

On Fri, Jun 23, 2017 at 12:35:02PM -0400, Alex Deucher wrote: > Reviewed-by: Alex Deucher > index dcbf997..e48ae5d 100644 > --- a/sound/soc/amd/acp-pcm-dma.c > +++ b/sound/soc/amd/acp-pcm-dma.c > @@ -34,6 +34,8 @@ > > #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE *

Re: [PATCH 1/8] drm/amd/amdgpu: Added asic_type as ACP DMA driver platform data

On Fri, Jun 23, 2017 at 01:05:37PM -0400, Alex Deucher wrote: > On Fri, Jun 23, 2017 at 12:43 PM, Christian König > > Have the painkillers jellyfied my brain or are you setting a pointer in the > > amdgpu device structure to some variable on the stack? > > If it's just for initialization then

Re: [PATCH v2] Visible VRAM Management Improvements

On 28/06/17 11:33 AM, John Brooks wrote: > Changes in this version: > - Dropped former patch 1 ("Separate placements and busy placements") as it was > no longer necessary > - Dropped former patch 4 ("Don't force BOs into visible VRAM if they can go to > GTT instead") as it was unnecessary and

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

On 29/06/17 08:26 AM, John Brooks wrote: > On Wed, Jun 28, 2017 at 03:05:32PM +0200, Christian König wrote: >> Am 28.06.2017 um 04:33 schrieb John Brooks: >>> When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, >>> it should only be treated as a hint to initially place a BO

Applied "ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver" to the asoc tree

The patch ASoC: dwc: Added a quirk DW_I2S_QUIRK_16BIT_IDX_OVERRIDE to dwc driver has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the

Re: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

Hi Alex, Quoting "Deucher, Alexander" : -Original Message- From: Gustavo A. R. Silva [mailto:garsi...@embeddedor.com] Sent: Wednesday, June 28, 2017 10:22 AM To: Deucher, Alexander; Koenig, Christian; David Airlie Cc: amd-gfx@lists.freedesktop.org;

Re: [PATCH 3/5] drm/amdgpu: Track time of last page fault and last CS move in struct amdgpu_bo

On Wed, Jun 28, 2017 at 03:06:47PM +0200, Christian König wrote: > Am 28.06.2017 um 04:33 schrieb John Brooks: > >Signed-off-by: John Brooks > >--- > > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +++ > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 + > >

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

On Wed, Jun 28, 2017 at 03:05:32PM +0200, Christian König wrote: > Am 28.06.2017 um 04:33 schrieb John Brooks: > >When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, > >it should only be treated as a hint to initially place a BO somewhere CPU > >accessible, rather than

Re: [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

Op 27-06-17 om 17:01 schreef Daniel Vetter: > On Tue, Jun 27, 2017 at 04:29:44PM +0200, Maarten Lankhorst wrote: >> Op 27-06-17 om 09:37 schreef Daniel Vetter: >>> On Mon, Jun 26, 2017 at 03:44:07PM -0400, Harry Wentland wrote: On 2017-06-20 01:57 PM, Andrey Grodzovsky wrote: > Problem :

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

Am 28.06.2017 um 04:33 schrieb John Brooks: When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by userspace, it should only be treated as a hint to initially place a BO somewhere CPU accessible, rather than having a permanent effect on BO placement. Instead of the flag being set in

Re: [PATCH 3/5] drm/amdgpu: Track time of last page fault and last CS move in struct amdgpu_bo

Am 28.06.2017 um 04:33 schrieb John Brooks: Signed-off-by: John Brooks --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++ 3 files changed, 10 insertions(+)

[gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

Hello everybody, While looking into Coverity ID 1198635 I ran into the following piece of code at drivers/gpu/drm/radeon/vce_v2_0.c:107: 107void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) 108{ 109bool sw_cg = false; 110 111if (enable && (rdev->cg_flags &

RE: [gpu-drm-radeon] question about potential dead code in vce_v2_0_enable_mgcg()

> -Original Message- > From: Gustavo A. R. Silva [mailto:garsi...@embeddedor.com] > Sent: Wednesday, June 28, 2017 10:22 AM > To: Deucher, Alexander; Koenig, Christian; David Airlie > Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux- > ker...@vger.kernel.org >