Re: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v4

2017-07-19 Thread Christian König
Ok, in this case let's commit it. I've fixed the one liner regarding CPU based updates and send it to the list once more. Please give me an rb or even tested-by on that version and then I'm going to commit it. Thanks, Christian. Am 18.07.2017 um 20:56 schrieb Felix Kuehling: If you

Re: [PATCH 2/2] android: amdgpu: fix build break

2017-07-19 Thread Emil Velikov
On 19 July 2017 at 11:18, Chih-Wei Huang wrote: > Define two macros to avoid building errors. > > Fixes: 7e6bf88cac (amdgpu: move asic id table to a separate file) > > Signed-off-by: Chih-Wei Huang > --- > amdgpu/Android.mk | 6 ++ > 1 file

[PATCH 1/2] drm/amdgpu: increase fragmentation size for Vega10 v2

2017-07-19 Thread Christian König
From: Christian König The fragment bits work differently for Vega10 compared to previous generations. Increase the fragment size to 2MB for now to better handle that. v2: handle the hardware setup as well Signed-off-by: Christian König ---

[PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v5

2017-07-19 Thread Christian König
From: Christian König The hardware can use huge pages to map 2MB of address space with only one PDE. v2: few cleanups and rebased v3: skip PT updates if we are using the PDE v4: rebased, added support for CPU based updates v5: fix CPU based updates once more

Re: [PATCH] drm/radeon: Set depth on low mem to 16 bpp instead of 8 bpp

2017-07-19 Thread Takashi Iwai
On Tue, 18 Jul 2017 22:53:48 +0200, Michel D4nzer wrote: > > On 18/07/17 11:20 AM, Takashi Iwai wrote: > > From: Egbert Eich > > > > The radeon driver reduces the framebuffer resolution to 8bpp if a > > device with less than 32MB VRAM is found. This causes the framebuffer > > to

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

2017-07-19 Thread zhoucm1
On 2017年07月19日 04:08, Marek Olšák wrote: From: Marek Olšák For lower overhead in the CS ioctl. Winsys allocators are not used with interprocess-sharable resources. Hi Marek, Could I know from how your this way reduces overhead in CS ioctl? reusing BO to short bo list?

[PATCH v2] drm/amdgpu/gmc8: SRIOV need to program fb location

2017-07-19 Thread Emily Deng
SRIOV won't do vbios post in guest OS, and the mmMC_VM_FB_LOCATION is pf and vf copy, so still need to program fb location for SRIOV. v2: No need to stop mc, and update gmc_v8_0_vram_gtt_location as well. BUG: SWDEV-126629 Signed-off-by: Emily Deng ---

RE: [PATCH v2] drm/amdgpu/gmc8: SRIOV need to program fb location

2017-07-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Emily Deng > Sent: Tuesday, July 18, 2017 11:44 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH v2] drm/amdgpu/gmc8: SRIOV need to program fb location > > SRIOV

Re: [PATCH 2/2] drm/amdgpu: Clear active for HIQ in RLC_CP_SCHEDULER

2017-07-19 Thread StDenis, Tom
You could use WREG32_FIELD15 to drop 3 lines into one. Tom From: amd-gfx on behalf of Shaoyun Liu Sent: Wednesday, July 19, 2017 16:26 To: amd-gfx@lists.freedesktop.org Cc: Liu, Shaoyun

[PATCH 2/2] drm/amdgpu: Clear active for HIQ in RLC_CP_SCHEDULER

2017-07-19 Thread Shaoyun Liu
Change-Id: I780e276983ba5a3bf077d274c84eb168585c806a Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 11 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 12 2 files changed, 23 insertions(+) diff --git

[PATCH 1/2] drm/amd: Add mqd as parameter in kfd2kgd.hqd_destroy interface

2017-07-19 Thread Shaoyun Liu
Change-Id: I11522965287622bf577fca2aa5dee2aaf791a77f Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 4 ++--

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

2017-07-19 Thread Marek Olšák
On Jul 19, 2017 3:36 AM, "zhoucm1" wrote: On 2017年07月19日 04:08, Marek Olšák wrote: > From: Marek Olšák > > For lower overhead in the CS ioctl. > Winsys allocators are not used with interprocess-sharable resources. > Hi Marek, Could I know from how

Re: [PATCH] drm/amdgpu: Optimize mutex usage (v3)

2017-07-19 Thread Dave Airlie
On 16 June 2017 at 23:08, Alex Xie wrote: > In original function amdgpu_bo_list_get, the waiting > for result->lock can be quite long while mutex > bo_list_lock was holding. It can make other tasks > waiting for bo_list_lock for long period. > > Secondly, this patch allows

Re: [PATCH libdrm] amdgpu: move asic id table to a separate file

2017-07-19 Thread Chih-Wei Huang
Sorry for reply late. 2017-07-05 19:05 GMT+08:00 Emil Velikov : > On 5 July 2017 at 11:44, Chih-Wei Huang wrote: >> >> Yep. The first problem to prepare the patch is, >> where to install amdgpu.ids on Android? >> Is /system/etc/amdgpu.ids OK? >>

[PATCH 2/2] android: amdgpu: fix build break

2017-07-19 Thread Chih-Wei Huang
Define two macros to avoid building errors. Fixes: 7e6bf88cac (amdgpu: move asic id table to a separate file) Signed-off-by: Chih-Wei Huang --- amdgpu/Android.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/amdgpu/Android.mk b/amdgpu/Android.mk index

[PATCH 1/2] android: add rules to build amdgpu.ids

2017-07-19 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- data/Android.mk | 9 + 1 file changed, 9 insertions(+) create mode 100644 data/Android.mk diff --git a/data/Android.mk b/data/Android.mk new file mode 100644 index 000..3c1fd7c --- /dev/null +++ b/data/Android.mk @@ -0,0 +1,9

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

2017-07-19 Thread Michel Dänzer
On 18/07/17 09:55 PM, zhoucm1 wrote: On 2017年07月18日 21:57, Christian König wrote: Am 18.07.2017 um 04:29 schrieb zhoucm1: On 2017年07月18日 01:35, Christian König wrote: Am 17.07.2017 um 19:22 schrieb Marek Olšák: On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: I can

[PATCH] drm/amd/powerplay: add support for 3DP 4K@120Hz on vega10.

2017-07-19 Thread Rex Zhu
Change-Id: Ic884366431afde180f9926963871a8daddc4588e Signed-off-by: Rex Zhu --- .../amd/powerplay/hwmgr/vega10_processpptables.c | 39 -- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] drm/amd: Add mqd as parameter in kfd2kgd.hqd_destroy interface

2017-07-19 Thread Shaoyun Liu
Change-Id: I11522965287622bf577fca2aa5dee2aaf791a77f Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 4 ++--

[PATCH 2/2] drm/amdgpu: Clear active for HIQ in RLC_CP_SCHEDULER

2017-07-19 Thread Shaoyun Liu
Change-Id: I780e276983ba5a3bf077d274c84eb168585c806a Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 5 + 2 files changed, 9 insertions(+) diff --git

Re: [PATCH 2/2] drm/amdgpu: Clear active for HIQ in RLC_CP_SCHEDULER

2017-07-19 Thread Felix Kuehling
The series is Reviewed-by: Felix Kuehling On 17-07-19 05:16 PM, Shaoyun Liu wrote: > Change-Id: I780e276983ba5a3bf077d274c84eb168585c806a > Signed-off-by: Shaoyun Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 4 >

Re: [PATCH 2/2] drm/amdgpu: enable huge page handling in the VM v5

2017-07-19 Thread Felix Kuehling
Two nit-picks inline. Otherwise this series is Reviewed-and-tested-by: Felix Kuehling That said, I was not able to measure any performance improvement on Vega10 using mixbench yet. I checked that the same test is sensitive to TLB optimizations on Fiji. So probably we're

Re: [PATCH] drm/amdgpu: Optimize mutex usage (v3)

2017-07-19 Thread axie
Hi Dave, Is it easy to reproduce this backtrace? If it is easy, would you give this patch a try? From 3c83e1f05352f4795ddc2a8c9acca65b4b58ded9 Mon Sep 17 00:00:00 2001 From: Alex Xie Date: Wed, 19 Jul 2017 21:51:56 -0400 Subject: [PATCH] drm/amdgpu: Fix a warning on

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

2017-07-19 Thread zhoucm1
On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" > wrote: On 2017年07月19日 04:08, Marek Olšák wrote: From: Marek Olšák > For lower

[PATCH v3] drm/amdgpu/gmc8: SRIOV need to program fb location

2017-07-19 Thread Emily Deng
SRIOV won't do vbios post in guest OS, and the mmMC_VM_FB_LOCATION is pf and vf copy, so still need to program fb location for SRIOV. v2: No need to stop mc, and update gmc_v8_0_vram_gtt_location as well. v3: New line after the stack variables BUG: SWDEV-126629 Signed-off-by: Emily Deng

[PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9

2017-07-19 Thread Huang Rui
There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7). Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c

Re: [PATCH] drm/amdgpu: Fix error RCU usage

2017-07-19 Thread zhoucm1
On 2017年07月20日 10:27, Alex Xie wrote: In RCU read-side critical sections, blocking or sleeping is prohibited. Reported by: Dave Airlie [ 141.965723] = [ 141.965724] WARNING: suspicious RCU usage [ 141.965726] 4.12.0-rc7 #221 Not tainted [ 141.965727]

[PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

2017-07-19 Thread Alex Xie
In RCU read-side critical sections, blocking or sleeping is prohibited. v2: Unlock RCU for the code path where result==NULL. (David Zhou) Update subject Tested-by and reported by: Dave Airlie [ 141.965723] = [ 141.965724] WARNING:

RE: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9

2017-07-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Huang Rui > Sent: Wednesday, July 19, 2017 10:21 PM > To: amd-gfx@lists.freedesktop.org > Cc: Huang, Ray > Subject: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9 > >

Re: [PATCH] drm/amdgpu: Fix blocking in RCU critical section(v2)

2017-07-19 Thread zhoucm1
one small nit pick, with that fix, Reviewed-by: Chunming Zhou On 2017年07月20日 10:46, Alex Xie wrote: In RCU read-side critical sections, blocking or sleeping is prohibited. v2: Unlock RCU for the code path where result==NULL. (David Zhou) Update subject Tested-by

Re: [PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9

2017-07-19 Thread Zhang, Jerry (Junwei)
On 07/20/2017 10:21 AM, Huang Rui wrote: There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7). Yeah, nice catch. Reviewed-by: Junwei Zhang Additionally it looks incorrect from gfx v6 till gfx9. Could you fix them all? Jerry Signed-off-by: Huang Rui

[PATCH] drm/amdgpu: rename gfxhub_v1_0 to gchub_v9_0

2017-07-19 Thread Hawking Zhang
Change-Id: I32d98b77b8da6b180dd365ff7f99c08e8aa061b1 Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +-

Re: [PATCH] drm/amdgpu: Fix error RCU usage

2017-07-19 Thread axie
I am working on v2 while you are point out this. Thanks. On 2017-07-19 10:33 PM, zhoucm1 wrote: On 2017年07月20日 10:27, Alex Xie wrote: In RCU read-side critical sections, blocking or sleeping is prohibited. Reported by: Dave Airlie [ 141.965723] = [

RE: [PATCH v3] drm/amdgpu/gmc8: SRIOV need to program fb location

2017-07-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Emily Deng > Sent: Wednesday, July 19, 2017 10:21 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH v3] drm/amdgpu/gmc8: SRIOV need to program fb location > > SRIOV

RE: [PATCH] drm/amdgpu: Fix error RCU usage

2017-07-19 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Xie > Sent: Wednesday, July 19, 2017 10:28 PM > To: amd-gfx@lists.freedesktop.org > Cc: Xie, AlexBin > Subject: [PATCH] drm/amdgpu: Fix error RCU usage > > In RCU read-side critical

RE: [PATCH 3/3] drm/amdgpu: Clear active for HIQ in RLC_CP_SCHEDULERS

2017-07-19 Thread Liu, Shaoyun
I'd like to avoid add KFD related stuff into the adev structure and keep the similar interface as hdp_load. If nobody mind of one patch that across different code directories I can squash them into one patch. Regards Shaoyun.liu -Original Message- From: amd-gfx

RE: [PATCH] drm/amdgpu: rename gfxhub_v1_0 to gchub_v9_0

2017-07-19 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Hawking Zhang Sent: Thursday, July 20, 2017 11:27 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH]