Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Alex Deucher
On Tue, Feb 27, 2018 at 11:22 AM, Eric Huang wrote: > As I mentioned in code review for new power profile, old gfx/compute power > profile have two scenarios for auto switching. One is > gfx->compute(default)->gfx and other is gfx->compute(custom)->gfx. New power >

Re: [PATCH 04/33] drm/amd/display: Use 4096 lut entries

2018-02-27 Thread Leo Li
On 2018-02-27 05:34 AM, Michel Dänzer wrote: On 2018-02-26 09:15 PM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" Non-legacy LUT size should reflect hw capability. Change size from 256 to 4096. However, X doesn't seem to play with legacy LUTs of such size. Therefore,

Re: [PATCH 04/33] drm/amd/display: Use 4096 lut entries

2018-02-27 Thread Harry Wentland
On 2018-02-27 11:08 AM, Michel Dänzer wrote: > On 2018-02-27 04:54 PM, Leo Li wrote: >> On 2018-02-27 05:34 AM, Michel Dänzer wrote: >>> On 2018-02-26 09:15 PM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" Non-legacy LUT size should reflect hw capability.

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Eric Huang
Yes. That is a solution. Eric On 2018-02-27 11:27 AM, Alex Deucher wrote: On Tue, Feb 27, 2018 at 11:22 AM, Eric Huang wrote: As I mentioned in code review for new power profile, old gfx/compute power profile have two scenarios for auto switching. One is

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Alex Deucher
+ Kent and Felix for comment On Tue, Feb 27, 2018 at 6:21 AM, Rex Zhu wrote: > The gfx/compute profiling mode switch is only for internally > test. Not a complete solution and unexpectly upstream. > so revert it. > > Change-Id: I1af1b64a63b6fc12c24cf73df03b083b3661ca02 >

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Eric Huang
As I mentioned in code review for new power profile, old gfx/compute power profile have two scenarios for auto switching. One is gfx->compute(default)->gfx and other is gfx->compute(custom)->gfx. New power profile only satisfies first one, but in second one for user debugging, user setting of

[PATCH] drm/amdgpu: fix module parameter descriptions

2018-02-27 Thread Alex Deucher
Some were missing the close parens around options. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

Re: [PATCH] drm/amdgpu: Map all visible VRAM at startup

2018-02-27 Thread Christian König
Am 27.02.2018 um 16:22 schrieb Amber Lin: When using CPU to update page table, we need to kmap all the PDs/PTs after they are allocated and that requires a TLB shot down on each CPU, which is quite heavy. Instead, we map the whole visible VRAM to a kernel address at once. Pages can be obtained

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Felix Kuehling
[+Eric] Compute profile switching code as well as KFD compute support for most GPUs is not upstream yet. As such, there is probably no requirement (yet) to keep the compute profile API stable, that we added specifically for KFD. Once we are upstream that will change. If you change it now, we'll

Re: [PATCH 04/33] drm/amd/display: Use 4096 lut entries

2018-02-27 Thread Michel Dänzer
On 2018-02-27 05:16 PM, Harry Wentland wrote: > On 2018-02-27 11:08 AM, Michel Dänzer wrote: >> On 2018-02-27 04:54 PM, Leo Li wrote: >>> On 2018-02-27 05:34 AM, Michel Dänzer wrote: On 2018-02-26 09:15 PM, Harry Wentland wrote: > From: "Leo (Sunpeng) Li" > >

[PATCH v2] drm/amdgpu: Map all visible VRAM at startup

2018-02-27 Thread Amber Lin
When using CPU to update page table, we need to kmap all the PDs/PTs after they are allocated and that requires a TLB shot down on each CPU, which is quite heavy. Instead, we map the whole visible VRAM to a kernel address at once. Pages can be obtained from the offset. v2: move the mapping base

RE: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Russell, Kent
To answer this question, we haven't tested anything intentionally on the farm. We don't really have a test to test profiles aside from ensuring that sysfs returns what we set, and even then that's not part of automation. Kent -Original Message- From: Kuehling, Felix Sent: Tuesday,

Re: [PATCH 2/7] drm/amd/dc: Use forward declaration instand of include header file

2018-02-27 Thread Harry Wentland
On 2018-02-27 06:27 AM, Rex Zhu wrote: > avoid build error: > > drivers/gpu/drm/amd/amdgpu/../powerplay/inc/smu9_driver_if.h:342:3: error: > redeclaration of enumerator ‘WM_COUNT’ >WM_COUNT, >^ > In file included from > drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:32:0,

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Felix Kuehling
On 2018-02-27 11:27 AM, Alex Deucher wrote: > On Tue, Feb 27, 2018 at 11:22 AM, Eric Huang wrote: >> As I mentioned in code review for new power profile, old gfx/compute power >> profile have two scenarios for auto switching. One is >> gfx->compute(default)->gfx and

Re: [PATCH 4/7] drm/amdgpu: Notify sbios device ready before send request

2018-02-27 Thread Alex Deucher
On Tue, Feb 27, 2018 at 6:27 AM, Rex Zhu wrote: > Change-Id: Id7f674c7faba8d51864353a3a7ea96ba471a60d8 > Signed-off-by: Rex Zhu Please include a description of why this is needed as we discussed offline in the patch description. With that fixed: Reviewed-by:

Re: [PATCH 0/7] Begin to remove cgs interface

2018-02-27 Thread Alex Deucher
On Tue, Feb 27, 2018 at 6:27 AM, Rex Zhu wrote: > > > Rex Zhu (7): > drm/amd/pp: Simply powerplay create code > drm/amd/dc: Use forward declaration instand of include header file > drm/amd/pp: Refine powerplay instance > drm/amdgpu: Notify sbios device ready before send

[PATCH] drm/amd/powerplay: fix power over limit on Fiji

2018-02-27 Thread Eric Huang
power containment disabled only on Fiji and compute power profile. It violates PCIe spec and may cause power supply failed. Enabling it will fix the issue, even the fix will drop performance of some compute tests. Signed-off-by: Eric Huang ---

Re: [PATCH] drm/amd/powerplay: fix power over limit on Fiji

2018-02-27 Thread Felix Kuehling
Reviewed-by: Felix Kuehling On 2018-02-27 03:57 PM, Eric Huang wrote: > power containment disabled only on Fiji and compute > power profile. It violates PCIe spec and may cause power > supply failed. Enabling it will fix the issue, even the > fix will drop performance of

[PATCH 0/6] *** some fixings ***

2018-02-27 Thread Monk Liu
*** some bug fixings for SRIOV case *** Emily Deng (1): drm/amdgpu: Correct sdma_v4 get_wptr(v2) Monk Liu (5): drm/amdgpu: don't use MM idle_work for SRIOV(v2) drm/amdgpu: block till late_init_work done in dev_fini drm/amdgpu: should call drm_helper with dc support drm/amdgpu: adjust

RE: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

2018-02-27 Thread Liu, Monk
I'm not familiar with DC stuffs, I found without this patch DRM always reporting error like this: [ 89.783235] [drm] Found UVD firmware Version: 1.87 Family ID: 17 [ 89.783285] [drm] PSP loading UVD firmware [ 89.784657] [drm] MM table gpu addr = 0xcfc000, cpu addr = 5ec858a9. [

Re: [PATCH 1/6] drm/amdgpu: don't use MM idle_work for SRIOV(v2)

2018-02-27 Thread Christian König
Am 27.02.2018 um 09:47 schrieb Monk Liu: SRIOV doesn't give VF cg/pg feature so the MM's idle_work is skipped for SR-IOV v2: remove superfluous changes since idle_work is not scheduled for SR-IOV so the condition check for SR-IOV inside idle_work also can be dropped Change-Id:

Re: [PATCH 4/6] drm/amdgpu: adjust timeout for ib_ring_tests(v2)

2018-02-27 Thread Christian König
Am 27.02.2018 um 09:47 schrieb Monk Liu: issue: sometime GFX/MM ib test hit timeout under SRIOV env, root cause is that engine doesn't come back soon enough so the current IB test considered as timed out. fix: for SRIOV GFX IB test wait time need to be expanded a lot during SRIOV runtimei mode

Re: [PATCH 09/22] drm/amdgpu: fix kmd reload bug on bare-metal

2018-02-27 Thread Christian König
Am 27.02.2018 um 11:19 schrieb Liu, Monk: So returning true only means the work is on TODO list, but the work will *never* get executed after this cancel_delayed_work_sync() returned right ? Correct yes. Christian. -Original Message- From: Koenig, Christian Sent: 2018年2月27日 17:53

Re: [PATCH 10/22] drm/amdgpu: no need to count emitted for SRIOV

2018-02-27 Thread Christian König
Am 27.02.2018 um 06:26 schrieb Liu, Monk: I would rather avoid calling the function in the first place. I already did it in patch 08, and you also rejected this patch So I'll consider patch 08 is still valid, and drop this one Well a good part of patch 08 is still valid. I just rejected that

RE: [PATCH 09/22] drm/amdgpu: fix kmd reload bug on bare-metal

2018-02-27 Thread Liu, Monk
> Never use schedule() in a while loop as long as you don't work on core > locking primitives or interrupt handling or stuff like that. In this > particular case a single call to cancel_delayed_work_sync() should be > sufficient. I thought that only one call on cancel_delayed_work_sync()

RE: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

2018-02-27 Thread Liu, Monk
Okay, I think maybe the problem is sr-iov related, I'll prepare another one -Original Message- From: Liu, Monk Sent: 2018年2月27日 17:27 To: 'Michel Dänzer' Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

Re: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

2018-02-27 Thread Michel Dänzer
On 2018-02-27 10:26 AM, Liu, Monk wrote: > I'm not familiar with DC stuffs, I found without this patch DRM always > reporting error like this: [...] > [ 89.936514] [drm:drm_helper_disable_unused_functions [drm_kms_helper]] > *ERROR* Called for atomic driver, this is not what you want.

Re: [PATCH 09/22] drm/amdgpu: fix kmd reload bug on bare-metal

2018-02-27 Thread Christian König
Is my understanding wrong ?... The first thing that cancel_delayed_work_sync() does is it takes the work item from the TODO list. The it makes sure that the work is currently not running on another CPU. The return value just indicates if the work was still on the TODO list or not, e.g. when

RE: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

2018-02-27 Thread Liu, Monk
The cause is found: In amdgpu_pci_probe(), we set support_atomic to true no matter sriov or BM, because "adev" is not created yet so cannot judge SRIOV or not that time ... But in amdgpu_fbdev_init(), we check if need to call that disable_unused_function() by amdgpu_device_has_dc_support() which

Re: [PATCH 6/6] drm/amdgpu: cleanup SA inti and fini(v2)

2018-02-27 Thread Christian König
Am 27.02.2018 um 09:47 schrieb Monk Liu: should use bo_create_kernel instead of split to two function that create and pin the SA bo issue: before this patch, there are DMAR read error in host side when running SRIOV test, the DMAR address dropped in the range of SA bo. fix: after this cleanups

Re: [PATCH 09/22] drm/amdgpu: fix kmd reload bug on bare-metal

2018-02-27 Thread Christian König
Am 27.02.2018 um 05:45 schrieb Liu, Monk: In this case I think it would be much better to wait for the idle work before trying to unload the driver. I already did it: + if (!amdgpu_sriov_vf(adev)) + while (cancel_delayed_work_sync(>late_init_work)) +

[PATCH 5/6] drm/amdgpu: Correct sdma_v4 get_wptr(v2)

2018-02-27 Thread Monk Liu
From: Emily Deng the original method will change the wptr value in wb. v2: furthur cleanup Change-Id: I984fabca35d9dcf1f5fa8ef7779b2afb7f7d7370 Signed-off-by: Emily Deng Signed-off-by: Monk Liu ---

[PATCH 6/6] drm/amdgpu: cleanup SA inti and fini(v2)

2018-02-27 Thread Monk Liu
should use bo_create_kernel instead of split to two function that create and pin the SA bo issue: before this patch, there are DMAR read error in host side when running SRIOV test, the DMAR address dropped in the range of SA bo. fix: after this cleanups of SA init and fini, above DMAR eror gone.

[PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

2018-02-27 Thread Monk Liu
otherwise DRM keep reporting complain on ATOMIC flags during kmd reloading Change-Id: I835b96e6d61c7995bbd5dd5478d056671dde9192 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/6] drm/amdgpu: adjust timeout for ib_ring_tests(v2)

2018-02-27 Thread Monk Liu
issue: sometime GFX/MM ib test hit timeout under SRIOV env, root cause is that engine doesn't come back soon enough so the current IB test considered as timed out. fix: for SRIOV GFX IB test wait time need to be expanded a lot during SRIOV runtimei mode since it couldn't really begin before GFX

RE: [PATCH 22/22] drm/amdgpu: fix reservation obj shared count bug

2018-02-27 Thread Liu, Monk
I know in theoretically this issue should be equal for sriov or not But since the gpu performance under SRIOV is only one quarter compared with bare-metal (assume 4VF) And the CPU's performance is also limited, so there are chance that the fence is signaled not as quick as bare-metal And lead to

Re: [PATCH 3/6] drm/amdgpu: should call drm_helper with dc support

2018-02-27 Thread Michel Dänzer
On 2018-02-27 09:47 AM, Monk Liu wrote: > otherwise DRM keep reporting complain on ATOMIC flags > during kmd reloading > > Change-Id: I835b96e6d61c7995bbd5dd5478d056671dde9192 > Signed-off-by: Monk Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- > 1 file changed, 1

RE: [PATCH 09/22] drm/amdgpu: fix kmd reload bug on bare-metal

2018-02-27 Thread Liu, Monk
So returning true only means the work is on TODO list, but the work will *never* get executed after this cancel_delayed_work_sync() returned right ? -Original Message- From: Koenig, Christian Sent: 2018年2月27日 17:53 To: Liu, Monk ; amd-gfx@lists.freedesktop.org Subject:

Re: [PATCH 5/6] drm/amdgpu: Correct sdma_v4 get_wptr(v2)

2018-02-27 Thread Christian König
Am 27.02.2018 um 09:47 schrieb Monk Liu: From: Emily Deng the original method will change the wptr value in wb. v2: furthur cleanup Change-Id: I984fabca35d9dcf1f5fa8ef7779b2afb7f7d7370 Signed-off-by: Emily Deng Signed-off-by: Monk Liu

[PATCH 1/6] drm/amdgpu: don't use MM idle_work for SRIOV(v2)

2018-02-27 Thread Monk Liu
SRIOV doesn't give VF cg/pg feature so the MM's idle_work is skipped for SR-IOV v2: remove superfluous changes since idle_work is not scheduled for SR-IOV so the condition check for SR-IOV inside idle_work also can be dropped Change-Id: I6dd7ea48d23b0fee74ecb9e93b53bfe36b0e8164 Signed-off-by:

Re: [PATCH 04/33] drm/amd/display: Use 4096 lut entries

2018-02-27 Thread Michel Dänzer
On 2018-02-26 09:15 PM, Harry Wentland wrote: > From: "Leo (Sunpeng) Li" > > Non-legacy LUT size should reflect hw capability. Change size from 256 > to 4096. > > However, X doesn't seem to play with legacy LUTs of such size. > Therefore, check for legacy lut when updating

[PATCH 0/7] Begin to remove cgs interface

2018-02-27 Thread Rex Zhu
Rex Zhu (7): drm/amd/pp: Simply powerplay create code drm/amd/dc: Use forward declaration instand of include header file drm/amd/pp: Refine powerplay instance drm/amdgpu: Notify sbios device ready before send request drm/amd/pp: Use amdgpu acpi helper functions in powerplay

[PATCH 2/5] drm/prime: make the pages array optional for drm_prime_sg_to_page_addr_arrays

2018-02-27 Thread Christian König
Most of the time we only need the dma addresses. Signed-off-by: Christian König --- drivers/gpu/drm/drm_prime.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index

[PATCH 4/5] drm/ttm: add ttm_sg_tt_init

2018-02-27 Thread Christian König
This allows drivers to only allocate dma addresses, but not a page array. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 54 include/drm/ttm/ttm_tt.h | 2 ++ 2 files changed, 47 insertions(+), 9

Re: [PATCH 4/5] drm/ttm: add ttm_sg_tt_init

2018-02-27 Thread Christian König
Hi guys, at least on amdgpu and radeon the page array allocated by ttm_dma_tt_init is completely unused in the case of DMA-buf sharing. So I'm trying to get rid of that by only allocating the DMA address array. Now the only other user of DMA-buf together with ttm_dma_tt_init is Nouveau. So

[PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Rex Zhu
The gfx/compute profiling mode switch is only for internally test. Not a complete solution and unexpectly upstream. so revert it. Change-Id: I1af1b64a63b6fc12c24cf73df03b083b3661ca02 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h| 8 -

[PATCH 6/7] drm/amd/pp: Remove the wrap functions for acpi in powerplay

2018-02-27 Thread Rex Zhu
Change-Id: I982a5d4dd82273465f28fc9009c3ed2461329ca8 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 212 -- drivers/gpu/drm/amd/include/cgs_common.h | 44 -- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 2 +-

[PATCH 5/7] drm/amd/pp: Use amdgpu acpi helper functions in powerplay

2018-02-27 Thread Rex Zhu
Change-Id: Ided33c27ff6d1f1f62d41428039b133e96de1dbd Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c| 4 +--- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 7 +++ drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 1 - 3 files changed,

Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

2018-02-27 Thread Christian König
Am 27.02.2018 um 12:21 schrieb Rex Zhu: The gfx/compute profiling mode switch is only for internally test. Not a complete solution and unexpectly upstream. so revert it. Change-Id: I1af1b64a63b6fc12c24cf73df03b083b3661ca02 Signed-off-by: Rex Zhu Patch is Acked-by: Christian

[PATCH 2/7] drm/amd/dc: Use forward declaration instand of include header file

2018-02-27 Thread Rex Zhu
avoid build error: drivers/gpu/drm/amd/amdgpu/../powerplay/inc/smu9_driver_if.h:342:3: error: redeclaration of enumerator ‘WM_COUNT’ WM_COUNT, ^ In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:32:0, from

[PATCH 1/7] drm/amd/pp: Simply powerplay create code

2018-02-27 Thread Rex Zhu
use adev as input parameter to create powerplay handle directly. remove cgs support of powerplay create. Signed-off-by: Rex Zhu Change-Id: Ie3b91e8f67b8e8307ec678df7e8b6d6a6e0c52ae --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 22 -

[PATCH 3/7] drm/amd/pp: Refine powerplay instance

2018-02-27 Thread Rex Zhu
Include adev in powerplay instance directly. so we can remove cgs interface. Change-Id: Ia2f0a82dc176b616e727d1879f592391442859ee Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 6 ++ drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 7 ---

[PATCH 4/7] drm/amdgpu: Notify sbios device ready before send request

2018-02-27 Thread Rex Zhu
Change-Id: Id7f674c7faba8d51864353a3a7ea96ba471a60d8 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c index

[PATCH 7/7] drm/amd/pp: Remove cgs_query_system_info

2018-02-27 Thread Rex Zhu
Get gpu info through adev directly in powerplay Change-Id: I9cefcc4ecc46124e9136830d1d30ad8f337f941a Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 59 -- drivers/gpu/drm/amd/include/cgs_common.h | 34 -

[PATCH 3/5] drm/ttm: move ttm_tt defines into ttm_tt.h

2018-02-27 Thread Christian König
Let's stop mangling everything in a single header and create one header per object instead. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c| 6 - include/drm/ttm/ttm_bo_driver.h | 237 +- include/drm/ttm/ttm_tt.h

[PATCH 5/5] drm/amdgpu: stop allocating a page array for prime shared BOs

2018-02-27 Thread Christian König
We don't need the page array for prime shared BOs, stop allocating it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-02-27 Thread Christian König
Unpin the GEM object only after freeing the sg table. Signed-off-by: Christian König --- drivers/gpu/drm/drm_prime.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c

Re: [PATCH 17/22] drm/amdgpu: disable GFX ring and disable PQ wptr in hw_fini

2018-02-27 Thread Deucher, Alexander
Please add a comment above the CP_PQ_WPTR_POLL_CNTL write to explain that it's to disable the polling. WIth that fixed: Acked-by: Alex Deucher From: amd-gfx on behalf of Liu, Monk

[PATCH] drm/amdgpu:Fixed wrong emit frame size for enc

2018-02-27 Thread James Zhu
Emit frame size should match with corresponding function, uvd_v6_0_enc_ring_emit_vm_flush has 5 amdgpu_ring_write Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu:Fixed wrong emit frame size for enc

2018-02-27 Thread Christian König
You are using outdated code, that has already be fixed on amd-staging-drm-next. Christian. Am 27.02.2018 um 16:06 schrieb James Zhu: Emit frame size should match with corresponding function, uvd_v6_0_enc_ring_emit_vm_flush has 5 amdgpu_ring_write Signed-off-by: James Zhu

[PATCH 1/4] drm/amdgpu: stop all rings before doing gpu recover

2018-02-27 Thread Monk Liu
found recover_vram_from_shadow sometimes get executed in paralle with SDMA scheduler, should stop all schedulers before doing gpu reset/recover Change-Id: Ibaef3e3c015f3cf88f84b2eaf95cda95ae1a64e3 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 40

[PATCH 2/4] drm/amdgpu: cleanups for vram lost handling

2018-02-27 Thread Monk Liu
1)create a routine "handle_vram_lost" to do the vram recovery, and put it into amdgpu_device_reset/reset_sriov, this way no need of the extra paramter to hold the VRAM LOST information and the related macros can be removed. 3)show vram_recover failure if time out, and set TMO equal to

[PATCH 3/4] drm/amdgpu: don't return when ring not ready for fill_buffer

2018-02-27 Thread Monk Liu
because this time SDMA may under GPU RESET so its ring->ready may not true, keep going and GPU scheduler will reschedule this job if it failed. give a warning on copy_buffer when go through direct_submit while ring->ready is false Change-Id: Ife6cd55e0e843d99900e5bed5418499e88633685

[PATCH 4/4] drm/amdgpu: try again kiq access if not in IRQ

2018-02-27 Thread Monk Liu
sometimes GPU is switched to other VFs and won't swich back soon, so the kiq reg access will not signal within a short period, instead of returning TMO error we in fact should sleep 1ms and try again later (when not in interrupt context). And since there is retry scheme provided so the

[PATCH] drm/amdgpu: try again kiq access if not in IRQ(v2)

2018-02-27 Thread Monk Liu
sometimes GPU is switched to other VFs and won't swich back soon, so the kiq reg access will not signal within a short period, instead of busy waiting a long time(MAX_KEQ_REG_WAIT) and returning TMO we can istead sleep 5ms and try again later (non irq context) And since the waiting in kiq_r/weg

RE: [PATCH 4/4] drm/amdgpu: try again kiq access if not in IRQ

2018-02-27 Thread Liu, Monk
Drop it, will send V2 patch -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: 2018年2月28日 15:21 To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH 4/4] drm/amdgpu: try again kiq access if not in IRQ

Re: [PATCH] drm/amdgpu: fix module parameter descriptions

2018-02-27 Thread Christian König
Am 27.02.2018 um 17:45 schrieb Alex Deucher: Some were missing the close parens around options. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1 file changed, 2

Re: [PATCH v2] drm/amdgpu: Map all visible VRAM at startup

2018-02-27 Thread Christian König
Am 27.02.2018 um 19:36 schrieb Amber Lin: When using CPU to update page table, we need to kmap all the PDs/PTs after they are allocated and that requires a TLB shot down on each CPU, which is quite heavy. Instead, we map the whole visible VRAM to a kernel address at once. Pages can be obtained

Problems with graphics

2018-02-27 Thread Anton Kashcheev
Good day, I have problems with graphics -- from time to time kernel show errors. Kernel 4.14.20 Log attached. Sincerely, Anton Kashcheev. [0.00] Linux version 4.14.20_1 (void-buildslave@build) (gcc version 7.3.0 (GCC)) #1 SMP PREEMPT Thu Feb 22 14:45:56 UTC 2018 [0.00] Command

Re: [PATCH 4/4] drm/amd/pp: Disable power containment on Fiji with compute workload

2018-02-27 Thread Zhu, Rex
Drop this patch. As Eric point out that power containment disabled only on Fiji and compute power profile. It violates PCIe spec and may cause power supply failed. Enabling it will fix the issue, even the fix will drop performance of some compute tests. Best Regards Rex

Re: [PATCH] drm/amd/powerplay: fix power over limit on Fiji

2018-02-27 Thread Zhu, Rex
Good. I will follow in new power profile implementation. Best Regards Rex From: amd-gfx on behalf of Felix Kuehling Sent: Wednesday, February 28, 2018 5:01 AM To: amd-gfx@lists.freedesktop.org