Re: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Quan, Evan Sent: Wednesday, March 14, 2018 11:20 AM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher,

[amd-staging-drm-next] - commit 'Set disp clk in a safe way to avoid over high dpp clk.' makes 'CONFIG_DRM_AMD_DC_DCN1_0=y' mandatory, again

Hello, commit # 680acc64120cd7fe4fb21d816a0fc0854018fe59 drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk. makes CONFIG_DRM_AMD_DC_DCN1_0=y mandatory, again. I think it was not intentional? Without it I get: Kernel: arch/x86/boot/bzImage is ready (#1) ERROR:

[PATCH] drm/amd/pp: Fix memory leak in error path in smumgr

Free the backend structure if we fail to allocate device memory. Change-Id: Ib5fbd507369575b90df57a55d3e7318c769b3e27 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 35 +- drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c |

RE: [PATCH] drm/amd/pp: Fix memory leak in error path in smumgr

Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Wednesday, March 14, 2018 4:17 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amd/pp: Fix memory

Re: [amd-staging-drm-next] - commit 'Set disp clk in a safe way to avoid over high dpp clk.' makes 'CONFIG_DRM_AMD_DC_DCN1_0=y' mandatory, again

On Wed, Mar 14, 2018 at 2:15 AM, Dieter Nützel wrote: > Hello, > > commit # 680acc64120cd7fe4fb21d816a0fc0854018fe59 > drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk. > > makes CONFIG_DRM_AMD_DC_DCN1_0=y mandatory, again. > I think it was not

Re: [PATCH 1/3] drm/amdgpu: remove trailing whitespace from soc15ip.h

Am 14.03.2018 um 02:22 schrieb Alex Deucher: no intended functional change. Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/include/vega10_ip_offset.h | 286 - 1 file changed,

How to enable Radeon Pro Duo with mesa

Hi All , Does mesa support Radeon Pro Duo? I don't know how to configure xorg.conf to use two WX7100 card of DUO , and now I can only use the first card of DUO. Installed software packages: xserver-xorg xfce4 xinit Mesa version: 17.2.8 kernel version: 4.15 Pci information: 000d:31:00.0 PCI

[PATCH v2] drm/amd/pp: Fix memory leak in error path in smumgr

v2: not change the sequence of smu backend assignment Free the backend structure if we fail to allocate device memory. Change-Id: Ib2007d83f3d99dcc6c4a0c9fe9a9f144bb7469e9 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 32 ++

[bug report] drm/amd/display: Handle HDR use cases.

Hello Vitaly Prosyak, The patch 44c6f2e59ee8: "drm/amd/display: Handle HDR use cases." from Feb 13, 2018, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:543 cm_helper_translate_curve_to_degamma_hw_format() warn:

Re: [PATCH][next] drm/amd/pp: remove redundant pointer internal_buf

Apply it and thanks. Best Regards Rex From: Colin King Sent: Tuesday, March 13, 2018 9:22 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; amd-gfx@lists.freedesktop.org;

[PATCH] drm/radeon: Don't turn off DP sink when disconnected

From: Michel Dänzer Turning off the sink in this case causes various issues, because userspace expects it to stay on until it turns it off explicitly. Instead, turn the sink off and back on when a display is connected again. This dance seems necessary for link training

Debugging modesetting problem

Hi AMD graphics developers, I've recently hit a modesetting problem: when I used the DisplayPort KVM switch that I got yesterday to connect my PC (running Arch Linux) to my 4K monitor, it only worked in 3 out of about 60 times of switching/replugging the cable (the BIOS always manages to put

Re: [PATCH] drm/amdgpu: Use atomic function to disable crtcs with dc enabled

Reviewed-by: Andrey Grodzovsky Andrey On 03/14/2018 01:51 PM, mikita.lip...@amd.com wrote: From: Mikita Lipski This change fixes the deadlock when unloading the driver with displays connected. Signed-off-by: Mikita Lipski

[PATCH] drm/amdgpu: Use atomic function to disable crtcs with dc enabled

From: Mikita Lipski This change fixes the deadlock when unloading the driver with displays connected. Signed-off-by: Mikita Lipski --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

Re: [PATCH 1/2] drm/amdgpu: Improve documentation of bo_ptr in amdgpu_bo_create_kernel

Am 14.03.2018 um 19:07 schrieb Andrey Grodzovsky: and amdgpu_bo_create_reserved. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] drm/amd/powerplay: Fix KASAN user after free on driver unload.

Reusing local handle to initialize BO without resetting it to NULL is wrong since it causes amdgpu_bo_create_reserved to skip new BO creation and just reuse the given pointer for pinning. Signed-off-by: Andrey Grodzovsky ---

[PATCH 1/2] drm/amdgpu: Improve documentation of bo_ptr in amdgpu_bo_create_kernel

and amdgpu_bo_create_reserved. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

Re: [PATCH 2/2] drm/amd/powerplay: Fix KASAN user after free on driver unload.

Am 14.03.2018 um 19:07 schrieb Andrey Grodzovsky: Reusing local handle to initialize BO without resetting it to NULL is wrong since it causes amdgpu_bo_create_reserved to skip new BO creation and just reuse the given pointer for pinning. Signed-off-by: Andrey Grodzovsky

Re: [PATCH 1/3] drm/amdgpu: remove trailing whitespace from soc15ip.h

Am 14.03.2018 um 14:42 schrieb Alex Deucher: On Wed, Mar 14, 2018 at 4:01 AM, Christian König wrote: Am 14.03.2018 um 02:22 schrieb Alex Deucher: no intended functional change. Signed-off-by: Alex Deucher Reviewed-by: Christian

Re: vga handover for raven

Hi Harry, Reverting that on top of the current amd-staging-drm-next seems to have fixed the issue. Thanks, Tom On 03/14/2018 10:08 AM, Harry Wentland wrote: On 2018-03-14 09:54 AM, Tom St Denis wrote: Hi, In the original version of the patch we had: @@ -358,7 +360,9 @@ struct

[PATCH xf86-video-ati] Pass extents to amdgpu_scanout_do_update by value

From: Michel Dänzer amdgpu_scanout_extents_intersect could leave the scanout damage region in an invalid state, triggering debugging checks in pixman: *** BUG *** In pixman_region_append_non_o: The expression r->x1 < r->x2 was false Set a breakpoint on

Re: AMD E8860 on PowerPC with u-boot (T2080)

I have the radeon driver working on the T2080, and am currently running into a problem with gallium/mesa. My problem was a mismatch between u-boot and my device-tree that caused PCI Express to misbehave. When I run a program calling OpenCL, I get a segfault. The cause for this particular crash in

Re: vga handover for raven

This diff on top of drm-next works fine diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c index 4365906b14ee..7688ed5724b9 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +++

Re: How to enable Radeon Pro Duo with mesa

On Wed, Mar 14, 2018 at 5:41 AM, Lvzhihong (ReJohn) wrote: > Hi All , > > Does mesa support Radeon Pro Duo? I don’t know how to configure xorg.conf to > use two WX7100 card of DUO , and now I can only use the first card of DUO. What are you trying to do? A large desktop

vga handover for raven

Hi, In the original version of the patch we had: @@ -358,7 +360,9 @@ struct dce_hwseq_registers { HWSEQ_PIXEL_RATE_MASK_SH_LIST(mask_sh, OTG0_),\ HWS_SF1(OTG0_, PHYPLL_PIXEL_RATE_CNTL, PHYPLL_PIXEL_RATE_SOURCE, mask_sh), \ HWS_SF(, DCHUBBUB_GLOBAL_TIMER_CNTL,

RE: vga handover for raven

If there is no VGA hand over, the change should make no difference. In the VGA hand over case, the difference introduced is the following, we can try to revert this part of the commit, which should not break S3. REG_WRITE(D1VGA_CONTROL, 0); - REG_WRITE(D2VGA_CONTROL, 0); -

Re: [PATCH] drm/amd/display: Fix null pointer when setting backlight

On Wed, Mar 14, 2018 at 9:55 AM, Harry Wentland wrote: > Fixes: c894d9f208f9 (drm/amd/display: Fixed dim around 1sec when resume > from S3) > > Signed-off-by: Harry Wentland Acked-by: Alex Deucher > --- >

[PATCH] drm/amd/display: Fix null pointer when setting backlight

Fixes: c894d9f208f9 (drm/amd/display: Fixed dim around 1sec when resume from S3) Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] drm/radeon: Don't turn off DP sink when disconnected

On Wed, Mar 14, 2018 at 1:15 PM, Michel Dänzer wrote: > From: Michel Dänzer > > Turning off the sink in this case causes various issues, because > userspace expects it to stay on until it turns it off explicitly. > > Instead, turn the sink off and back

[pull] radeon and amdgpu drm-fixes-4.16

Hi Dave, A few fixes for 4.16: - Fix a backlight S/R regression on amdgpu - Fix prime teardown on radeon and amdgpu - DP fix for amdgpu The following changes since commit b0655d668fc4faf0c1985e828820f9b9ca13abe6: Merge branch 'drm-fixes-4.16' of git://people.freedesktop.org/~agd5f/linux into