[PATCH v2] drm/amd/display: Fix bug use wrong pp interface

2018-08-22 Thread Rex Zhu
Used wrong pp interface, the original interface is exposed by dpm on SI and paritial CI. Pointed out by Francis David v2: dal only need to set min_dcefclk and min_fclk to smu. so use display_clock_voltage_request interface, instand of update all display configuration. Acked-by: Alex

Re: [PATCH] drm/amdgpu: Fix page fault and kasan warning on pci device remove.

2018-08-22 Thread Christian König
Am 21.08.2018 um 23:23 schrieb Andrey Grodzovsky: Problem: When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning as bellow and page fault happen because adev->gart.pages already freed by the time amdgpu_gart_unbind is called. BUG: KASAN: user-memory-access in

[PATCH v5 5/5] drm/amdgpu: move PD/PT bos on LRU again

2018-08-22 Thread Huang Rui
The new bulk moving functionality is ready, the overhead of moving PD/PT bos to LRU is fixed. So move them on LRU again. Signed-off-by: Huang Rui Tested-by: Mike Lothian Tested-by: Dieter Nützel Acked-by: Chunming Zhou Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2

Re: [PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote: > VK_KHR_timeline_semaphore: > This extension introduces a new type of semaphore that has an integer payload > identifying a point in a timeline. Such timeline semaphores support the > following operations: > * Host query - A host

Re: Find out DCE version

2018-08-22 Thread Paul Menzel
Dear Jim, Am 22.08.2018 um 08:39 schrieb Qu, Jim: You may get the answer from https://www.x.org/wiki/RadeonFeature/. Thank you very much. But can this information be queried from the running system? If not, it’d be great, if it’d be added to the Linux messages. Kind regards, Paul

[PATCH v5 0/5] drm/ttm,amdgpu: Introduce LRU bulk move functionality

2018-08-22 Thread Huang Rui
The idea and proposal is originally from Christian, and I continue to work to deliver it. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of them on the end of LRU list one by one. Thus, that cause so many BOs moved to the end of the LRU, and impact

Re: [PATCH v5 0/5] drm/ttm,amdgpu: Introduce LRU bulk move functionality

2018-08-22 Thread Christian König
Please commit patches #1, #2 and #3, doesn't make much sense to send them out even more often. Jerry's comments on patch #4 sound valid to me as well, but with those minor issues fixes/commented I think we can commit it. Thanks for taking care of this, Christian. Am 22.08.2018 um 09:52

Re: [PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Huang Rui
On Wed, Aug 22, 2018 at 04:07:20PM +0800, Zhang, Jerry wrote: > On 08/22/2018 03:52 PM, Huang Rui wrote: > > I continue to work for bulk moving that based on the proposal by Christian. > > > > Background: > > amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move > > all of > >

Re: [PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Huang Rui
On Wed, Aug 22, 2018 at 04:33:30PM +0800, Huang Rui wrote: > On Wed, Aug 22, 2018 at 04:07:20PM +0800, Zhang, Jerry wrote: > > On 08/22/2018 03:52 PM, Huang Rui wrote: > > > I continue to work for bulk moving that based on the proposal by > > > Christian. > > > > > > Background: > > > amdgpu

[PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread Chunming Zhou
stub fence will be used by timeline syncobj as well. Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285 Signed-off-by: Chunming Zhou Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 28 ++-- include/drm/drm_syncobj.h | 24 2 files

Re: [PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 04:33 PM, Huang Rui wrote: On Wed, Aug 22, 2018 at 04:07:20PM +0800, Zhang, Jerry wrote: On 08/22/2018 03:52 PM, Huang Rui wrote: I continue to work for bulk moving that based on the proposal by Christian. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle

[PATCH] drm/amdgpu: move set pg state to suspend phase2

2018-08-22 Thread Yintian Tao
Under virtualization, We have to require full-acess gpu at suspend phase2 due to some special register access. In order to guarantee it, we should move set pg and cg state to suspend phase2 to make registers access at one full-acess lifecycle. Signed-off-by: Yintian Tao ---

Re: [PATCH v5 0/5] drm/ttm,amdgpu: Introduce LRU bulk move functionality

2018-08-22 Thread Huang Rui
On Wed, Aug 22, 2018 at 04:24:02PM +0800, Christian König wrote: > Please commit patches #1, #2 and #3, doesn't make much sense to send > them out even more often. > > Jerry's comments on patch #4 sound valid to me as well, but with those > minor issues fixes/commented I think we can commit it.

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread Christian König
Am 22.08.2018 um 10:38 schrieb Chunming Zhou: stub fence will be used by timeline syncobj as well. Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285 Signed-off-by: Chunming Zhou Cc: Jason Ekstrand --- drivers/gpu/drm/drm_syncobj.c | 28 ++--

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread zhoucm1
On 2018年08月22日 17:05, Christian König wrote: Am 22.08.2018 um 11:02 schrieb zhoucm1: On 2018年08月22日 16:52, Christian König wrote: Am 22.08.2018 um 10:38 schrieb Chunming Zhou: stub fence will be used by timeline syncobj as well. Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285

Re: [PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 04:38 PM, Huang Rui wrote: On Wed, Aug 22, 2018 at 04:33:30PM +0800, Huang Rui wrote: On Wed, Aug 22, 2018 at 04:07:20PM +0800, Zhang, Jerry wrote: On 08/22/2018 03:52 PM, Huang Rui wrote: I continue to work for bulk moving that based on the proposal by Christian. Background:

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 10:52:16AM +0200, Christian König wrote: > Am 22.08.2018 um 10:38 schrieb Chunming Zhou: > > stub fence will be used by timeline syncobj as well. > > > > Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285 > > Signed-off-by: Chunming Zhou > > Cc: Jason Ekstrand > > ---

RE: [PATCH] drm/amdgpu: move set pg state to suspend phase2

2018-08-22 Thread Tao, Yintian
Please ignore this patch. I will re-submit patch with better solution. -Original Message- From: Yintian Tao [mailto:yt...@amd.com] Sent: Wednesday, August 22, 2018 2:50 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: move set pg state to suspend phase2

Re: [PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread Christian König
Am 22.08.2018 um 10:57 schrieb Christian König: Am 22.08.2018 um 10:49 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations:  

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread Christian König
Am 22.08.2018 um 11:10 schrieb zhoucm1: On 2018年08月22日 17:05, Christian König wrote: Am 22.08.2018 um 11:02 schrieb zhoucm1: On 2018年08月22日 16:52, Christian König wrote: Am 22.08.2018 um 10:38 schrieb Chunming Zhou: stub fence will be used by timeline syncobj as well. Change-Id:

Re: [PATCH v4 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v4)

2018-08-22 Thread Huang Rui
On Wed, Aug 22, 2018 at 11:31:02AM +0800, Huang Rui wrote: > On Tue, Aug 21, 2018 at 03:54:28PM +0200, Christian König wrote: > > Am 21.08.2018 um 15:43 schrieb Huang Rui: > > >On Mon, Aug 20, 2018 at 09:17:12PM +0800, Christian König wrote: > > >>Am 20.08.2018 um 08:05 schrieb Huang Rui: > >

[PATCH v5 3/5] drm/ttm: add bulk move function on LRU

2018-08-22 Thread Huang Rui
This function allow us to bulk move a group of BOs to the tail of their LRU. The positions of group of BOs are stored on the (first, last) bulk_move_pos structure. Signed-off-by: Christian König Signed-off-by: Huang Rui Tested-by: Mike Lothian Tested-by: Dieter Nützel Acked-by: Chunming Zhou

[PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Huang Rui
I continue to work for bulk moving that based on the proposal by Christian. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of them on the end of LRU list one by one. Thus, that cause so many BOs moved to the end of the LRU, and impact performance

[PATCH v5 2/5] drm/ttm: revise ttm_bo_move_to_lru_tail to support bulk moves

2018-08-22 Thread Huang Rui
From: Christian König When move a BO to the end of LRU, it need remember the BO positions. Make sure all moved bo in between "first" and "last". And they will be bulk moving together. Signed-off-by: Christian König Signed-off-by: Huang Rui Tested-by: Mike Lothian Tested-by: Dieter Nützel

[PATCH v5 1/5] drm/ttm: add helper structures for bulk moves on lru list

2018-08-22 Thread Huang Rui
From: Christian König Add bulk move pos to store the pointer of first and last buffer object. The list in between will be bulk moved on lru list. Signed-off-by: Christian König Signed-off-by: Huang Rui Tested-by: Mike Lothian Tested-by: Dieter Nützel Acked-by: Chunming Zhou Reviewed-by:

Re: [PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 03:52 PM, Huang Rui wrote: I continue to work for bulk moving that based on the proposal by Christian. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of them on the end of LRU list one by one. Thus, that cause so many BOs moved to the end

Re: [PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread Christian König
Am 22.08.2018 um 10:49 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * Host query - A host operation that allows

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread zhoucm1
On 2018年08月22日 16:52, Christian König wrote: Am 22.08.2018 um 10:38 schrieb Chunming Zhou: stub fence will be used by timeline syncobj as well. Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285 Signed-off-by: Chunming Zhou Cc: Jason Ekstrand ---   drivers/gpu/drm/drm_syncobj.c | 28

答复: Find out DCE version

2018-08-22 Thread Qu, Jim
You may get the answer from https://www.x.org/wiki/RadeonFeature/. Thanks JimQu 发件人: amd-gfx 代表 Paul Menzel 发送时间: 2018年8月22日 13:30:12 收件人: amd-gfx@lists.freedesktop.org 主题: Find out DCE version Dear Linux folks, How do I easily determine from a

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-22 Thread Christian König
Am 21.08.2018 um 23:45 schrieb Felix Kuehling: This patch is meant for amd-staging-drm-next. It's part of my effort to reduce differences between kfd-staging and upstream and eventually replace all our memory manager hacks with upstream solutions. This commit should only affect GFXv8 and older.

[PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * Host query - A host operation that allows querying the payload of the timeline semaphore.

Re: [PATCH v5 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v5)

2018-08-22 Thread Huang Rui
On Wed, Aug 22, 2018 at 04:45:27PM +0800, Zhang, Jerry (Junwei) wrote: > On 08/22/2018 04:38 PM, Huang Rui wrote: > >On Wed, Aug 22, 2018 at 04:33:30PM +0800, Huang Rui wrote: > >>On Wed, Aug 22, 2018 at 04:07:20PM +0800, Zhang, Jerry wrote: > >>>On 08/22/2018 03:52 PM, Huang Rui wrote: > I

答复: Find out DCE version

2018-08-22 Thread Qu, Jim
If driver uses legacy DCE driver, it can be got from dmesg, like dce_v6_0, but if driver uses DC driver for display, it has not. Why do you want to get DCE info? Thanks JimQu 发件人: Paul Menzel 发送时间: 2018年8月22日 15:01:37 收件人: Qu, Jim 抄送:

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread Christian König
Am 22.08.2018 um 11:02 schrieb zhoucm1: On 2018年08月22日 16:52, Christian König wrote: Am 22.08.2018 um 10:38 schrieb Chunming Zhou: stub fence will be used by timeline syncobj as well. Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285 Signed-off-by: Chunming Zhou Cc: Jason Ekstrand ---  

Re: [PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread zhoucm1
On 2018年08月22日 17:24, Daniel Vetter wrote: On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following

Re: [PATCH 10/11] drm/amdgpu: add helper for VM PD/PT allocation parameters

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 11:05 PM, Christian König wrote: Add a helper function to figure them out only once. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 -- 1 file changed, 28 insertions(+), 33 deletions(-) diff

Re: KFD co-maintainership and branch model

2018-08-22 Thread David Airlie
On Thu, Aug 23, 2018 at 8:25 AM, Felix Kuehling wrote: > Hi all, > > Oded has offered to make me co-maintainer of KFD, as he's super busy at > work and less responsive than he used to be. > > At the same time we're about to send out the first patches to merge KFD > and AMDGPU into a single kernel

Re: KFD co-maintainership and branch model

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/23/2018 06:25 AM, Felix Kuehling wrote: Hi all, Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be. At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module. With that

Re: [PATCH 07/11] drm/amdgpu: add GMC9 support for PDs/PTs in system memory

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 11:05 PM, Christian König wrote: Add the necessary handling. Signed-off-by: Christian König Looks going to use GTT for page table. What kind of scenario to use that? could it be replaced by CPU updating page table in system memory? Regards, Jerry ---

Re: [PATCH 10/11] drm/amdgpu: add helper for VM PD/PT allocation parameters

2018-08-22 Thread Alex Deucher
On Wed, Aug 22, 2018 at 11:06 AM Christian König wrote: > > Add a helper function to figure them out only once. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 -- > 1 file changed, 28 insertions(+), 33

Re: [PATCH] drm/amdgpu: move full access into amdgpu_device_ip_suspend

2018-08-22 Thread Alex Deucher
On Wed, Aug 22, 2018 at 7:26 AM Yintian Tao wrote: > > It will be more safe to make full-acess include both phase1 and phase2. > Then accessing special registeris wherever at phase1 or phase2 will not > block any shutdown and suspend process under virtualization. > > Signed-off-by: Yintian Tao

Re: [PATCH 01/11] drm/amdgpu: remove extra root PD alignment

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/23/2018 03:46 AM, Alex Deucher wrote: On Wed, Aug 22, 2018 at 11:05 AM Christian König wrote: Just another leftover from radeon. I can't remember exactly what chip this was for. Are you sure this isn't still required for SI or something like that? FYI. Some projects still use SI

Re: [PATCH 02/11] drm/amdgpu: validate the VM root PD from the VM code

2018-08-22 Thread Zhang, Jerry (Junwei)
Patch 2 ~ 6 are Reviewed-by: Junwei Zhang Jerry On 08/22/2018 11:05 PM, Christian König wrote: Preparation for following changes. This validates the root PD twice, but the overhead of that should be minimal. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8

Re: [PATCH 2/6] drm/amdgpu: cleanup GPU recovery check a bit

2018-08-22 Thread Huang Rui
On Wed, Aug 22, 2018 at 12:04:53PM +0200, Christian König wrote: > Check if we should call the function instead of providing the forced > flag. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 >

Re: [PATCH 08/11] drm/amdgpu: add amdgpu_gmc_pd_addr helper

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 11:05 PM, Christian König wrote: Add a helper to get the root PD address and remove the workarounds from the GMC9 code for that. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 +-

Re: [PATCH v6 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v6)

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 06:12 PM, Huang Rui wrote: I continue to work for bulk moving that based on the proposal by Christian. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of them on the end of LRU list one by one. Thus, that cause so many BOs moved to the end

RE: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset

2018-08-22 Thread Deng, Emily
>-Original Message- >From: Christian König >Sent: Wednesday, August 22, 2018 8:24 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset > >Am 22.08.2018 um 06:39 schrieb Emily Deng: >> When in gpu reset, don't use kiq, it will

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Jani Nikula
On Wed, 22 Aug 2018, Daniel Vetter wrote: > Hi all, > > I think it's time to brainstorm a bit about the gitlab migration. Basic > reasons: > > - fd.o admins want to deprecate shell accounts and hand-rolled > infrastructure, because it's a pain to keep secure > > - gitlab will allow us to add

Re: [PATCH v2] drm/amd/display: Fix bug use wrong pp interface

2018-08-22 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, August 22, 2018 2:41:19 AM To: amd-gfx@lists.freedesktop.org; Francis, David; Wentland, Harry Cc: Zhu, Rex Subject: [PATCH v2] drm/amd/display: Fix bug use wrong pp interface Used

Re: [PATCH] drm/amdgpu: Fix page fault and kasan warning on pci device remove.

2018-08-22 Thread Andrey Grodzovsky
On 08/22/2018 02:57 AM, Christian König wrote: Am 21.08.2018 um 23:23 schrieb Andrey Grodzovsky: Problem: When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning as bellow and page fault happen because adev->gart.pages already freed by the time amdgpu_gart_unbind is called.

[PATCH 4/5] drm/amdgpu: implement soft_recovery for GFX8 v2

2018-08-22 Thread Christian König
Try to kill waves on the SQ. v2: only for the GFX ring for now. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index

[PATCH 2/5] drm/amdgpu: add ring soft recovery v2

2018-08-22 Thread Christian König
Instead of hammering hard on the GPU try a soft recovery first. v2: reorder code a bit Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 24 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4

[PATCH 4/6] drm/amdgpu: implement soft_recovery for GFX7

2018-08-22 Thread Christian König
Try to kill waves on the SQ. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 95452c5a9df6..a15d9c0f233b 100644 ---

[PATCH 5/5] drm/amdgpu: implement soft_recovery for GFX9

2018-08-22 Thread Christian König
Try to kill waves on the SQ. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 44707f94b2c5..ab5cacea967b 100644 ---

[PATCH 1/5] drm/amdgpu: cleanup GPU recovery check a bit

2018-08-22 Thread Christian König
Check if we should call the function instead of providing the forced flag. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 -- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-

[PATCH 3/5] drm/amdgpu: implement soft_recovery for GFX7

2018-08-22 Thread Christian König
Try to kill waves on the SQ. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c index 95452c5a9df6..a15d9c0f233b 100644 ---

RE: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset

2018-08-22 Thread Deng, Emily
Ping.. >-Original Message- >From: amd-gfx On Behalf Of Emily >Deng >Sent: Wednesday, August 22, 2018 12:39 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deng, Emily >Subject: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset > >When in gpu reset, don't use kiq, it will generate more

Re: [igt-dev] RFC: Migration to Gitlab

2018-08-22 Thread Adam Jackson
On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: > - Sticking to fdo bugzilla and disabling gitlab issues for at least > drm-intel for the time being. Doing that migration in the same go is a > bit much I think. Reassignment across bugzilla and gitlab will be an > issue. Can you

Re: [Intel-gfx] RFC: Migration to Gitlab

2018-08-22 Thread Sean Paul
On Wed, Aug 22, 2018 at 01:44:56PM +0200, Daniel Vetter wrote: > Hi all, > > I think it's time to brainstorm a bit about the gitlab migration. Basic > reasons: > > - fd.o admins want to deprecate shell accounts and hand-rolled > infrastructure, because it's a pain to keep secure > > - gitlab

Re: [PATCH] drm/amdgpu: Fix page fault and kasan warning on pci device remove.

2018-08-22 Thread Andrey Grodzovsky
On 08/22/2018 01:28 AM, Paul Menzel wrote: Dear Andrey, Am 21.08.2018 um 23:23 schrieb Andrey Grodzovsky: Problem: When executing echo 1 > /sys/class/drm/card0/device/remove kasan warning as bellow and page fault happen because adev->gart.pages already freed by the time amdgpu_gart_unbind

Re: [PATCH 11/11] drm/amdgpu: enable GTT PD/PT for raven

2018-08-22 Thread Zhang, Jerry (Junwei)
On 08/22/2018 11:05 PM, Christian König wrote: Should work on Vega10 as well, but with an obvious performance hit. Older APUs can be enabled as well, but will probably be more work. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 11 ++- 1 file changed,

Re: [PATCH] drm/amdgpu: Set pasid for compute vm

2018-08-22 Thread Felix Kuehling
See comments inline ... Regards,   Felix On 2018-08-22 05:10 PM, Oak Zeng wrote: > Signed-off-by: Oak Zeng > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |

Re: [PATCH 08/11] drm/amdgpu: add amdgpu_gmc_pd_addr helper

2018-08-22 Thread Felix Kuehling
Acked-by: Felix Kuehling The amdgpu_amdkfd_gpuvm code looked different than I remembered. There are some important patches missing upstream that I'll roll into my next patch series. Regards,   Felix On 2018-08-22 11:05 AM, Christian König wrote: > Add a helper to get the root PD address and

Re: Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 12:44 PM Felix Kuehling wrote: > > You're right, but that's a bit fragile and convoluted. I'll fix KFD to > handle this more robustly. See the attached (untested) patch. Yes, this patch that makes the whole "has to use current mm" or uses "get_task_mm()" looks good from a

Re: [PATCH 2/2] drm/amdgpu: Change kiq ring initialize sequence on gfx9

2018-08-22 Thread Alex Deucher
On Wed, Aug 22, 2018 at 7:26 AM Rex Zhu wrote: > > 1. initialize kiq before initialize gfx ring. > 2. set kiq ring ready immediately when kiq initialize >successfully. > 3. split function gfx_v9_0_kiq_resume into two functions. > gfx_v9_0_kiq_resume is for kiq initialize. >

Re: Possible use_mm() mis-uses

2018-08-22 Thread Oded Gabbay
On Wed, Aug 22, 2018 at 10:58 PM Linus Torvalds wrote: > > On Wed, Aug 22, 2018 at 12:37 PM Oded Gabbay wrote: > > > > Having said that, I think we *are* protected by the mmu_notifier > > release because if the process suddenly dies, we will gracefully clean > > the process's data in our driver

[PATCH 01/11] drm/amd/display: Eliminate i2c hw function pointers

2018-08-22 Thread sunpeng.li
From: David Francis [Why] The function pointers of the dce_i2c_hw struct were never accessed from outside dce_i2c_hw.c and had only one version. As function pointers take up space and make debugging difficult, and they are not needed in this case, they should be removed. [How] Remove the

[PATCH] drm/amdgpu: Set pasid for compute vm

2018-08-22 Thread Oak Zeng
Signed-off-by: Oak Zeng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +-

[PATCH 10/11] drm/amd/display: support 48 MHZ refclk off

2018-08-22 Thread sunpeng.li
From: Eric Yang [Why] On PCO and up, whenever SMU receive message to indicate active display count = 0. SMU will turn off 48MHZ TMDP reference clock by writing to 1 TMDP_48M_Refclk_Driver_PWDN. Once this clock is off, no PHY register will respond to register access. This means our current

[PATCH 07/11] drm/amd/display: Improve spelling, grammar, and formatting of amdgpu_dm.c comments

2018-08-22 Thread sunpeng.li
From: David Francis [Why] Good spelling and grammar makes comments more pleasant and clearer. Linux has coding standards for comments that we should try to follow. [How] Fix obvious spelling and grammar issues Ensure all comments use '/*' and '*/' and multi-line comments follow linux

[PATCH 00/11] DC Patches Aug 22, 2018

2018-08-22 Thread sunpeng.li
From: Leo Li Summary of change: * Flattening and cleaning up of i2c code * Spelling and grammar fixups in amdgpu_dm * Implement hardware state logging via debugfs David Francis (4): drm/amd/display: Eliminate i2c hw function pointers drm/amd/display: Improve spelling, grammar, and

[PATCH 06/11] drm/amd/display: Fix memory leak caused by missed dc_sink_release

2018-08-22 Thread sunpeng.li
From: SivapiriyanKumarasamy [Why] There is currently an intermittent hang from a memory leak in DTN stress testing. It is caused by unfreed memory during driver disable. [How] Do a dc_sink_release in the case that skips it incorrectly. Signed-off-by: SivapiriyanKumarasamy Reviewed-by: Aric

[PATCH 03/11] drm/amd/display: Use non-deprecated vblank handler

2018-08-22 Thread sunpeng.li
From: "Leo (Sunpeng) Li" [Why] drm_handle_vblank is deprecated. Use drm_crtc_handle_vblank instead. Signed-off-by: Leo (Sunpeng) Li Reviewed-by: David Francis Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 -- 1 file changed, 4 insertions(+), 6

Re: Possible use_mm() mis-uses

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 12:37 PM Oded Gabbay wrote: > > Having said that, I think we *are* protected by the mmu_notifier > release because if the process suddenly dies, we will gracefully clean > the process's data in our driver and on the H/W before returning to > the mm core code. And before we

[PATCH 04/11] drm/amd/display: Add support for hw_state logging via debugfs

2018-08-22 Thread sunpeng.li
From: Nicholas Kazlauskas [Why] We have logging methods for printing hardware state for newer ASICs but no way to trigger the log output. [How] Add support for triggering the output via writing to a debugfs file entry. Log output currently goes into dmesg for convenience, but accessing via a

[PATCH 02/11] drm/amd/display: dc 3.1.63

2018-08-22 Thread sunpeng.li
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Steven Chiu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 2bb7719..9ce14a2

[PATCH 11/11] drm/amd/display: Flatten unnecessary i2c functions

2018-08-22 Thread sunpeng.li
From: David Francis [Why] The dce_i2c_hw code contained four funtcions that were only called in one place and did not have a clearly delineated purpose. [How] Inline these functions, keeping the same functionality. This is not a functional change. The functions disable_i2c_hw_engine and

Re: [PATCH] drm/amdgpu: Set pasid for compute vm

2018-08-22 Thread Alex Deucher
On Wed, Aug 22, 2018 at 5:31 PM Oak Zeng wrote: > Please provide a patch description. Alex > Signed-off-by: Oak Zeng > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 09/11] drm/amd/display: Remove redundant i2c structs

2018-08-22 Thread sunpeng.li
From: David Francis [Why] The i2c code contains two structs that contain the same information as i2c_payload [How] Replace references to those structs with references to i2c_payload dce_i2c_transaction_request->status was written to but never read, so all references to it are removed

[PATCH 08/11] drm/amd/display: Support reading hw state from debugfs file

2018-08-22 Thread sunpeng.li
From: Nicholas Kazlauskas [Why] Logging hardware state can be done by triggering a write to the debugfs file. It would also be useful to be able to read the hardware state from the debugfs file to be able to generate a clean log without timestamps. [How] Usage: cat

[PATCH 05/11] drm/amd/display: eliminate long wait between register polls on Maximus

2018-08-22 Thread sunpeng.li
From: Ken Chalmers [Why] Now that we "scale" time delays correctly on Maximus (as of diags svn r170115), the forced "35 ms" wait time now becomes 35 ms * 500 = 17.5 seconds, which is far too long. Even having to repeat polling a register once causes excessive delays on Maximus. [How] Just use

[pull] amdgpu drm-next-4.19

2018-08-22 Thread Alex Deucher
Hi Dave, Fixes for 4.19: - Fix build when KCOV is enabled - Misc display fixes - A couple of SR-IOV fixes - Fence fixes for eviction handling for KFD - Misc other fixes The following changes since commit 3d63a3c14741ed015948943076f3c6a2f2cd7b27: Merge tag 'drm-msm-next-2018-08-10' of

KFD co-maintainership and branch model

2018-08-22 Thread Felix Kuehling
Hi all, Oded has offered to make me co-maintainer of KFD, as he's super busy at work and less responsive than he used to be. At the same time we're about to send out the first patches to merge KFD and AMDGPU into a single kernel module. With that in mind I'd like to propose to upstream KFD

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread zhoucm1
On 2018年08月22日 17:34, Daniel Vetter wrote: On Wed, Aug 22, 2018 at 04:38:56PM +0800, Chunming Zhou wrote: stub fence will be used by timeline syncobj as well. Change-Id: Ia4252f03c07a8105491d2791dc7c8c6976682285 Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Please don't expose stuff

[PATCH] amdgpu: fix multi-process hang issue

2018-08-22 Thread Emily Deng
SWDEV-146499: hang during multi vulkan process testing cause: the second frame's PREAMBLE_IB have clear-state and LOAD actions, those actions ruin the pipeline that is still doing process in the previous frame's work-load IB. fix: need insert pipeline sync if have context switch for SRIOV

Re: [PATCH] amdgpu: fix multi-process hang issue

2018-08-22 Thread Christian König
Am 22.08.2018 um 14:07 schrieb Emily Deng: SWDEV-146499: hang during multi vulkan process testing cause: the second frame's PREAMBLE_IB have clear-state and LOAD actions, those actions ruin the pipeline that is still doing process in the previous frame's work-load IB. fix: need insert pipeline

Re: [PATCH 1/3] drm/amdgpu: Don't use kiq in gpu reset

2018-08-22 Thread Christian König
Am 22.08.2018 um 06:39 schrieb Emily Deng: When in gpu reset, don't use kiq, it will generate more TDR. Signed-off-by: Emily Deng Patch #1 is Reviewed-by: Christian König . Patch #2 actually not necessary since we should never flush the tlb from interrupt context. Patch #3: I would

[PATCH v6 4/5] drm/amdgpu: use bulk moves for efficient VM LRU handling (v6)

2018-08-22 Thread Huang Rui
I continue to work for bulk moving that based on the proposal by Christian. Background: amdgpu driver will move all PD/PT and PerVM BOs into idle list. Then move all of them on the end of LRU list one by one. Thus, that cause so many BOs moved to the end of the LRU, and impact performance

Re: [PATCH 1/2] drm: rename null fence to stub fence in syncobj

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 05:56:10PM +0800, zhoucm1 wrote: > > > On 2018年08月22日 17:34, Daniel Vetter wrote: > > On Wed, Aug 22, 2018 at 04:38:56PM +0800, Chunming Zhou wrote: > > > stub fence will be used by timeline syncobj as well. > > > > > > Change-Id:

[PATCH 6/6] drm/amdgpu: implement soft_recovery for GFX9

2018-08-22 Thread Christian König
Try to kill waves on the SQ. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c index 44707f94b2c5..ab5cacea967b 100644 ---

[PATCH 1/6] drm/amdgpu: fix preamble handling

2018-08-22 Thread Christian König
At this point the command submission can still be interrupted. Signed-off-by: Christian König Acked-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

[PATCH 3/6] drm/amdgpu: add ring soft recovery v2

2018-08-22 Thread Christian König
Instead of hammering hard on the GPU try a soft recovery first. v2: reorder code a bit Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 24 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4

[PATCH 2/6] drm/amdgpu: cleanup GPU recovery check a bit

2018-08-22 Thread Christian König
Check if we should call the function instead of providing the forced flag. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 -- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +-

[PATCH 5/6] drm/amdgpu: implement soft_recovery for GFX8 v2

2018-08-22 Thread Christian König
Try to kill waves on the SQ. v2: only for the GFX ring for now. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index

Re: [PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread zhoucm1
On 2018年08月22日 17:31, Daniel Vetter wrote: On Wed, Aug 22, 2018 at 05:28:17PM +0800, zhoucm1 wrote: On 2018年08月22日 17:24, Daniel Vetter wrote: On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that

[PATCH] drm/amdgpu: move full access into amdgpu_device_ip_suspend

2018-08-22 Thread Yintian Tao
It will be more safe to make full-acess include both phase1 and phase2. Then accessing special registeris wherever at phase1 or phase2 will not block any shutdown and suspend process under virtualization. Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12

[PATCH 2/2] drm/amdgpu: Change kiq ring initialize sequence on gfx9

2018-08-22 Thread Rex Zhu
1. initialize kiq before initialize gfx ring. 2. set kiq ring ready immediately when kiq initialize successfully. 3. split function gfx_v9_0_kiq_resume into two functions. gfx_v9_0_kiq_resume is for kiq initialize. gfx_v9_0_kcq_resume is for kcq initialize. Signed-off-by: Rex Zhu

[PATCH 1/2] drm/amdgpu: Change kiq initialize/reset sequence on gfx8

2018-08-22 Thread Rex Zhu
1. initialize kiq before initialize gfx ring. 2. set kiq ring ready immediately when kiq initialize successfully. 3. split function gfx_v8_0_kiq_resume into two functions. gfx_v8_0_kiq_resume is for kiq initialize. gfx_v8_0_kcq_resume is for kcq initialize. Signed-off-by: Rex Zhu ---

RFC: Migration to Gitlab

2018-08-22 Thread Daniel Vetter
Hi all, I think it's time to brainstorm a bit about the gitlab migration. Basic reasons: - fd.o admins want to deprecate shell accounts and hand-rolled infrastructure, because it's a pain to keep secure - gitlab will allow us to add committers on our own, greatly simplifying that process (and

Re: [PATCH 2/2] [RFC]drm: add syncobj timeline support

2018-08-22 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 05:28:17PM +0800, zhoucm1 wrote: > > > On 2018年08月22日 17:24, Daniel Vetter wrote: > > On Wed, Aug 22, 2018 at 04:49:28PM +0800, Chunming Zhou wrote: > > > VK_KHR_timeline_semaphore: > > > This extension introduces a new type of semaphore that has an integer > > > payload

  1   2   >