Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Kazlauskas, Nicholas
On 11/1/18 6:58 AM, Michel Dänzer wrote: > On 2018-10-31 6:54 p.m., Kazlauskas, Nicholas wrote: >> On 10/31/18 12:20 PM, Michel Dänzer wrote: >>> On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: On 10/31/18 10:12 AM, Michel Dänzer wrote: > On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas

[pull] amdgpu drm-next-4.20

2018-11-01 Thread Alex Deucher
Hi Dave, Fixes for 4.20. Highlights: - Fix flickering at low backlight levels on some systems - Fix some overclocking regressions - Vega20 updates for - GPU recovery fixes - Disable gfxoff on RV as some sbios/fw combinations are not stable yet The following changes since commit

[PATCH] drm/amd/powerplay: do the comparison in the right Khz granularity

2018-11-01 Thread Evan Quan
Convert the operands on the two sides into the same granularity. Change-Id: I41ece3be6d86defbc0620c5a58b45a1701f35718 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/2] drm/amdgpu: Add helper function to get sdma index

2018-11-01 Thread Cui
serie is Reviewed-by: Flora Cui 在 11/1/2018 1:57 PM, Rex Zhu 写道: > Get the sdma index from ring > > v2: refine function name > > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + > 2 files

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Pekka Paalanen
On Wed, 31 Oct 2018 17:54:34 + "Kazlauskas, Nicholas" wrote: > On 10/31/18 12:20 PM, Michel Dänzer wrote: > > On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: > >> On 10/31/18 10:12 AM, Michel Dänzer wrote: > >>> On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas wrote: > On

[bug report] drm/amd/dc: Add dc display driver (v2)

2018-11-01 Thread Dan Carpenter
Hello Harry Wentland, The patch 4562236b3bc0: "drm/amd/dc: Add dc display driver (v2)" from Sep 12, 2017, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:688 construct() error: we previously assumed 'dc->current_state' could be

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Michel Dänzer
On 2018-10-31 6:54 p.m., Kazlauskas, Nicholas wrote: > On 10/31/18 12:20 PM, Michel Dänzer wrote: >> On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: >>> On 10/31/18 10:12 AM, Michel Dänzer wrote: On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas wrote: > On 10/30/18 11:34 AM, Kazlauskas,

Freezes back with Raven Ridge 2500u and 4.19

2018-11-01 Thread Bráulio Bhavamitra
Hi all, 4.18 was completely stable with Raven Ridge 2500u and kernel opt idle=nomwait Now with 4.19 I'm having freezes again. And this time I cannot reboot using SysReq + B shortcut. Also the mouse is always frozen as well, before most of the times I could move it. Best Regards, Bráulio

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Michel Dänzer
On 2018-11-01 3:58 p.m., Kazlauskas, Nicholas wrote: > On 11/1/18 6:58 AM, Michel Dänzer wrote: >> On 2018-10-31 6:54 p.m., Kazlauskas, Nicholas wrote: >>> On 10/31/18 12:20 PM, Michel Dänzer wrote: On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: > On 10/31/18 10:12 AM, Michel Dänzer

Re: [PATCH] drm/amdgpu: revert "enable gfxoff in non-sriov and stutter mode by default"

2018-11-01 Thread Alex Deucher
On Wed, Oct 24, 2018 at 8:59 AM Christian König wrote: > > This is still completely breaking my Raven system. > > This reverts commit cdf2f910fa969adca1b0e3ad2b487821233dc038. > With that addition of: Revert until we sort out the sbios and firmware combinations that work correctly. bug:

Re: [PATCH] drm/amd/powerplay: do the comparison in the right Khz granularity

2018-11-01 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Thursday, November 1, 2018 3:16:38 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: do the comparison in the right Khz granularity Convert the operands

Re: Freezes back with Raven Ridge 2500u and 4.19

2018-11-01 Thread Alex Deucher
On Thu, Nov 1, 2018 at 8:34 AM Bráulio Bhavamitra wrote: > > Hi all, > > 4.18 was completely stable with Raven Ridge 2500u and kernel opt idle=nomwait > > Now with 4.19 I'm having freezes again. And this time I cannot reboot using > SysReq + B shortcut. > Also the mouse is always frozen as well,

Re: [PATCH 2/2] drm/amdgpu: Add helper function to get sdma index

2018-11-01 Thread Alex Deucher
On Thu, Nov 1, 2018 at 1:59 AM Rex Zhu wrote: > > Get the sdma index from ring > > v2: refine function name > > Signed-off-by: Rex Zhu Series is: Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1

[PATCH v2 2/3] drm/amdgpu: Fix a bad unit conversion in vega12 powerplay

2018-11-01 Thread David Francis
The default unit in powerplay is 10kHz To convert from 10kHz to kHz, multiply by 10 Signed-off-by: David Francis --- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c

[PATCH v2 3/3] drm/amdgpu: Change powerplay clock requests to mHz

2018-11-01 Thread David Francis
This will clean up powerplay code, as we are no longer multiplying the clocks by 1000 in DM and then dividing them by 1000 in powerplay Signed-off-by: David Francis --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 6 +++--- drivers/gpu/drm/amd/include/dm_pp_interface.h

[PATCH v2 1/3] drm/amdgpu: Stop dividing watermarks by 1000 in powerplay

2018-11-01 Thread David Francis
Watermarks were being multiplied by 1000 in amdgpu_dm and divided by 1000 in powerplay. Change watermarks to units of mhz to stop doing that. Signed-off-by: David Francis --- .../amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 24 +- .../drm/amd/display/dc/dm_services_types.h| 16

Re: [PATCH 2/2] drm/amd/display: Drop reusing drm connector for MST

2018-11-01 Thread Lyude Paul
Almost there. First thing I should mention: removing the connector reusage with this patch ended up exposing an issue that I think was getting papered over before because of it. It ended up being rather trivial to fix though, so I'll send the patch with more information on the issue/a fix for it

Re: [PATCH 1/2] drm/amd/display: Cleanup MST non-atomic code workaround

2018-11-01 Thread Lyude Paul
This patch is Reviewed-by: Lyude Paul On Tue, 2018-10-30 at 18:09 -0400, Jerry (Fangzhi) Zuo wrote: > [why] > It is not correct to touch aconnector within atomic_check. > > [How] > It was added as workaround before, and no longer needed. > > Signed-off-by: Jerry (Fangzhi) Zuo > --- >

[PATCH] drm/amd/amdgpu/dm: Fix dm_dp_create_fake_mst_encoder()

2018-11-01 Thread Lyude Paul
[why] Removing connector reusage from DM to match the rest of the tree ended up revealing an issue that was surprisingly subtle. The original amdgpu code for DC that was submitted appears to have left a chunk in dm_dp_create_fake_mst_encoder() that tries to find a "master encoder", the likes of

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-11-01 Thread Kazlauskas, Nicholas
On 11/1/18 1:05 PM, Michel Dänzer wrote: > On 2018-11-01 3:58 p.m., Kazlauskas, Nicholas wrote: >> On 11/1/18 6:58 AM, Michel Dänzer wrote: >>> On 2018-10-31 6:54 p.m., Kazlauskas, Nicholas wrote: On 10/31/18 12:20 PM, Michel Dänzer wrote: > On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas