RE: [PATCH 09/16] drm/amd/display: fbc state could not reach while enable fbc

2018-11-29 Thread Li, Roman
Unfortunately, not. I sent this patch to the reporter to try and it didn't work. - Roman From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, November 29, 2018 11:27 AM To: Li, Sun peng (Leo) ; amd-gfx@lists.freedesktop.org Cc: Wu, Hersen Subject: Re: [PATCH 09/16] drm/amd/display:

Re: [PATCH] drm/amd/display: limit high pixel clock modes on ST/CZ

2018-11-29 Thread Wentland, Harry
Hersen confirmed 4k60 works fine over DP. The problem here are really just USB-C ports and associated dongles. We've never supported USB-C dongles on CZ/ST before. Harry On 2018-11-27 1:49 p.m., S, Shirish wrote: > This is for the devices with type-c ports. > > Wherein the signal type is same

Re: amdgpu driver, Screen artifacts on >=75 Hz FHD display unless forced power state, if there was >=75 Hz when Xorg started.

2018-11-29 Thread Wentland, Harry
Does this patch help you? https://patchwork.freedesktop.org/patch/264781/ The easiest way to test it would be to build and try the amd-staging-drm-next branch from https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-drm-next Which monitors are you using and how are they connected (DP,

[PATCH 1/2] drm/amdgpu: Handle xgmi device removal and add reset wq.

2018-11-29 Thread Andrey Grodzovsky
XGMI hive has some resources allocted on device init which needs to be deallocated when the device is unregistered. Add per hive wq to allow all the nodes in hive to run resets concurently - this should speed up the total reset time to avoid breaching the PSP FW timeout. Signed-off-by: Andrey

[PATCH 2/2] drm/amdgpu: Implement concurrent asic reset for XGMI.

2018-11-29 Thread Andrey Grodzovsky
Use per hive wq to concurrently send reset commands to all nodes in the hive. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 33 +++--- 2 files changed, 32 insertions(+), 3

Re: [PATCH 1/6] drm/amdgpu: add VCN JPEG support amdgpu_ctx_num_entities

2018-11-29 Thread Alex Deucher
On Wed, Nov 28, 2018 at 3:12 AM Christian König wrote: > > Maybe drop patch #2 when you refactor that code in patch #3 and #4 anyway. > > On patch #3 I would put the new helper into amdgpu_ctx.c instead because > that is rather how rings map to userspace queues. > > Apart from that it looks good

[PATCH] drm/amdgpu: add VCN JPEG support amdgpu_ctx_num_entities

2018-11-29 Thread Alex Deucher
Looks like it was missed when setting support was added. Signed-off-by: Alex Deucher --- This is a legit bug fix. the rest of this series needs more work. drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c

Re: [PATCH 01/11] dma-buf: make fence sequence numbers 64 bit

2018-11-29 Thread Christian König
Am 29.11.18 um 09:08 schrieb zhoucm1: On 2018年11月28日 22:50, Christian König wrote: For a lot of use cases we need 64bit sequence numbers. Currently drivers overload the dma_fence structure to store the additional bits. Stop doing that and make the sequence number in the dma_fence always

Re: [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

2018-11-29 Thread Andrzej Hajda
On 21.11.2018 19:19, Laurent Pinchart wrote: > Hi Ville, > > Thank you for the patch. > > On Tuesday, 20 November 2018 18:13:42 EET Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Make life easier for drivers by simply passing the connector >> to drm_hdmi_avi_infoframe_from_display_mode() and

Re: [PATCH 01/11] dma-buf: make fence sequence numbers 64 bit

2018-11-29 Thread zhoucm1
On 2018年11月28日 22:50, Christian König wrote: For a lot of use cases we need 64bit sequence numbers. Currently drivers overload the dma_fence structure to store the additional bits. Stop doing that and make the sequence number in the dma_fence always 64bit. For compatibility with hardware

Re: [PATCH 1/4] drm/edid: Pass connector to AVI inforframe functions

2018-11-29 Thread Andrzej Hajda
Quite late, hopefully not too late. On 21.11.2018 12:51, Ville Syrjälä wrote: > On Wed, Nov 21, 2018 at 01:40:43PM +0200, Jani Nikula wrote: >> >>> return; >>> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c >>> b/drivers/gpu/drm/bridge/sil-sii8620.c >>> index

Re: [PATCH 04/11] drm/syncobj: use only a single stub fence

2018-11-29 Thread zhoucm1
Could you move this one to dma-fence as you said? Which will be used in other place as well. -David On 2018年11月28日 22:50, Christian König wrote: Extract of useful code from the timeline work. Let's use just a single stub fence instance instead of allocating a new one all the time.

Re: [PATCH libdrm 4/5] wrap syncobj timeline query/wait APIs for amdgpu v3

2018-11-29 Thread zhoucm1
On 2018年11月28日 22:50, Christian König wrote: From: Chunming Zhou v2: symbos are stored in lexical order. v3: drop export/import and extra query indirection Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h|

Re: restart syncobj timeline changes v2

2018-11-29 Thread zhoucm1
Looks very very good, and I applied them in my local, and tested by ./amdgpu_test -s 9 and synobj_basic/wait of IGT today. +Daniel, Chris, Eric, Could you also have a look as well? -David On 2018年11月28日 22:50, Christian König wrote: Tested this patch set more extensively in the last two

Re: [PATCH 02/11] dma-buf: add new dma_fence_chain container v2

2018-11-29 Thread Chris Wilson
Quoting Christian König (2018-11-28 14:50:12) > +/** > + * dma_fence_chain_for_each - iterate over all fences in chain > + * @fence: starting point as well as current fence > + * > + * Iterate over all fences in the chain. We keep a reference to the current > + * fence while inside the loop which

Re: [PATCH libdrm 3/5] add timeline wait/query ioctl v2

2018-11-29 Thread zhoucm1
On 2018年11月28日 22:50, Christian König wrote: From: Chunming Zhou v2: drop export/import Signed-off-by: Chunming Zhou --- xf86drm.c | 44 xf86drm.h | 8 2 files changed, 52 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index

Re: [PATCH libdrm 3/5] add timeline wait/query ioctl v2

2018-11-29 Thread Christian König
Am 29.11.18 um 10:28 schrieb zhoucm1: On 2018年11月28日 22:50, Christian König wrote: From: Chunming Zhou v2: drop export/import Signed-off-by: Chunming Zhou ---   xf86drm.c | 44   xf86drm.h |  8   2 files changed, 52 insertions(+) diff

[PATCH] drm/amd/display: Fix unintialized max_bpc state values

2018-11-29 Thread Nicholas Kazlauskas
[Why] If the "max bpc" isn't explicitly set in the atomic state then it have a value of 0. This has the correct behavior of limiting a panel to 8bpc in the case where the panel supports 8bpc. In the case of eDP panels this isn't a true assumption - there are panels that can only do 6bpc. Banding

Re: [PATCH] drm/amd/display: Fix unintialized max_bpc state values

2018-11-29 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Thursday, November 29, 2018 10:44:46 AM To: amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas Subject: [PATCH] drm/amd/display: Fix unintialized max_bpc state values [Why] If

[PATCH 07/16] drm/amd/display: CTS 4.2.2.7

2018-11-29 Thread sunpeng.li
From: abdoulaye berthe [Why] Failure to read Detailed Capabilities Info. [How] Read Detailed Capbilities Info 80h-08Fh. Signed-off-by: abdoulaye berthe Reviewed-by: Wenjing Liu Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 08/16] drm/amd/display: Info frame cleanup

2018-11-29 Thread sunpeng.li
From: Harmanprit Tatla * Use provided infopacket in stream (if valid) instead of reconstructing in set_vendor_info_packet() * Use proper format for enums * Use dc info packet struct instead Signed-off-by: Harmanprit Tatla Reviewed-by: Anthony Koo Acked-by: Krunoslav Kovac Acked-by: Leo Li

[PATCH 04/16] drm/amd/display: Add tracing to dc

2018-11-29 Thread sunpeng.li
From: David Francis [Why] Tracing is a useful and cheap debug functionality [How] This creates a new trace system amdgpu_dm, currently with three trace events amdgpu_dc_rreg and amdgpu_dc_wreg report the address and value of any dc register reads and writes amdgpu_dc_performance requires at

[PATCH 03/16] drm/amd/display: Start documentation of DC

2018-11-29 Thread sunpeng.li
From: David Francis [Why] There are a lot of unintuitive parts of the dm-dc interface. It would help us if these were documented to provide a common understanding of what they are supposed to do [How] Most of this documentation is stubs, to be filled out more thoroughly by the experts Not

[PATCH 11/16] drm/amd/display: Add customizable tracing event

2018-11-29 Thread sunpeng.li
From: Chiawen Huang [why] add customizable log with a message input, which is for adding test log in debugging as printf function in ETW. [Usage] EVENT_LOG_CUST_MSG1("TestLog","Hello World %d=0x%x", 123, pDC); Signed-off-by: Chiawen Huang Reviewed-by: Tony Cheng Acked-by: Leo Li ---

[PATCH 06/16] drm/amd/display: Fix spelling of axis in modules/color/color_gamma.c

2018-11-29 Thread sunpeng.li
From: Krunoslav Kovac Use axis instead of axix Signed-off-by: Krunoslav Kovac Reviewed-by: Aric Cyr Acked-by: Anthony Koo Acked-by: Leo Li --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 01/16] drm/amd/display: fix sporadic multiple aux transaction failure

2018-11-29 Thread sunpeng.li
From: Yogesh Mohan Marimuthu [why] When there are multiple aux transaction in parallel, it is sometime sporadically the aux transaction starts to continuously fail. The aux transaction was failing because the busy bit for the given gpio pin was always set. The busy bit was alway set because the

[PATCH 12/16] drm/amd/display: Copy crc_enabled when duplicating dm_crtc_state

2018-11-29 Thread sunpeng.li
From: Nicholas Kazlauskas [Why] When running igt@kms_plane@pixel-format-pipe-* tests the CRC read will time out and the test will fail. This is because the CRTC is duplicated but the crc_enabled parameter isn't copied over to the new dm_crtc_state. CRC reads will time out because

[PATCH 10/16] drm/amd/display: Re-arrange GFX9 fields

2018-11-29 Thread sunpeng.li
From: Nevenko Stupar For more clear usage in future Signed-off-by: Nevenko Stupar Reviewed-by: Tony Cheng Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_hw_types.h

[PATCH 00/16] DC Patches Nov 29, 2018

2018-11-29 Thread sunpeng.li
From: Leo Li Summary of change: * Initial documentation of DC * Implement tracing in DC * Fix AUX transaction race Chiawen Huang (1): drm/amd/display: Add customizable tracing event David Francis (3): drm/amd/display: Start documentation of DC drm/amd/display: Add tracing to dc

[PATCH 09/16] drm/amd/display: fbc state could not reach while enable fbc

2018-11-29 Thread sunpeng.li
From: hersen wu [WHY] fbc is within the data path from memory to dce. while re-configure mc dmif, fbc should be enabled. otherwise, fbc may not be enabled properly. [HOW] before re-configure mc dmif, disable fbc, only after dmif re-configuration fully done, enable fbc again.

[PATCH 13/16] drm/amd/display: Program dithering if requested

2018-11-29 Thread sunpeng.li
From: SivapiriyanKumarasamy Dithering needs to be enabled or disabled as requested. If dc_stream_update->dither_option is non-null, program the FMT blocks. Signed-off-by: SivapiriyanKumarasamy Reviewed-by: Anthony Koo Reviewed-by: Krunoslav Kovac Acked-by: Leo Li ---

[PATCH 16/16] drm/amd/display: Clean up for DCN1 clock debug logging

2018-11-29 Thread sunpeng.li
From: Fatemeh Darbehani [Why] To prepare for clock debug logging. With the exception of removing max_supported_dppclk_khz from logs, there are no functional changes. [How] Add clk_bypass struct and clean up buffer logic Signed-off-by: Fatemeh Darbehani Reviewed-by: Yongqiang Sun Acked-by: Su

[PATCH 02/16] drm/amd/display: 3.2.07

2018-11-29 Thread sunpeng.li
From: Steven Chiu Signed-off-by: Steven Chiu Reviewed-by: Shahin Khayyer Acked-by: Leo Li --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

Re: [PATCH 04/16] drm/amd/display: Add tracing to dc

2018-11-29 Thread Christian König
Am 29.11.18 um 16:52 schrieb sunpeng...@amd.com: From: David Francis [Why] Tracing is a useful and cheap debug functionality [How] This creates a new trace system amdgpu_dm, currently with three trace events amdgpu_dc_rreg and amdgpu_dc_wreg report the address and value of any dc register

[PATCH] drm/amd/display: Fix NULL dereference when preferred_mode is NULL

2018-11-29 Thread Nicholas Kazlauskas
[Why] When preferred_mode is NULL a null pointer dereference can occur when trying to get the preferred refresh in create_stream_for_sink. [How] Only query preferred_refresh when preferred_mode is not NULL. Consider preferred_refresh if it is since it's only being used to compare to the previous

[PATCH 14/16] drm/amd/display: Allow clock lower on dce100

2018-11-29 Thread sunpeng.li
From: David Francis dce100 was set to always pass safe_to_lower = false to the clock manager Thus, on suspend the clocks were not being set to 0 which is incorrect behaviour This was causing s3 resume to blackscreen on intel CPUs with dce100 GPUs attached (Note that the hash in this Fixes:

Re: [PATCH] drm/amd/display: Fix unintialized max_bpc state values

2018-11-29 Thread Wentland, Harry
On 2018-11-29 10:44 a.m., Nicholas Kazlauskas wrote: > [Why] > If the "max bpc" isn't explicitly set in the atomic state then it > have a value of 0. This has the correct behavior of limiting a panel > to 8bpc in the case where the panel supports 8bpc. In the case of eDP > panels this isn't a true

Re: [PATCH] drm/ttm: fix LRU handling in ttm_buffer_object_transfer

2018-11-29 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Thursday, November 29, 2018 11:20:12 AM To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: mar...@gmail.com Subject: [PATCH] drm/ttm: fix LRU handling in

Re: [PATCH 09/16] drm/amd/display: fbc state could not reach while enable fbc

2018-11-29 Thread Deucher, Alexander
Do you think this will fix this bug? https://bugs.freedesktop.org/show_bug.cgi?id=108577 If so, we can re-enable fbc. Alex From: amd-gfx on behalf of sunpeng...@amd.com Sent: Thursday, November 29, 2018 10:52:16 AM To: amd-gfx@lists.freedesktop.org Cc: Wu,