Re: [PATCH 10/11] drm/syncobj: add timeline signal ioctl for syncobj

2018-12-07 Thread Christian König
Am 07.12.18 um 10:56 schrieb Chunming Zhou: Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 70 ++ include/uapi/drm/drm.h | 1 + 4 files changed, 75

Re: [PATCH 04/10] drm/syncobj: remove drm_syncobj_cb and cleanup

2018-12-07 Thread Daniel Vetter
On Wed, Dec 05, 2018 at 11:00:33AM +0100, Christian König wrote: > Hi Daniel, > > can I get a review for this one? It is essentially just a follow up cleanup > on one of your patches and shouldn't have any functional effect. Unfortunately badly backlogged an a handful of massive context switches

RE: [PATCH 1/3] drm/amdgpu: use HMM mirror callback to replace mmu notifier v6

2018-12-07 Thread Zhou, David(ChunMing)
Even you should rename amdgpu_mn.c/h to amdgpu_hmm.c/h. -David > -Original Message- > From: amd-gfx On Behalf Of Yang, > Philip > Sent: Friday, December 07, 2018 5:03 AM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: [PATCH 1/3] drm/amdgpu: use HMM mirror callback to

Re: [PATCH 04/10] drm/syncobj: remove drm_syncobj_cb and cleanup

2018-12-07 Thread Christian König
Am 07.12.18 um 15:20 schrieb Daniel Vetter: On Wed, Dec 05, 2018 at 11:00:33AM +0100, Christian König wrote: Hi Daniel, can I get a review for this one? It is essentially just a follow up cleanup on one of your patches and shouldn't have any functional effect. Unfortunately badly backlogged

Re: [PATCH 10/11] drm/syncobj: add timeline signal ioctl for syncobj

2018-12-07 Thread Chunming Zhou
在 2018/12/7 19:31, Christian König 写道: > Am 07.12.18 um 10:56 schrieb Chunming Zhou: >> Signed-off-by: Chunming Zhou >> --- >>   drivers/gpu/drm/drm_internal.h |  2 + >>   drivers/gpu/drm/drm_ioctl.c    |  2 + >>   drivers/gpu/drm/drm_syncobj.c  | 70 ++ >>  

Re: [PATCH 09/11] drm/syncobj: add transition iotcls between binary and timeline

2018-12-07 Thread Koenig, Christian
I would rather just use a single IOCTL for this and handle point 0 as distinction if we should add a new point or replace the binary one. Christian. Am 07.12.18 um 10:55 schrieb Chunming Zhou: > we need to import/export timeline point > > Signed-off-by: Chunming Zhou > --- >

Re: [PATCH 10/11] drm/syncobj: add timeline signal ioctl for syncobj

2018-12-07 Thread Koenig, Christian
Am 07.12.18 um 14:09 schrieb Zhou, David(ChunMing): > 在 2018/12/7 19:31, Christian König 写道: >> Am 07.12.18 um 10:56 schrieb Chunming Zhou: >>> Signed-off-by: Chunming Zhou >>> --- >>>   drivers/gpu/drm/drm_internal.h |  2 + >>>   drivers/gpu/drm/drm_ioctl.c    |  2 + >>>  

[PATCH 09/10] drm/syncobj: add timeline signal ioctl for syncobj v2

2018-12-07 Thread Chunming Zhou
v2: individually allocate chain array, since chain node is free independently. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 81 ++ include/uapi/drm/drm.h |

[PATCH 07/10] drm/amdgpu: add timeline support in amdgpu CS v2

2018-12-07 Thread Chunming Zhou
syncobj wait/signal operation is appending in command submission. v2: separate to two kinds in/out_deps functions Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson ---

[PATCH 06/10] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3

2018-12-07 Thread Chunming Zhou
From: Christian König Implement finding the right timeline point in drm_syncobj_find_fence. v2: return -EINVAL when the point is not submitted yet. v3: fix reference counting bug, add flags handling as well Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 43

[PATCH 04/10] drm/syncobj: add support for timeline point wait v8

2018-12-07 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. v3: userspace can specify two kinds waits:: a. Wait for time point to be completed. b. and wait for time point to become available v4: rebase v5: add comment for

[PATCH 05/10] drm/syncobj: add timeline payload query ioctl v4

2018-12-07 Thread Chunming Zhou
user mode can query timeline payload. v2: check return value of copy_to_user v3: handle querying entry by entry v4: rebase on new chain container, simplify interface Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König

[PATCH 03/10] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-07 Thread Chunming Zhou
From: Christian König Use the dma_fence_chain object to create a timeline of fence objects instead of just replacing the existing fence. v2: rebase and cleanup Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 37 +++ include/drm/drm_syncobj.h

[PATCH 02/10] drm/syncobj: remove drm_syncobj_cb and cleanup

2018-12-07 Thread Chunming Zhou
From: Christian König This completes "drm/syncobj: Drop add/remove_callback from driver interface" and cleans up the implementation a bit. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 91 --- include/drm/drm_syncobj.h | 21 2

Re: [PATCH 04/16 v2] drm/amd/display: Add tracing to dc

2018-12-07 Thread Wentland, Harry
On 2018-12-07 9:41 a.m., Wentland, Harry wrote: > On 2018-12-07 12:40 a.m., Kuehling, Felix wrote: >> This change seems to be breaking the build for me. I'm getting errors like >> this: >> >> CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.o >> In file included from

Re: [PATCH 04/16 v2] drm/amd/display: Add tracing to dc

2018-12-07 Thread Wentland, Harry
On 2018-12-07 12:40 a.m., Kuehling, Felix wrote: > This change seems to be breaking the build for me. I'm getting errors like > this: > >CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.o > In file included from ../include/trace/events/tlb.h:9:0, > from

Re: [PATCH v2] drm/amdgpu/powerplay: Apply avfs cks-off voltages on VI

2018-12-07 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Kenneth Feng Sent: Friday, December 7, 2018 1:13:20 AM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH v2] drm/amdgpu/powerplay: Apply avfs cks-off voltages on VI Instead of EVV cks-off

[PATCH] Revert "drm/amd/display: Set RMX_ASPECT as default"

2018-12-07 Thread Nicholas Kazlauskas
This reverts commit 91b66c47ba3468f7882ea4a84d5e0e0c186b638f. Forcing RMX_ASPECT as default uses the preferred/native mode's timings for any mode the user selects and scales the image. This provides a a consistently nicer result in the case where the selected mode's refresh rate matches the

[PATCH 01/10] dma-buf: add new dma_fence_chain container v4

2018-12-07 Thread Chunming Zhou
From: Christian König Lockless container implementation similar to a dma_fence_array, but with only two elements per node and automatic garbage collection. v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno, drop prev reference during garbage collection if it's

[PATCH] drm/amdgpu/powerplay: Add special avfs cases for some polaris asics (v3)

2018-12-07 Thread Alex Deucher
Add special avfs handling for some polaris variants. v2: fix copy paste typo. v3: fix asic rid check Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/smumgr/polaris10_smumgr.c| 54 ++ 1 file changed, 54 insertions(+) diff --git

[PATCH] drm/amd/display: Fix duplicating scaling/underscan connector state

2018-12-07 Thread Nicholas Kazlauskas
[Why] These properties aren't being carried over when the atomic state. This tricks atomic check and commit tail into performing underscan and scaling operations when they aren't needed. With the patch that forced scaling/RMX_ASPECT on by default this results in many unnecessary surface updates

[PATCH libdrm 4/7] wrap syncobj timeline query/wait APIs for amdgpu v3

2018-12-07 Thread Chunming Zhou
v2: symbos are stored in lexical order. v3: drop export/import and extra query indirection Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 39 ++ amdgpu/amdgpu_cs.c | 23

[PATCH libdrm 2/7] addr cs chunk for syncobj timeline

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 1ceec56d..a3c067dd 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -517,6 +517,8 @@ struct

[PATCH libdrm 6/7] expose timeline signal/export/import interfaces v2

2018-12-07 Thread Chunming Zhou
v2: adapt to new one transfer ioctl Signed-off-by: Chunming Zhou --- amdgpu/amdgpu-symbol-check | 3 ++ amdgpu/amdgpu.h| 51 +++ amdgpu/amdgpu_cs.c | 62 ++ 3 files changed, 116 insertions(+) diff --git

[PATCH libdrm 5/7] add timeline signal/transfer ioctls v2

2018-12-07 Thread Chunming Zhou
v2: use one transfer ioctl Signed-off-by: Chunming Zhou --- xf86drm.c | 33 + xf86drm.h | 6 ++ 2 files changed, 39 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 9816b3b2..2a089616 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4278,6 +4278,21 @@

[PATCH libdrm 7/7] add syncobj timeline tests v3

2018-12-07 Thread Chunming Zhou
v2: drop DRM_SYNCOBJ_CREATE_TYPE_TIMELINE, fix timeout calculation, fix some warnings v3: add export/import and cpu signal testing cases Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- tests/amdgpu/Makefile.am | 3 +- tests/amdgpu/amdgpu_test.c | 12 ++

[PATCH libdrm 3/7] add timeline wait/query ioctl v2

2018-12-07 Thread Chunming Zhou
v2: drop export/import Signed-off-by: Chunming Zhou --- xf86drm.c | 44 xf86drm.h | 6 ++ 2 files changed, 50 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 71ad54ba..9816b3b2 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4277,3 +4277,47

Re: [PATCH 2/2] drm/sched: Rework HW fence processing.

2018-12-07 Thread Koenig, Christian
Am 07.12.18 um 16:22 schrieb Grodzovsky, Andrey: > > On 12/07/2018 03:19 AM, Christian König wrote: >> Am 07.12.18 um 04:18 schrieb Zhou, David(ChunMing): -Original Message- From: dri-devel On Behalf Of Andrey Grodzovsky Sent: Friday, December 07, 2018 1:41 AM To:

Re: [PATCH 2/2] drm/sched: Rework HW fence processing.

2018-12-07 Thread Grodzovsky, Andrey
On 12/07/2018 03:19 AM, Christian König wrote: > Am 07.12.18 um 04:18 schrieb Zhou, David(ChunMing): >> >>> -Original Message- >>> From: dri-devel On Behalf Of >>> Andrey Grodzovsky >>> Sent: Friday, December 07, 2018 1:41 AM >>> To: dri-de...@lists.freedesktop.org;

[PATCH 10/10] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 8de55f7f1a3a..cafafdb1d03f 100644 ---

[PATCH] drm/amdgpu/powerplay: Add special avfs cases for some polaris asics (v2)

2018-12-07 Thread Alex Deucher
Add special avfs handling for some polaris variants. v2: fix copy paste typo. Signed-off-by: Alex Deucher --- .../drm/amd/powerplay/smumgr/polaris10_smumgr.c| 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c

[PATCH 08/10] drm/syncobj: add transition iotcls between binary and timeline v2

2018-12-07 Thread Chunming Zhou
we need to import/export timeline point. v2: unify to one transfer ioctl Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 79 ++ include/uapi/drm/drm.h | 10

[PATCH libdrm 1/7] new syncobj extension v3

2018-12-07 Thread Chunming Zhou
v2: drop not implemented IOCTLs and flags v3: add transfer/signal ioctls Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- include/drm/drm.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index

Re: [PATCH] drm/amd/display: Fix duplicating scaling/underscan connector state

2018-12-07 Thread Alex Deucher
Acked-by: Alex Deucher On Fri, Dec 7, 2018 at 10:07 AM Nicholas Kazlauskas wrote: > > [Why] > These properties aren't being carried over when the atomic state. > This tricks atomic check and commit tail into performing underscan > and scaling operations when they aren't needed. > > With the

Re: [PATCH] Revert "drm/amd/display: Set RMX_ASPECT as default"

2018-12-07 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Nicholas Kazlauskas Sent: Friday, December 7, 2018 12:15:01 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo); Wentland, Harry; Lakha, Bhawanpreet; Kazlauskas, Nicholas Subject: [PATCH] Revert

[PATCH] drm/sched: Always trace the dependencies we wait on, to fix a race.

2018-12-07 Thread Eric Anholt
The entity->dependency can go away completely once we've called drm_sched_entity_add_dependency_cb() (if the cb is called before we get around to tracing). The tracepoint is more useful if we trace every dependency instead of just ones that get callbacks installed, anyway, so just do that. Fixes

Re: [PATCH] drm/sched: Always trace the dependencies we wait on, to fix a race.

2018-12-07 Thread Koenig, Christian
Am 07.12.18 um 20:16 schrieb Eric Anholt: > The entity->dependency can go away completely once we've called > drm_sched_entity_add_dependency_cb() (if the cb is called before we > get around to tracing). The tracepoint is more useful if we trace > every dependency instead of just ones that get

Re: [PATCH 04/16 v2] drm/amd/display: Add tracing to dc

2018-12-07 Thread Kuehling, Felix
On 2018-12-07 9:46 a.m., Wentland, Harry wrote: > On 2018-12-07 9:41 a.m., Wentland, Harry wrote: >> On 2018-12-07 12:40 a.m., Kuehling, Felix wrote: >>> This change seems to be breaking the build for me. I'm getting errors like >>> this: >>> >>> CC [M]

[PATCH 2/2] drm/amdgpu: add some additional vega20 pci ids

2018-12-07 Thread Alex Deucher
New vega ids. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index e32f6f43a46b..9c77eaa45982 100644 ---

[PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids

2018-12-07 Thread Alex Deucher
New vega ids. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 90f474f98b6e..e32f6f43a46b 100644

Re: [PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids

2018-12-07 Thread Kuehling, Felix
Can you add them amdkfd/kfd_device.c as well while you're at it. Thanks,   Felix On 2018-12-07 4:03 p.m., Alex Deucher wrote: > New vega ids. > > Signed-off-by: Alex Deucher > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ > 1 file changed, 6

[PATCH 2/2] drm/amdkfd: add new vega20 pci id

2018-12-07 Thread Alex Deucher
New vega20 id. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index b78b3c2fa9d8..8be9677c0c07 100644 ---

[PATCH 1/2] drm/amdkfd: add new vega10 pci ids

2018-12-07 Thread Alex Deucher
New vega10 ids. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c index 9ed14a11afa2..b78b3c2fa9d8 100644

[PATCH] drm/amdgpu: Workaround build failure due to trace conflict

2018-12-07 Thread Kuehling, Felix
Avoid including mmu_context.h in amdgpu_amdkfd.h since that may be included in other header files that define traces. This leads to conflicts due to traces defined in other headers included via mmu_context.h. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h|

[pull] amdgpu, amdkfd, ttm, scheduler drm-next-4.21

2018-12-07 Thread Alex Deucher
Hi Dave, More features for 4.21: amdgpu: - DC trace support - More DC documentation - XGMI hive reset support - Rework IH interaction with KFD - Misc fixes and cleanups amdkfd: - Limit vram overcommit - dmabuf support - Support for doorbell BOs ttm: - Support for simultaneous submissions to

Re: [PATCH] drm/amdgpu: Workaround build failure due to trace conflict

2018-12-07 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, December 7, 2018 5:07 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: [PATCH] drm/amdgpu: Workaround build failure due to trace conflict Avoid including

Re: [PATCH 1/2] drm/amdkfd: add new vega10 pci ids

2018-12-07 Thread Deucher, Alexander
Care to review the amdgpu series as well? From: amd-gfx on behalf of Kuehling, Felix Sent: Friday, December 7, 2018 4:38:20 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; sta...@vger.kernel.org Subject: Re: [PATCH 1/2] drm/amdkfd:

Re: [PATCH 1/2] drm/amdkfd: add new vega10 pci ids

2018-12-07 Thread Kuehling, Felix
On 2018-12-07 4:26 p.m., Alex Deucher wrote: > New vega10 ids. > > Signed-off-by: Alex Deucher The series is Reviewed-by: Felix Kuehling > Cc: sta...@vger.kernel.org > --- > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids

2018-12-07 Thread Kuehling, Felix
Thanks. I see you added the KFD change in a separate patch series. This one is also Reviewed-by: Felix Kuehling On 2018-12-07 4:16 p.m., Deucher, Alexander wrote: > > Will do. > > > Alex > > > *From:* Kuehling, Felix >

Re: [PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids

2018-12-07 Thread Deucher, Alexander
Will do. Alex From: Kuehling, Felix Sent: Friday, December 7, 2018 4:14:39 PM To: Alex Deucher; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; sta...@vger.kernel.org Subject: Re: [PATCH 1/2] drm/amdgpu: add some additional vega10 pci ids Can you add them

[PATCH i-g-t] igt: add timeline test cases v2

2018-12-07 Thread Chunming Zhou
v2: adapt to new transfer ioctl Signed-off-by: Chunming Zhou --- include/drm-uapi/drm.h | 33 ++ lib/igt_syncobj.c| 206 lib/igt_syncobj.h| 19 + tests/meson.build|1 + tests/syncobj_timeline.c | 1051 ++ 5 files

Re: [PATCH 1/2] drm/amdgpu: update SMC firmware image for polaris10 variants

2018-12-07 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Junwei Zhang Sent: Friday, December 7, 2018 2:19:51 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH 1/2] drm/amdgpu: update SMC firmware image for polaris10 variants Some

[PATCH 01/11] dma-buf: make fence sequence numbers 64 bit v2

2018-12-07 Thread Chunming Zhou
From: Christian König For a lot of use cases we need 64bit sequence numbers. Currently drivers overload the dma_fence structure to store the additional bits. Stop doing that and make the sequence number in the dma_fence always 64bit. For compatibility with hardware which can do only 32bit

[PATCH 02/11] dma-buf: add new dma_fence_chain container v4

2018-12-07 Thread Chunming Zhou
From: Christian König Lockless container implementation similar to a dma_fence_array, but with only two elements per node and automatic garbage collection. v2: properly document dma_fence_chain_for_each, add dma_fence_chain_find_seqno, drop prev reference during garbage collection if it's

[PATCH 05/11] drm/syncobj: add support for timeline point wait v8

2018-12-07 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. v3: userspace can specify two kinds waits:: a. Wait for time point to be completed. b. and wait for time point to become available v4: rebase v5: add comment for

[PATCH 07/11] drm/syncobj: use the timeline point in drm_syncobj_find_fence v3

2018-12-07 Thread Chunming Zhou
From: Christian König Implement finding the right timeline point in drm_syncobj_find_fence. v2: return -EINVAL when the point is not submitted yet. v3: fix reference counting bug, add flags handling as well Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 43

[PATCH 10/11] drm/syncobj: add timeline signal ioctl for syncobj

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 70 ++ include/uapi/drm/drm.h | 1 + 4 files changed, 75 insertions(+) diff --git

[PATCH 09/11] drm/syncobj: add transition iotcls between binary and timeline

2018-12-07 Thread Chunming Zhou
we need to import/export timeline point Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 4 +++ drivers/gpu/drm/drm_ioctl.c| 6 drivers/gpu/drm/drm_syncobj.c | 66 ++ include/uapi/drm/drm.h | 10 ++ 4 files changed, 86

[PATCH 06/11] drm/syncobj: add timeline payload query ioctl v4

2018-12-07 Thread Chunming Zhou
user mode can query timeline payload. v2: check return value of copy_to_user v3: handle querying entry by entry v4: rebase on new chain container, simplify interface Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König

[PATCH 04/11] drm/syncobj: add new drm_syncobj_add_point interface v2

2018-12-07 Thread Chunming Zhou
From: Christian König Use the dma_fence_chain object to create a timeline of fence objects instead of just replacing the existing fence. v2: rebase and cleanup Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 37 +++ include/drm/drm_syncobj.h

[PATCH 03/11] drm/syncobj: remove drm_syncobj_cb and cleanup

2018-12-07 Thread Chunming Zhou
From: Christian König This completes "drm/syncobj: Drop add/remove_callback from driver interface" and cleans up the implementation a bit. Signed-off-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 91 --- include/drm/drm_syncobj.h | 21 2

[PATCH 11/11] drm/amdgpu: update version for timeline syncobj support in amdgpu

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 8de55f7f1a3a..cafafdb1d03f 100644 ---

[PATCH 08/11] drm/amdgpu: add timeline support in amdgpu CS v2

2018-12-07 Thread Chunming Zhou
syncobj wait/signal operation is appending in command submission. v2: separate to two kinds in/out_deps functions Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuizen Cc: Dave Airlie Cc: Christian König Cc: Chris Wilson ---

[PATCH libdrm 1/7] new syncobj extension v2

2018-12-07 Thread Chunming Zhou
v2: drop not implemented IOCTLs and flags Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- include/drm/drm.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index 85c685a2..9ef6b9d0 100644 ---

[PATCH libdrm 5/7] add timeline signal/transfer ioctls

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- xf86drm.c | 49 + xf86drm.h | 8 2 files changed, 57 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 9816b3b2..9cf01d38 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4278,6 +4278,21 @@ drm_public int

[PATCH libdrm 3/7] add timeline wait/query ioctl v2

2018-12-07 Thread Chunming Zhou
v2: drop export/import Signed-off-by: Chunming Zhou --- xf86drm.c | 44 xf86drm.h | 6 ++ 2 files changed, 50 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index 71ad54ba..9816b3b2 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4277,3 +4277,47

[PATCH libdrm 4/7] wrap syncobj timeline query/wait APIs for amdgpu v3

2018-12-07 Thread Chunming Zhou
v2: symbos are stored in lexical order. v3: drop export/import and extra query indirection Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 39 ++ amdgpu/amdgpu_cs.c | 23

[PATCH libdrm 2/7] addr cs chunk for syncobj timeline

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 1ceec56d..a3c067dd 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -517,6 +517,8 @@ struct

[PATCH libdrm 6/7] expose timeline signal/export/import interfaces

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- amdgpu/amdgpu-symbol-check | 3 ++ amdgpu/amdgpu.h| 51 +++ amdgpu/amdgpu_cs.c | 61 ++ 3 files changed, 115 insertions(+) diff --git a/amdgpu/amdgpu-symbol-check

[PATCH libdrm 7/7] add syncobj timeline tests v3

2018-12-07 Thread Chunming Zhou
v2: drop DRM_SYNCOBJ_CREATE_TYPE_TIMELINE, fix timeout calculation, fix some warnings v3: add export/import and cpu signal testing cases Signed-off-by: Chunming Zhou Signed-off-by: Christian König --- tests/amdgpu/Makefile.am | 3 +- tests/amdgpu/amdgpu_test.c | 12 ++

[PATCH i-g-t] igt: add timeline test cases

2018-12-07 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm-uapi/drm.h | 33 ++ lib/igt_syncobj.c| 204 +++ lib/igt_syncobj.h| 19 + tests/meson.build|1 + tests/syncobj_timeline.c | 1100 ++ 5 files changed, 1357 insertions(+) create

Re: [PATCH 2/2] drm/sched: Rework HW fence processing.

2018-12-07 Thread Christian König
Am 07.12.18 um 04:18 schrieb Zhou, David(ChunMing): -Original Message- From: dri-devel On Behalf Of Andrey Grodzovsky Sent: Friday, December 07, 2018 1:41 AM To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; ckoenig.leichtzumer...@gmail.com; e...@anholt.net;

Re: [PATCH 2/2] drm/amdgpu: update MC firmware image for polaris10 variants

2018-12-07 Thread Zhang, Jerry(Junwei)
we can drop MC update patch, since a new fw could fix that. Regards, Jerry On 12/7/18 3:19 PM, Junwei Zhang wrote: Some new variants require different firmwares. Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)