Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2019-01-11 Thread Koenig, Christian
Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: > [SNIP] But we will not be adding the cb back in drm_sched_stop anymore, now we are only going to add back the cb in drm_sched_startr after rerunning those jobs in drm_sched_resubmit_jobs and assign them a new parent there

[PATCH] drm/ttm: stop always moving BOs on the LRU on page fault

2019-01-11 Thread Christian König
Move the BO on the LRU only when it is actually moved by a DMA operation. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c

Re: [PATCH] drm/ttm: stop always moving BOs on the LRU on page fault

2019-01-11 Thread Michel Dänzer
On 2019-01-11 2:15 p.m., Christian König wrote: > Move the BO on the LRU only when it is actually moved by a DMA > operation. > > Signed-off-by: Christian König Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast

[PATCH] Revert "drm/amdgpu: validate user pitch alignment"

2019-01-11 Thread Michel Dänzer
From: Michel Dänzer The check turned out to be too strict in some cases. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c

Re: [PATCH] drm/ttm: stop always moving BOs on the LRU on page fault

2019-01-11 Thread Michel Dänzer
On 2019-01-11 2:15 p.m., Christian König wrote: > Move the BO on the LRU only when it is actually moved by a DMA > operation. > > [...] > > @@ -177,6 +175,13 @@ static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf) > ret = VM_FAULT_SIGBUS; > goto

Re: BISECTED- amd-staging-drm-next, xorg-server segfault A6-6310 APU - R4 Mullins.

2019-01-11 Thread Michel Dänzer
On 2019-01-10 6:56 p.m., Przemek Socha wrote: > > [ 147.846148] [drm:amdgpu_display_user_framebuffer_create [amdgpu]] Invalid > pitch: expecting 10752 but got 10624 > [ 147.846155] [drm:drm_internal_framebuffer_create] could not create > framebuffer" Thanks, this confirms that the check is

RE: [PATCH] drm/amd/display: Remove error message in stream create routine

2019-01-11 Thread Zuo, Jerry
OK. Got you. Thanks. -Original Message- From: Lyude Paul Sent: January 10, 2019 6:07 PM To: Zuo, Jerry ; Wentland, Harry Subject: Re: [PATCH] drm/amd/display: Remove error message in stream create routine On Thu, 2019-01-10 at 22:17 +, Zuo, Jerry wrote: > Thanks for your

Re: [PATCH] drm/amd/display: Only get the connector state for VRR when toggled

2019-01-11 Thread Li, Sun peng (Leo)
On 2019-01-10 3:12 p.m., Nicholas Kazlauskas wrote: > [Why] > This fixes a stuttering issue that occurs when moving a hardware cursor > when VRR is enabled. > > Previously when VRR is enabled atomic check will grab the connector > state for every atomic update. This has to lock the connector in

Re: [PATCH] Revert "drm/amdgpu: validate user pitch alignment"

2019-01-11 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Friday, January 11, 2019 10:22:07 AM To: amd-gfx@lists.freedesktop.org Cc: Yu Zhao Subject: [PATCH] Revert "drm/amdgpu: validate user pitch alignment" From: Michel Dänzer The check

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2019-01-11 Thread Grodzovsky, Andrey
On 01/11/2019 04:42 AM, Koenig, Christian wrote: > Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: >> [SNIP] > But we will not be adding the cb back in drm_sched_stop anymore, now we > are only going to add back the cb in drm_sched_startr after rerunning > those jobs in

[PATCH] drm/amd/display: Fully remove i2caux folder

2019-01-11 Thread sunpeng.li
From: Leo Li This is a follow up to: e28e1490794d ("drm/amd/display: Remove i2caux folder") Some files were still left, so delete all of them. CC: David Francis CC: Harry Wentland Signed-off-by: Leo Li --- drivers/gpu/drm/amd/display/dc/i2caux/Makefile | 99

Re: [PATCH] drm/ttm: stop always moving BOs on the LRU on page fault

2019-01-11 Thread Christian König
Am 11.01.19 um 15:17 schrieb Michel Dänzer: On 2019-01-11 2:15 p.m., Christian König wrote: Move the BO on the LRU only when it is actually moved by a DMA operation. [...] @@ -177,6 +175,13 @@ static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf) ret =

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2019-01-11 Thread Koenig, Christian
Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: > > On 01/11/2019 04:42 AM, Koenig, Christian wrote: >> Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: >>> [SNIP] >> But we will not be adding the cb back in drm_sched_stop anymore, now we >> are only going to add back the cb in

Re: [PATCH v5 1/2] drm/sched: Refactor ring mirror list handling.

2019-01-11 Thread Grodzovsky, Andrey
On 01/11/2019 02:11 PM, Koenig, Christian wrote: > Am 11.01.19 um 16:37 schrieb Grodzovsky, Andrey: >> On 01/11/2019 04:42 AM, Koenig, Christian wrote: >>> Am 10.01.19 um 16:56 schrieb Grodzovsky, Andrey: [SNIP] >>> But we will not be adding the cb back in drm_sched_stop anymore, now we

pitch alignment questions

2019-01-11 Thread Yu Zhao
On Fri, Jan 11, 2019 at 04:27:44PM +0100, Michel Dänzer wrote: > On 2019-01-10 6:56 p.m., Przemek Socha wrote: > > > > [ 147.846148] [drm:amdgpu_display_user_framebuffer_create [amdgpu]] > > Invalid > > pitch: expecting 10752 but got 10624 > > [ 147.846155]

Re: [PATCH 1/3] drm/amdgpu: enable IH ring 1 and ring 2 v3

2019-01-11 Thread Alex Deucher
On Wed, Jan 9, 2019 at 8:12 AM Christian König wrote: > > The entries are ignored for now, but it at least stops crashing the > hardware when somebody tries to push something to the other IH rings. > > v2: limit ring size, add TODO comment > v3: only program rings if they are actually allocated >