Re: [PATCH v2 5/7] mm/hmm: make full use of walk_page_range()

On Thu, Jul 25, 2019 at 05:56:48PM -0700, Ralph Campbell wrote: > hmm_range_fault() calls find_vma() and walk_page_range() in a loop. > This is unnecessary duplication since walk_page_range() calls find_vma() > in a loop already. > Simplify hmm_range_fault() by defining a walk_test() callback

[PATCH] drm/amdkfd: remove set but not used variable 'pdd'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c: In function restore_process_worker: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:949:29: warning: variable pdd set but not used [-Wunused-but-set-variable] It is not used since commit

[PATCH v6 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 649515868f86..5bbfaa2cd0f4

[PATCH v6 13/24] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index a50f5a1f09b8..b98a1420dcd3

[PATCH v6 14/24] drm: zte: Provide ddc symlink in vga connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index 9b67e419280c..c4fa3bbaba78

[PATCH v6 15/24] drm/tilcdc: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index

[PATCH v6 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index

[PATCH] drm/amdkfd: Remove GPU ID in GWS queue creation

The gpu_id argument is not needed when enabling GWS on a queue. The queue can only be associated with one device, so the only possible situations for the call as previously defined were: 1) the gpu_id was for the device associated with the target queue and things worked as expected, or 2) the

Re: [PATCH 1/2] drm/amdgpu/gfx10: update golden settings for navi14

Reviewed-by: Xiaojie Yuan BR, Xiaojie From: amd-gfx on behalf of Alex Deucher Sent: Saturday, July 27, 2019 3:16 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/2] drm/amdgpu/gfx10: update golden settings for navi14

Re: [PATCH v5 01/24] drm: Include ddc adapter pointer in struct drm_connector

Hi Andrzej. After reading through the series a few more comments. 1) The subject of this patch could be improved. Consider something like: drm: add ddc link in sysfs created by drm_connector This spells out much better what the patch achieve. 2) The purpsoe of drm_connector.ddc is to

Re: [PATCH v5 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

On 2019-07-26 9:11 a.m., Christian König wrote: > Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: >> Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in >> amdgpu_bo_do_create into standalone helper so it can be reused >> in other functions. >> >> v4: >> Switch to return bool. >> >> v5: Fix

Re: [PATCH v5 02/24] drm: Add drm_connector_init() variant with ddc

Hi Andrzej. On Wed, Jul 24, 2019 at 03:59:24PM +0200, Andrzej Pietrasiewicz wrote: > Allow passing ddc adapter pointer to the init function. Even if > drm_connector_init() sometime in the future decides to e.g. memset() all > connector fields to zeros, the newly added function ensures that at its

Re: [PATCH v5 01/24] drm: Include ddc adapter pointer in struct drm_connector

Hi Andrzej. Patch looks good, but one kernel-doc detail. On Wed, Jul 24, 2019 at 03:59:23PM +0200, Andrzej Pietrasiewicz wrote: > Add generic code which creates symbolic links in sysfs, pointing to ddc > interface used by a particular video output. For example: > > ls -l

Re: [PATCH 1/4] drm/radeon: Fill out gem_object->resv

Am 25.07.19 um 15:26 schrieb Daniel Vetter: > That way we can ditch our gem_prime_res_obj implementation. Since ttm > absolutely needs the right reservation object all the boilerplate is > already there and we just have to wire it up correctly. > > Note that gem/prime doesn't care when we do this,

Re: [PATCH v5 4/4] drm/amd/display: enable S/G for RAVEN chip

Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: From: Shirish S enables gpu_vm_support in dm and adds AMDGPU_GEM_DOMAIN_GTT as supported domain v2: Move BO placement logic into amdgpu_display_supported_domains v3: Use amdgpu_bo_validate_uswc in amdgpu_display_supported_domains. v4:

[PATCH] drm/amd/display: remove duplicated include from dc_link.c

Remove duplicated include. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index

Re: [PATCH v5 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in amdgpu_bo_do_create into standalone helper so it can be reused in other functions. v4: Switch to return bool. v5: Fix typos. Signed-off-by: Andrey Grodzovsky ---

Re: [PATCH 1/2] drm/amd/amdgpu/vcn_v2_0: Mark RB commands as KMD commands

Am 25.07.19 um 17:52 schrieb Thai, Thong: Sets the CMD_SOURCE bit for VCN 2.0 Decoder Ring Buffer commands. This bit was previously set by the RBC HW on older firmware. Newer firmware uses a SW RBC and this bit has to be set by the driver. Mhm, another question came to my mind: Would it now be

Re: [PATCH v5 4/4] drm/amd/display: enable S/G for RAVEN chip

On 2019-07-26 9:14 a.m., Christian König wrote: > Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: >> From: Shirish S >> >> enables gpu_vm_support in dm and adds >> AMDGPU_GEM_DOMAIN_GTT as supported domain >> >> v2: >> Move BO placement logic into amdgpu_display_supported_domains >> >> v3: >> Use

Re: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

@Deucher, Alexander Hi Alex, it seems not application will use this sysfs, can we rename it from "ppfeatures" to "pp_features"? this patch sets is pending. Best Regards, Kevin From: StDenis, Tom Sent: Thursday, July 25, 2019

Re: [PATCH 1/2] drm/amd/amdgpu/vcn_v2_0: Mark RB commands as KMD commands

Well, not through this particular piece of code, since this explicitly sets it. But I would imagine someone could set the bit in userspace and insert KMD commands in the BO as part of some IB instructions - I’ll have a look. From: Christian König Sent: Friday,

Re: [PATCH 1/2] drm/amd/amdgpu/vcn_v2_0: Mark RB commands as KMD commands

Good point, this patch is Reviewed-by: Christian König . But please ping the firmware guys if that really could be an issue, Christian. Am 26.07.19 um 12:45 schrieb Thai, Thong: Well, not through this particular piece of code, since this explicitly sets it. But I would imagine someone could

Re: [PATCH v5 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

Am 26.07.19 um 10:54 schrieb Michel Dänzer: On 2019-07-26 9:11 a.m., Christian König wrote: Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in amdgpu_bo_do_create into standalone helper so it can be reused in other functions. v4: Switch

Re: [PATCH v5 01/24] drm: Include ddc adapter pointer in struct drm_connector

Hi Sam, W dniu 26.07.2019 o 08:37, Sam Ravnborg pisze: Hi Andrzej. Patch looks good, but one kernel-doc detail. Thanks, I will address both issues you found, in v6. Andrzej ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org

Re: [PATCH v5 4/4] drm/amd/display: enable S/G for RAVEN chip

Totally agree, me or Shirish will add a new patch for this as I've already commuted the series. Andrey On 7/26/19 5:03 AM, Michel Dänzer wrote: > On 2019-07-26 9:14 a.m., Christian König wrote: >> Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: >>> From: Shirish S >>> >>> enables

RE: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

I am fine to align the interface name if no user mode use. Acked-by: Huang Rui From: Wang, Kevin(Yang) Sent: Friday, July 26, 2019 5:05 PM To: StDenis, Tom ; Deucher, Alexander ; Huang, Ray ; Quan, Evan ; amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Feng, Kenneth Subject: Re: [PATCH

RE: [PATCH 11/11] drm/amdgpu: put the SMC into the proper state on reset/unload

I think it's OK to leave the S3 and BACO as they were for now. Series is reviewed-by Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, July 26, 2019 11:22 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 11/11]

RE: [PATCH] drm/amdgpu/powerplay: use proper revision id for navi

Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, July 26, 2019 12:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu/powerplay: use proper revision id for navi > > The PCI revision id

[PATCH] drm/amdgpu: Fix amdgpu_display_supported_domains logic.

Add restriction to dissallow GTT domain if the relevant BO doesn't have USWC flag set to avoid the APU hang scenario. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 16 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 3 ++-

Re: [PATCH v2 5/7] mm/hmm: make full use of walk_page_range()

Looks good: Reviewed-by: Christoph Hellwig ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v2 6/7] mm/hmm: remove hugetlbfs check in hmm_vma_walk_pmd

On Thu, Jul 25, 2019 at 05:56:49PM -0700, Ralph Campbell wrote: > walk_page_range() will only call hmm_vma_walk_hugetlb_entry() for > hugetlbfs pages and doesn't call hmm_vma_walk_pmd() in this case. > Therefore, it is safe to remove the check for vma->vm_flags & VM_HUGETLB > in

Re: [PATCH v2 2/7] mm/hmm: a few more C style and comment clean ups

Note: it seems like you've only CCed me on patches 2-7, but not on the cover letter and patch 1. I'll try to find them later, but to make Ccs useful they should normally cover the whole series. Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig

Re: [PATCH v2 7/7] mm/hmm: remove hmm_range vma

On Thu, Jul 25, 2019 at 05:56:50PM -0700, Ralph Campbell wrote: > Since hmm_range_fault() doesn't use the struct hmm_range vma field, > remove it. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Ralph Campbell Looks good, Reviewed-by: Christoph Hellwig

[PATCH AUTOSEL 5.2 40/85] drm/amd/display: Expose audio inst from DC to DM

From: Nicholas Kazlauskas [ Upstream commit 5fdb7c4c7f2691efd760b0b0dc00da4a3699f1a6 ] [Why] In order to give pin notifications to the sound driver from DM we need to know whether audio is enabled on a stream and what pin it's using from DC. [How] Expose the instance via stream status if it's

Re: [PATCH] drm/amdgpu: Fix amdgpu_display_supported_domains logic.

Am 26.07.19 um 15:28 schrieb Andrey Grodzovsky: Add restriction to dissallow GTT domain if the relevant BO doesn't have USWC flag set to avoid the APU hang scenario. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 16

Re: [PATCH v5 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

Am 26.07.19 um 16:53 schrieb Michel Dänzer: On 2019-07-26 1:55 p.m., Christian König wrote: Am 26.07.19 um 10:54 schrieb Michel Dänzer: On 2019-07-26 9:11 a.m., Christian König wrote: Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in

[PATCH v6 24/24] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c

[PATCH v6 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index

[PATCH v6 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Re: [PATCH v2 0/7] mm/hmm: more HMM clean up

On Thu, Jul 25, 2019 at 05:56:43PM -0700, Ralph Campbell wrote: > Here are seven more patches for things I found to clean up. > This was based on top of Christoph's seven patches: > "hmm_range_fault related fixes and legacy API removal v3". > I assume this will go into Jason's tree since there

[PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 ++- 1 file changed, 70 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

[PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- 1 file changed, 106 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c

[PATCH] drm/amdgpu/display: fix the build without CONFIG_DRM_AMD_DC_DSC_SUPPORT

Some code was missing the CONFIG_DRM_AMD_DC_DSC_SUPPORT guard. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c

Re: [PATCH v5 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

On 2019-07-26 6:02 p.m., Christian König wrote: > Am 26.07.19 um 16:53 schrieb Michel Dänzer: >> On 2019-07-26 1:55 p.m., Christian König wrote: >>> Am 26.07.19 um 10:54 schrieb Michel Dänzer: On 2019-07-26 9:11 a.m., Christian König wrote: > Am 25.07.19 um 16:24 schrieb Andrey

Re: [PATCH v2 2/7] mm/hmm: a few more C style and comment clean ups

On 7/25/19 11:23 PM, Christoph Hellwig wrote: Note: it seems like you've only CCed me on patches 2-7, but not on the cover letter and patch 1. I'll try to find them later, but to make Ccs useful they should normally cover the whole series. Otherwise this looks fine to me: Reviewed-by:

Re: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

Sure. Alex From: Wang, Kevin(Yang) Sent: Friday, July 26, 2019 5:05 AM To: StDenis, Tom ; Deucher, Alexander ; Huang, Ray ; Quan, Evan ; amd-gfx@lists.freedesktop.org ; Zhang, Hawking Cc: Feng, Kenneth Subject: Re: [PATCH 5/5] drm/amd/powerplay: implment

Re: [PATCH] drm/amdgpu/display: fix the build without CONFIG_DRM_AMD_DC_DSC_SUPPORT

On 7/26/19 12:09 PM, Alex Deucher wrote: > Some code was missing the CONFIG_DRM_AMD_DC_DSC_SUPPORT guard. > > Signed-off-by: Alex Deucher Reviewed-by: Nicholas Kazlauskas We probably want to drop this and the DCN2 guard eventually though. Nicholas Kazlauskas > --- >

[PATCH v6 08/24] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index

[PATCH v6 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index de62a4cd4827..db461b6a257f

[PATCH v6 12/24] drm/vc4: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index

[PATCH v6 07/24] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

[PATCH v6 05/24] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index

[PATCH v6 09/24] drm/tegra: Provide ddc symlink in output connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/hdmi.c | 7 --- drivers/gpu/drm/tegra/sor.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c

[PATCH v6 06/24] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c

Re: [PATCH v5 2/4] drm/amdgpu: Create helper to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC

On 2019-07-26 1:55 p.m., Christian König wrote: > Am 26.07.19 um 10:54 schrieb Michel Dänzer: >> On 2019-07-26 9:11 a.m., Christian König wrote: >>> Am 25.07.19 um 16:24 schrieb Andrey Grodzovsky: Move the logic to clear AMDGPU_GEM_CREATE_CPU_GTT_USWC in amdgpu_bo_do_create into

[PATCH v6 04/24] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c

[PATCH v6 00/24] Associate ddc adapters with connectors

It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42

[PATCH v6 03/24] drm/exynos: Provide ddc symlink in connector's sysfs

Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index

[PATCH v6 02/24] drm: Add drm_connector_init() variant with ddc

Allow passing ddc adapter pointer to the init function. Even if drm_connector_init() sometime in the future decides to e.g. memset() all connector fields to zeros, the newly added function ensures that at its completion the ddc member of connector is correctly set. Signed-off-by: Andrzej

[PATCH v6 01/24] drm: Add ddc link in sysfs created by drm_connector

Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This

[PATCH v6 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c

[PATCH v6 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c

[PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index

Re: [PATCH] drm/amdgpu: Fix amdgpu_display_supported_domains logic.

Reviewed-by: Alex Deucher From: amd-gfx on behalf of Andrey Grodzovsky Sent: Friday, July 26, 2019 9:28 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Grodzovsky, Andrey ; mic...@daenzer.net ; Koenig, Christian ; S, Shirish Subject: [PATCH]

Re: [PATCH v6 00/24] Associate ddc adapters with connectors

Hi Andezej. On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > >

[PATCH 2/2] drm/amdkfd: enable KFD support for navi14

Same as navi10. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c index f052c70e4659..97f7c5235cc9 100644 ---

[PATCH 1/2] drm/amdgpu/gfx10: update golden settings for navi14

Updated settings for hw team. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 6162703e20d2..8e7e62492bfb 100644 ---

Re: [PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

On Fri, Jul 26, 2019 at 1:29 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- > 1 file changed, 106

Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

On Fri, Jul 26, 2019 at 3:42 PM Andrzej Pietrasiewicz wrote: > > Hi Alex, > > > W dniu 26.07.2019 o 21:28, Alex Deucher pisze: > > On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generic connector. > >> > >> Signed-off-by: Andrzej

Review required [Was: Associate ddc adapters with connectors]

Hi all. Andrzej have done a good job following up on feedback and this series is now ready. We need ack on the patches touching the individual drivers before we can proceed. Please check your drivers and get back. Sam > Hi Andezej. > > On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej

Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Note that this only covers the legacy display code. The new DC display code also needs to be converted. See:

Re: [PATCH v6 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

Hi! Dne petek, 26. julij 2019 ob 19:23:14 CEST je Andrzej Pietrasiewicz napisal(a): > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Jernej Skrabec Thanks! Best regards, Jernej > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c |

Re: [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

Hi Alex, W dniu 26.07.2019 o 21:28, Alex Deucher pisze: On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz wrote: Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Note that this only covers the legacy display code. The new DC display code