Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-07 Thread Christian König
Well that's quite a patch set. First of all can you separate this a bit more by driver? I'm assuming we maintainers are supposed to pick that up and apply it. radeon and amdgpu can stick together since that is mostly Alex and me, but I'm not sure if we want to do some of the suggested

Re: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param

2020-11-07 Thread Sam Ravnborg
Hi Lee, On Fri, Nov 06, 2020 at 09:49:47PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or > member 'dev' not described in 'radeon_info_ioctl' > drivers/gpu/drm/radeon/radeon_kms.c:226:

Re: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header

2020-11-07 Thread Sam Ravnborg
Hi Lee, On Fri, Nov 06, 2020 at 09:49:40PM +, Lee Jones wrote: > Unfortunately, a suitable one didn't already exist. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype > for ‘radeon_device_is_virtual’

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-07 Thread Sam Ravnborg
On Sat, Nov 07, 2020 at 06:41:38PM +, Lee Jones wrote: > On Sat, 07 Nov 2020, Sam Ravnborg wrote: > > > Hi Christian. > > > > > I'm not sure if we want to do some of the suggested changes to radeon. > > > > All patches for radeon looks good to me except "drm/radeon/radeon: Move > >

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-07 Thread Sam Ravnborg
Hi Christian. > I'm not sure if we want to do some of the suggested changes to radeon. All patches for radeon looks good to me except "drm/radeon/radeon: Move prototype into shared header". Acked-by: Sam Ravnborg from me to have them applied (except the shared header one). I can reply to the