[AMD Official Use Only - Internal Distribution Only]
Acked-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Jingwen Chen
Sent: Thursday, November 26, 2020 4:38 PM
To: amd-gfx@lists.freedesktop.org; Zhao, Jiange
Cc: Chen, JingWen
Subject: [PATCH] drm/amdgpu: skip power
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Friday, November 27, 2020 12:28 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH]
Update GC golden setting for dimgrey_cavefish.
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 841d39eb62d9..ffbda6680a68 100644
---
[Why]
Set dpms off on the MST connector that was unplugged, for the side effect of
releasing some references held through deallocation of mst payload.
Signed-off-by: Aurabindo Pillai
Signed-off-by: Eryk Brol
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 31 ++-
Friendly ping.
Please help review.
Regards
Pratik
On 25/11/20 10:02 am, Pratik Vishwakarma wrote:
On 25/11/20 1:38 am, Harry Wentland wrote:
On 2020-11-24 10:55 a.m., Pratik Vishwakarma wrote:
[Why]
Changes in video resolution during playback cause
dispclk to ramp higher but sets incompatile
On Wed, Nov 25, 2020 at 5:24 PM Jakub Kicinski wrote:
>
> And just to spell it out,
>
> case ENUM_VALUE1:
> bla();
> break;
> case ENUM_VALUE2:
> bla();
> default:
> break;
>
> is a fairly idiomatic way of indicating that not all values of the enum
> are expected
On Wed, 25 Nov 2020, Nick Desaulniers wrote:
> So developers and distributions using Clang can't have
> -Wimplicit-fallthrough enabled because GCC is less strict (which has
> been shown in this thread to lead to bugs)? We'd like to have nice
> things too, you know.
>
Apparently the GCC
On 25/11/2020 00:32, Miguel Ojeda wrote:
> I have said *authoring* lines of *this* kind takes a minute per line.
> Specifically: lines fixing the fallthrough warning mechanically and
> repeatedly where the compiler tells you to, and doing so full-time for
> a month.
> It is useful since it makes
On Wed, 25 Nov 2020, Nick Desaulniers wrote:
> On Wed, Nov 25, 2020 at 1:33 PM Finn Thain
> wrote:
> >
> > Or do you think that a codebase can somehow satisfy multiple checkers
> > and their divergent interpretations of the language spec?
>
> Have we found any cases yet that are divergent? I
On 24/11/2020 21:25, Kees Cook wrote:
> I still think this isn't right -- it's a case statement that runs off
> the end without an explicit flow control determination.
Proves too much — for instance
case foo:
case bar:
thing;
break;
doesn't require a fallthrough; after
On Tue, Nov 24, 2020 at 11:05:35PM -0800, James Bottomley wrote:
> Now, what we have seems to be about 6 cases (at least what's been shown
> in this thread) where a missing break would cause potentially user
> visible issues. That means the value of this isn't zero, but it's not
> a no-brainer
On Wed, 25 Nov 2020, Nick Desaulniers wrote:
> On Wed, Nov 25, 2020 at 1:33 PM Finn Thain wrote:
> >
> > Or do you think that a codebase can somehow satisfy multiple checkers
> > and their divergent interpretations of the language spec?
>
> Have we found any cases yet that are divergent? I
Am 25.11.20 um 18:01 schrieb Luben Tuikov:
On 2020-11-25 04:55, Christian König wrote:
Am 25.11.20 um 04:17 schrieb Luben Tuikov:
Introduce a macro DRM_THREAD_NAME_LEN
and use that to define ring name size,
instead of hardcoding it to 16.
Signed-off-by: Luben Tuikov
---
power profile switch in vcn need to send SetWorkLoad msg to
smu, which is not supported in sriov.
Signed-off-by: Jingwen Chen
---
drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
[AMD Public Use]
Reviewed-by: Jiange Zhao
-Original Message-
From: Jingwen Chen
Sent: Thursday, November 26, 2020 4:38 PM
To: amd-gfx@lists.freedesktop.org; Zhao, Jiange
Cc: Chen, JingWen
Subject: [PATCH] drm/amdgpu: skip power profile switch in sriov
power profile switch in vcn
Hi
Am 25.11.20 um 17:32 schrieb Daniel Vetter:
[...]
I guess full locking is required :-/ I'm not exactly sure how to make this
happen with the current plethora of helpers ... I think we need an
_locked version of vmap/vunmap callbacks in drm_gem_object_funcs.
I think we might be able to get
On Thu, Nov 26, 2020 at 11:15 AM Thomas Zimmermann wrote:
>
> Hi
>
> Am 25.11.20 um 17:32 schrieb Daniel Vetter:
> > [...]
> > I guess full locking is required :-/ I'm not exactly sure how to make this
> > happen with the current plethora of helpers ... I think we need an
> > _locked version of
Am 26.11.20 um 12:04 schrieb Daniel Vetter:
On Thu, Nov 26, 2020 at 11:15 AM Thomas Zimmermann wrote:
Hi
Am 25.11.20 um 17:32 schrieb Daniel Vetter:
[...]
I guess full locking is required :-/ I'm not exactly sure how to make this
happen with the current plethora of helpers ... I think we
Hi
Am 26.11.20 um 12:28 schrieb Christian König:
Am 26.11.20 um 12:04 schrieb Daniel Vetter:
On Thu, Nov 26, 2020 at 11:15 AM Thomas Zimmermann
wrote:
Hi
Am 25.11.20 um 17:32 schrieb Daniel Vetter:
[...]
I guess full locking is required :-/ I'm not exactly sure how to
make this
happen
Hi
Am 26.11.20 um 12:04 schrieb Daniel Vetter:
On Thu, Nov 26, 2020 at 11:15 AM Thomas Zimmermann wrote:
Hi
Am 25.11.20 um 17:32 schrieb Daniel Vetter:
[...]
I guess full locking is required :-/ I'm not exactly sure how to make this
happen with the current plethora of helpers ... I think
Am 26.11.20 um 12:59 schrieb Thomas Zimmermann:
Hi
Am 26.11.20 um 12:04 schrieb Daniel Vetter:
On Thu, Nov 26, 2020 at 11:15 AM Thomas Zimmermann
wrote:
Hi
Am 25.11.20 um 17:32 schrieb Daniel Vetter:
[...]
I guess full locking is required :-/ I'm not exactly sure how to
make this
happen
Am 26.11.20 um 13:14 schrieb Thomas Zimmermann:
Hi
Am 26.11.20 um 13:08 schrieb Christian König:
[...]
Yeah, I remember a bug report about frequent page-table
modifications wrt to vram helpers. So we implemented the lazy
unmapping / vmap caching, as suggested by Christian back them. My
On 2020-11-26 9:31 a.m., Aurabindo Pillai wrote:
[Why]
Recent changes to upstream mst code remove the callback which
cleared the internal state for mst. Move the missing functionality
that was previously called through the destroy call back for mst connector
destroy
Signed-off-by: Aurabindo
Hi
Am 26.11.20 um 13:08 schrieb Christian König:
[...]
Yeah, I remember a bug report about frequent page-table modifications
wrt to vram helpers. So we implemented the lazy unmapping / vmap
caching, as suggested by Christian back them. My guess is that
anything TTM-based can use a similar
[Why]
Recent changes to upstream mst code remove the callback which
cleared the internal state for mst. Move the missing functionality
that was previously called through the destroy call back for mst connector
destroy
Signed-off-by: Aurabindo Pillai
Signed-off-by: Eryk Brol
---
[Why]
Set dpms off on the MST connector that was unplugged, for the side effect of
releasing some references held through deallocation of mst payload.
Signed-off-by: Aurabindo Pillai
Signed-off-by: Eryk Brol
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 33 ++-
On 2020-11-26 3:11 p.m., Kazlauskas, Nicholas wrote:
> On 2020-11-26 2:50 p.m., Aurabindo Pillai wrote:
>> [Why]
>>
>> Set dpms off on the MST connector that was unplugged, for the side
>> effect of
>> releasing some references held through deallocation of mst payload.
>>
>> Signed-off-by:
On 2020-11-26 4:45 p.m., Aurabindo Pillai wrote:
[Why]
Set dpms off on the MST connector that was unplugged, for the side effect of
releasing some references held through deallocation of mst payload.
Signed-off-by: Aurabindo Pillai
Signed-off-by: Eryk Brol
---
On Wed, Nov 25, 2020 at 3:34 PM Christian König
wrote:
>
> Reorder the code to fix checking if blitting is available.
Might be good to explain why blitting might not be available, e.g.
suspend/resume and or chip death and stuff like that.
> Signed-off-by: Christian König
Needs Fixes:
On 2020-11-26 9:35 a.m., Kazlauskas, Nicholas wrote:
On 2020-11-26 9:31 a.m., Aurabindo Pillai wrote:
[Why]
Recent changes to upstream mst code remove the callback which
cleared the internal state for mst. Move the missing functionality
that was previously called through the destroy call back
On 11/24/20 10:17 PM, Luben Tuikov wrote:
The job timeout handler now returns status
indicating back to the DRM layer whether the job
was successfully cancelled or whether more time
should be given to the job to complete.
Signed-off-by: Luben Tuikov
---
Ping, Dave this is another fix for the Multihop patch set.
Without it radeon is completely broken on drm-misc-next.
Thanks,
Christian.
Am 25.11.20 um 15:34 schrieb Christian König:
Reorder the code to fix checking if blitting is available.
Signed-off-by: Christian König
---
On 2020-11-26 9:35 a.m., Kazlauskas, Nicholas wrote:
> On 2020-11-26 9:31 a.m., Aurabindo Pillai wrote:
>> [Why]
>> Recent changes to upstream mst code remove the callback which
>> cleared the internal state for mst. Move the missing functionality
>> that was previously called through the
On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote:
>
> Hi Miguel,
>
> On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda
> wrote:
> > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote:
> > > To make the intent clear, you have to first be certain that you
> > > understand the intent;
[Why]
Set dpms off on the MST connector that was unplugged, for the side effect of
releasing some references held through deallocation of mst payload.
Signed-off-by: Aurabindo Pillai
Signed-off-by: Eryk Brol
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 63 ++-
1 file
On 2020-11-26 2:50 p.m., Aurabindo Pillai wrote:
[Why]
Set dpms off on the MST connector that was unplugged, for the side effect of
releasing some references held through deallocation of mst payload.
Signed-off-by: Aurabindo Pillai
Signed-off-by: Eryk Brol
---
36 matches
Mail list logo
