[PATCH] drm: display: Remove duplicate include in dce110

2021-06-07 Thread Wan Jiabing
Fix the following checkincludes.pl warning: ./drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c 35 #include "dce110_hw_sequencer.h" 69 #include "dce110_hw_sequencer.h" Signed-off-by: Wan Jiabing --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 1 - 1 file

Re: [RFC PATCH v2 1/8] ext4/xfs: add page refcount helper

2021-06-07 Thread Liam Howlett
* Alex Sierra [210607 16:43]: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > --- >

Re: [PATCH] treewide: Add missing semicolons to __assign_str uses

2021-06-07 Thread Jason Gunthorpe
On Fri, Jun 04, 2021 at 12:38:07PM -0700, Joe Perches wrote: > The __assign_str macro has an unusual ending semicolon but the vast > majority of uses of the macro already have semicolon termination. > > $ git grep -P '\b__assign_str\b' | wc -l > 551 > $ git grep -P '\b__assign_str\b.*;' | wc -l >

RE: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Zhang, Boyuan
[AMD Official Use Only] Patch is Reviewed-by: Boyuan Zhang Thanks, Boyuan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: June 7, 2021 4:29 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

[RFC PATCH v2 7/8] mm: add generic type support to migrate_vma helpers

2021-06-07 Thread Alex Sierra
Device generic type case added for migrate_vma_pages and migrate_vma_check_page helpers. Both, generic and private device types have the same conditions to decide to migrate pages from/to device memory. Signed-off-by: Alex Sierra --- mm/migrate.c | 8 1 file changed, 4 insertions(+), 4

[RFC PATCH v2 2/8] mm: remove extra ZONE_DEVICE struct page refcount

2021-06-07 Thread Alex Sierra
From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference count to see that a page is not being used (gup, compaction, migration, etc.). Clean up the code so the reference

[RFC PATCH v2 5/8] drm/amdkfd: generic type as sys mem on migration to ram

2021-06-07 Thread Alex Sierra
Generic device type memory on VRAM to RAM migration, has similar access as System RAM from the CPU. This flag sets the source from the sender. Which in Generic type case, should be set as SYSTEM. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling ---

[RFC PATCH v2 6/8] include/linux/mm.h: helpers to check zone device generic type

2021-06-07 Thread Alex Sierra
Two helpers added. One checks if zone device page is generic type. The other if page is either private or generic type. Signed-off-by: Alex Sierra --- include/linux/mm.h | 8 1 file changed, 8 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index

[RFC PATCH v2 4/8] drm/amdkfd: add SPM support for SVM

2021-06-07 Thread Alex Sierra
When CPU is connected throug XGMI, it has coherent access to VRAM resource. In this case that resource is taken from a table in the device gmc aperture base. This resource is used along with the device type, which could be DEVICE_PRIVATE or DEVICE_GENERIC to create the device page map region.

[RFC PATCH v2 8/8] mm: call pgmap->ops->page_free for DEVICE_GENERIC pages

2021-06-07 Thread Alex Sierra
Add MEMORY_DEVICE_GENERIC case to free_zone_device_page callback. Device generic type memory case is now able to free its pages properly. Signed-off-by: Alex Sierra --- mm/memremap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/memremap.c b/mm/memremap.c index

[RFC PATCH v2 3/8] kernel: resource: lookup_resource as exported symbol

2021-06-07 Thread Alex Sierra
The AMD architecture for the Frontier supercomputer will have device memory which can be coherently accessed by the CPU. The system BIOS advertises this memory as SPM (special purpose memory) in the UEFI system address map. The AMDGPU driver needs to be able to lookup this resource in order to

[RFC PATCH v2 0/8] Support DEVICE_GENERIC memory in migrate_vma_*

2021-06-07 Thread Alex Sierra
v1: https://lore.kernel.org/linux-mm/20210529064022.gb15...@lst.de/T/ v2: This patch series version has merged "[RFC PATCH v3 0/2] mm: remove extra ZONE_DEVICE struct page refcount" patch series made by Ralph Campbell. It also applies at the top of these series, our changes to support device

[RFC PATCH v2 1/8] ext4/xfs: add page refcount helper

2021-06-07 Thread Alex Sierra
From: Ralph Campbell There are several places where ZONE_DEVICE struct pages assume a reference count == 1 means the page is idle and free. Instead of open coding this, add a helper function to hide this detail. Signed-off-by: Ralph Campbell --- fs/dax.c| 4 ++-- fs/ext4/inode.c

[PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Alex Deucher
Drop disabling of gfxoff during VCN use. This allows gfxoff to kick in and potentially save power if the user is not using gfx for color space conversion or scaling. VCN1.0 had a bug which prevented it from working properly with gfxoff, so we disabled it while using VCN. That said, most apps

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Christian König
Am 07.06.21 um 21:39 schrieb Rohit Khaire: This is similar to IH_RB_CNTL programming in navi10_ih_toggle_ring_interrupts Signed-off-by: Rohit Khaire Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 20

[PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Rohit Khaire
This is similar to IH_RB_CNTL programming in navi10_ih_toggle_ring_interrupts Signed-off-by: Rohit Khaire --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 ++ drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 20 +++- 2 files changed, 17 insertions(+), 5 deletions(-) diff --git

[PATCH 4/5] drm/amdgpu: add psp ta microcode init for aldebaran sriov vf

2021-06-07 Thread Zhigang Luo
need to load xgmi ta for aldebaran sriov vf. Signed-off-by: Zhigang Luo --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index 47ceb783e2a5..29c365160043

Re: [PATCH] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Harry Wentland
On 2021-06-07 2:19 p.m., Sean Paul wrote: > On Tue, May 18, 2021 at 2:58 PM Rodrigo Siqueira > wrote: >> >> On 05/14, Mark Yacoub wrote: >>> On Fri, May 14, 2021 at 12:31 PM Mark Yacoub wrote: On Fri, May 14, 2021 at 11:28 AM Harry Wentland wrote: > > On 2021-05-14 7:47

RE: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Khaire, Rohit
[AMD Public Use] OK. I will just skip the function call for SRIOV and resend. Rohit -Original Message- From: Koenig, Christian Sent: June 7, 2021 12:42 PM To: Kuehling, Felix ; Khaire, Rohit ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Deng, Emily ; Liu,

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Alex Deucher
On Mon, Jun 7, 2021 at 4:54 PM Ernst Sjöstrand wrote: > > Hi, > > doesn't this patch apply the change to VCN1.0 also, which has that bug you > mentioned? > Nope. VCN1.0 uses vcn_v1_0_idle_work_handler() and vcn_v1_0_ring_begin_use() as they have other special handling in addition to this.

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Ernst Sjöstrand
Hi, doesn't this patch apply the change to VCN1.0 also, which has that bug you mentioned? Regards //Ernst Den mån 7 juni 2021 kl 22:29 skrev Alex Deucher : > Drop disabling of gfxoff during VCN use. This allows gfxoff > to kick in and potentially save power if the user is not using > gfx for

[PATCH 30/30] drm/amd/display: 3.2.139

2021-06-07 Thread Stylon Wang
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

[PATCH 27/30] drm/amd/display: force CP to DESIRED when removing display

2021-06-07 Thread Stylon Wang
From: "Dingchen (David) Zhang" [WHY] - Commit from userspace could cause link stream to disable and hdcp auth to reset when the HDCP has already been enabled at the moment. CP should fall back to DESIRED from ENABLED in such cases. - This change was previously reverted due to a regression

[PATCH 23/30] drm/amd/display: Fix crash during MPO + ODM combine mode recalculation

2021-06-07 Thread Stylon Wang
From: Aric Cyr [Why] When calculating recout width for an MPO plane on a mode that's using ODM combine, driver can calculate a negative value, resulting in a crash. [How] For negative widths, use zero such that validation will prune the configuration correctly and disallow MPO. Signed-off-by:

[PATCH 21/30] drm/amd/display: Set DISPCLK_MAX_ERRDET_CYCLES to 7

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] DISPCLK_MAX_ERRDET_CYCLES must be 7 to prevent connection loss when changing DENTIST_DISPCLK_WDIVIDER from 126 to 127 and back. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang ---

[PATCH 29/30] drm/amd/display: [FW Promotion] Release 0.0.69

2021-06-07 Thread Stylon Wang
From: Wyatt Wood Signed-off-by: Wyatt Wood Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 25/30] drm/amd/display: Revert "Disconnect non-DP with no EDID"

2021-06-07 Thread Stylon Wang
From: Roy Chan [Why] Found a use case (IPKVM) that DP-VGA active dongle does not return any EDID and the mentioned commit broke it. [How] This reverts "Disconnect non-DP with no EDID" Signed-off-by: Roy Chan Reviewed-by: Chris Park Acked-by: Stylon Wang ---

[PATCH 24/30] drm/amd/display: Add debugfs entry for dsc passthrough

2021-06-07 Thread Stylon Wang
From: Fangzhi Zuo [Why & How] Add debugfs entry to force dsc decoding at PCON when DSC capable external RX is connected. In such case, it is free to test DSC decoding at external RX or at PCON. Signed-off-by: Fangzhi Zuo Reviewed-by: Hersen Wu Acked-by: Stylon Wang ---

[PATCH 20/30] drm/amd/display: Add interface for ADD & DROP PIXEL Registers

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] HW has handed down a new sequence that requires access to these registers. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.c | 26 ++

[PATCH 16/30] drm/amd/display: Change default policy for MPO with multidisplay

2021-06-07 Thread Stylon Wang
From: Aric Cyr [Why] Rearranging pipes with multiple displays and multiple planes cannot be done atomically and requires a much improved sequence to deal with it. [How] To workaround such issues, prefer avoid pipe-split policy for multidisplay scenarios. Signed-off-by: Aric Cyr Reviewed-by:

[PATCH 19/30] drm/amd/display: Add Interface to set FIFO ERRDET SW Override

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] HW has handed down a new sequence which requires access to the FIFO ERRDET SW Override register. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.c | 10 +++

[PATCH 26/30] drm/amd/display: Updates for ODM Transition Test

2021-06-07 Thread Stylon Wang
From: Eric Bernstein [Why] There is an assert in cases where transition from ODM 2:1 to ODM 1:1 (bypass) [How] Remove assert since this case is now valid. Update diags tests for ODM transitions. Signed-off-by: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang ---

[PATCH 22/30] drm/amd/display: Fix off-by-one error in DML

2021-06-07 Thread Stylon Wang
From: Wesley Chalmers [WHY] For DCN30 and later, there is no data in DML arrays indexed by state at index num_states. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Stylon Wang --- .../amd/display/dc/dml/dcn30/display_mode_vba_30.c | 14 +++--- 1 file

[PATCH 15/30] drm/amd/display: Release MST resources on switch from MST to SST

2021-06-07 Thread Stylon Wang
From: Vladimir Stempen [why] When OS overrides training link training parameters for MST device to SST mode, MST resources are not released and leak of the resource may result crash and incorrect MST discovery during following hot plugs. [how] Retaining sink object to be reused by SST link and

[PATCH 14/30] drm/amd/display: Enable PSR Residency for multiple panels

2021-06-07 Thread Stylon Wang
From: Mikita Lipski [why] Allow specifying which panel to take PSR Residency measurements from. [how] Pass panel instance to DMUB through GPINT in the upper 8 bits of the parameter. Signed-off-by: Mikita Lipski Reviewed-by: Nicholas Kazlauskas Acked-by: Stylon Wang ---

[PATCH 09/30] drm/amd/display: Expand DP module equalization API.

2021-06-07 Thread Stylon Wang
From: Jimmy Kizito [Why & How] Add functionality useful for DP equalization phase of link training to public interface. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 22 +--

[PATCH 18/30] drm/amd/display: 3.2.138

2021-06-07 Thread Stylon Wang
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

[PATCH 11/30] drm/amd/display: Update scaling settings on modeset

2021-06-07 Thread Stylon Wang
From: Roman Li [Why] We update scaling settings when scaling mode has been changed. However when changing mode from native resolution the scaling mode previously set gets ignored. [How] Perform scaling settings update on modeset. Signed-off-by: Roman Li Reviewed-by: Nicholas Kazlauskas

[PATCH 12/30] drm/amd/display: Remove unused definition of DMUB SET_CONFIG

2021-06-07 Thread Stylon Wang
From: Meenakshikumar Somasundaram [Why & How] SET_CONFIG transactions with DMUB is not used and removed. Signed-off-by: Meenakshikumar Somasundaram Reviewed-by: Jun Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 1 file changed, 4 deletions(-) diff

[PATCH 13/30] drm/amd/display: Return last used DRR VTOTAL from DC

2021-06-07 Thread Stylon Wang
From: Jayendran Ramani [How] Add call to get the last used VTOTAL from DC Signed-off-by: Jayendran Ramani Reviewed-by: Anthony Koo Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc.c | 42 +++ drivers/gpu/drm/amd/display/dc/dc_stream.h| 4 ++

[PATCH 17/30] drm/amd/display: [FW Promotion] Release 0.0.68

2021-06-07 Thread Stylon Wang
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 04/30] drm/amd/display: Fix DCN 3.01 DSCCLK validation

2021-06-07 Thread Stylon Wang
From: Nikola Cornij [why] DSCCLK validation is not necessary because DSCCLK is derrived from DISPCLK, therefore if DISPCLK validation passes, DSCCLK is valid, too. Doing DSCLK validation in addition to DISPCLK leads to modes being wrongly rejected when DSCCLK was incorrectly set outside of DML.

[PATCH 03/30] drm/amd/display: delay 100ms before restart after failing to read CP_IRQ

2021-06-07 Thread Stylon Wang
From: Wenjing Liu [why] Some DPRX will issue CP_IRQ when user disconnects a display that has been authenticated. Since display is being disconnecting dpcd read will fail. This will cause us to attempt HDCP retry on disconnection. We are adding a 100ms delay before retry. So we will only start

[PATCH 05/30] drm/amd/display: Control power gating by driver.

2021-06-07 Thread Stylon Wang
From: "JinZe.Xu" [Why] This disablement would be specific for Nav10 and shouldn’t be propagated to the other programs. [How] Power gating is controlled by driver. Signed-off-by: JinZe.Xu Reviewed-by: Jun Lei Acked-by: Stylon Wang --- .../drm/amd/display/dc/dcn302/dcn302_hwseq.c | 34

[PATCH 02/30] drm/amd/display: Enabling PSR support for multiple panels

2021-06-07 Thread Stylon Wang
From: Mikita Lipski [why] Updating PSR interfaces to allow PSR enablement per eDP panel. [how] - Copying PSR command structures to DC - Changing function interfaces to pass panel instance - Communicating with DMUB per link instead of assuming to use a single one -Iterating through all PSR

[PATCH 10/30] drm/amd/display: Support mappable encoders when transmitting training patterns.

2021-06-07 Thread Stylon Wang
From: Jimmy Kizito [Why & How] Add support for transmitting training pattern sequences for links whose encoders have been dynamically assigned. Signed-off-by: Jimmy Kizito Reviewed-by: Jun Lei Acked-by: Stylon Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 11 ++- 1

[PATCH 08/30] drm/amd/display: Revert "Fix clock table filling logic"

2021-06-07 Thread Stylon Wang
From: Ilya Bakoulin [Why] This change was found to break some high-refresh modes. Reverting to unblock mainline. Signed-off-by: Ilya Bakoulin Reviewed-by: Sung Lee Acked-by: Stylon Wang --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 78 +++

[PATCH 01/30] drm/amd/display: Trigger full update after DCC on/off

2021-06-07 Thread Stylon Wang
From: Jake Wang [Why] During DCC on/off, stutter period is calculated before DCC has fully transitioned. This results in incorrect stutter period calculation. [How] Trigger a full update when DCC changes between on/off. Signed-off-by: Jake Wang Reviewed-by: Aric Cyr Acked-by: Stylon Wang

[PATCH 00/30] DC Patches June, 7, 2021

2021-06-07 Thread Stylon Wang
This DC patchset brings improvements in multiple areas. In summary, we highlight: * DC v3.2.139 * FW v0.0.69 * Improvements across DP, eDP, DMUB, MPO, etc -- Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.68 Aric Cyr (4): drm/amd/display: Change default policy for MPO with

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Christian König
Ah, good point. In this case we should probably rather save than sorry. Then I suggest to clean up this patch, repeating the psp_reg_program() and error message is pretty horrible coding style. Christian. Am 07.06.21 um 18:36 schrieb Felix Kuehling: With SRIOV, the interrupt routing is

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Felix Kuehling
With SRIOV, the interrupt routing is setup by the hypervisor driver. We need the secondary IH rings in case the hypervisor enabled rerouting of page fault interrupts. I'm not sure what the hypervisor driver does today. Regards,   Felix Am 2021-06-07 um 12:29 p.m. schrieb Christian König: >

Re: [PATCH 4/4] drm/i915/display: Add handling for new "active bpc" property

2021-06-07 Thread Werner Sembach
Am 07.06.21 um 08:47 schrieb Werner Sembach: Am 04.06.21 um 19:30 schrieb Ville Syrjälä: On Fri, Jun 04, 2021 at 07:17:23PM +0200, Werner Sembach wrote: This commits implements the "active bpc" drm property for the Intel GPU driver. Signed-off-by: Werner Sembach ---  

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Christian König
That's a workaround for bare metal and as far as I know doesn't apply to SRIOV. We only need the additional IH rings for page fault handling or log handling and as far as I know that is incompatible with SRIOV for the moment. But Felix might have some more updates on this. So as long as we

RE: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Khaire, Rohit
[AMD Public Use] The hash is 5ea6f9c Rohit -Original Message- From: Koenig, Christian Sent: June 7, 2021 11:58 AM To: Khaire, Rohit ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Deng, Emily ; Liu, Monk ; Zhou, Peng Ju ; Chen, Horace Cc: Ming, Davis

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Christian König
Do you have the hash for this commit? Thanks, Christian. Am 07.06.21 um 17:30 schrieb Khaire, Rohit: [AMD Public Use] We don't need RING1 and RING2 functionality for SRIOV afaik. But looking at the description of the original commit message it affects RING0 too? " drm/amdgpu: add timeout

Re: [PATCH] drm/amd/pm: fix warning reported by kernel test robot

2021-06-07 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Xiaomeng Hou Sent: Monday, June 7, 2021 8:45 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Hou, Xiaomeng (Matthew) ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/pm: fix warning reported by

RE: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Khaire, Rohit
[AMD Public Use] We don't need RING1 and RING2 functionality for SRIOV afaik. But looking at the description of the original commit message it affects RING0 too? " drm/amdgpu: add timeout flush mechanism to update wptr for self interrupt (v2) outstanding log reaches threshold will trigger IH

RE: [PATCH v5 7/9] drm/amd/pm: Add vangogh throttler translation

2021-06-07 Thread Sider, Graham
Great, thanks for all the feedback Lijo. Out of the new bit definitions in amdgpu_smu.h are there any that currently exist that are more applicable for these mappings? *_THM_GFX and *_THM_SOC only exist in VanGogh and Renoir. With the expansion of the MEM and LIQUID bits there is not enough

Re: [PATCH v5 7/9] drm/amd/pm: Add vangogh throttler translation

2021-06-07 Thread Lazar, Lijo
On 6/7/2021 7:14 PM, Graham Sider wrote: Perform dependent to independent throttle status translation for vangogh. Signed-off-by: Graham Sider --- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 38 ++- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Christian König
Why are the ring 1&2 enabled on SRIOV in the first place? Christian. Am 07.06.21 um 16:23 schrieb Rohit Khaire: This is similar to IH_RB_CNTL programming in navi10_ih_toggle_ring_interrupts Signed-off-by: Rohit Khaire --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 20 ++-- 1

Re: [PATCH 0/7] libdrm tests for hot-unplug fe goature

2021-06-07 Thread Andrey Grodzovsky
Hey, MR created at https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172, please help review. Andrey On 2021-06-03 10:26 p.m., Alex Deucher wrote: Code review happens on gitlab now for libdrm. Alex On Thu, Jun 3, 2021 at 6:02 PM Grodzovsky, Andrey wrote: Is libdrm on gitlab ? I

[PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Rohit Khaire
This is similar to IH_RB_CNTL programming in navi10_ih_toggle_ring_interrupts Signed-off-by: Rohit Khaire --- drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c

[PATCH] drm/amdgpu: Fix warning of Function parameter or member not described

2021-06-07 Thread Eric Huang
Add the parameter table_freed description on function description. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index

RE: [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and aldebaran sriov vf

2021-06-07 Thread Luo, Zhigang
[Public] Okay. I will update the change as you suggested. Thanks, Zhigang -Original Message- From: Zhang, Hawking Sent: June 7, 2021 9:52 AM To: Luo, Zhigang ; Liu, Shaoyun ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and

RE: [PATCH 4/5] drm/amdgpu: add psp microcode init for arcturus and aldebaran sriov vf

2021-06-07 Thread Zhang, Hawking
[AMD Official Use Only] You can call psp_init_ta_microcode directly in sriov vf case so you don't need to initialize unnecessary psp firmware structures. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Luo, Zhigang Sent: Thursday, June 3, 2021 23:32 To: Liu, Shaoyun ;

[PATCH v5 8/9] drm/amd/pm: Add renoir throttler translation

2021-06-07 Thread Graham Sider
Perform dependent to independent throttle status translation for renoir. Signed-off-by: Graham Sider --- .../gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 29 +++ 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c

[PATCH v5 6/9] drm/amd/pm: Add sienna cichlid throttler translation

2021-06-07 Thread Graham Sider
Perform dependent to independent throttle status translation for sienna cichlid. Signed-off-by: Graham Sider --- .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 34 --- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git

[PATCH v5 7/9] drm/amd/pm: Add vangogh throttler translation

2021-06-07 Thread Graham Sider
Perform dependent to independent throttle status translation for vangogh. Signed-off-by: Graham Sider --- .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 38 ++- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c

[PATCH v5 9/9] drm/amd/pm: Add aldebaran throttler translation

2021-06-07 Thread Graham Sider
Perform dependent to independent throttle status translation for aldebaran. Signed-off-by: Graham Sider --- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 27 +++ 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c

[PATCH v5 5/9] drm/amd/pm: Add navi1x throttler translation

2021-06-07 Thread Graham Sider
Perform dependent to independent throttle status translation for navi1x. Signed-off-by: Graham Sider --- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c

[PATCH v5 2/9] drm/amd/pm: Add ASIC independent throttle bits

2021-06-07 Thread Graham Sider
Add new defines for thermal throttle status bits which are ASIC independent. This bit field will be visible to userspace via gpu_metrics alongside the previous ASIC dependent bit fields. Seperated into four 16-bit types: power throttlers, current throttlers, temperature, other. Signed-off-by:

[PATCH v5 4/9] drm/amd/pm: Add arcturus throttler translation

2021-06-07 Thread Graham Sider
Perform dependent to independent throttle status translation for arcturus. Signed-off-by: Graham Sider --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 33 --- 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c

[PATCH v5 3/9] drm/amd/pm: Add common throttler translation func

2021-06-07 Thread Graham Sider
Defines smu_cmn_get_indep_throttler_status which performs ASIC independent translation given a corresponding lookup table. Signed-off-by: Graham Sider --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 13 + drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h | 4 2 files changed, 17

[PATCH v5 1/9] drm/amd/pm: Add u64 throttler status field to gpu_metrics

2021-06-07 Thread Graham Sider
This patch set adds support for a new ASIC independant u64 throttler status field (indep_throttle_status). Piggybacks off the gpu_metrics_v1_3 bump and similarly bumps gpu_metrics_v2 version (to v2_2) to add field. Signed-off-by: Graham Sider --- .../gpu/drm/amd/include/kgd_pp_interface.h|

Re: [PATCH] drm/amdgpu: Use PSP to program IH_RB_CNTL_RING1/2 on SRIOV

2021-06-07 Thread Christian König
That won't work either. We still need to initialize the control registers and tell the hardware that we have properly setup the ring buffers. Just add the error message to psp_reg_program() instead of duplicating that over and over again. Christian. Am 07.06.21 um 19:33 schrieb Khaire,

Re: [PATCH] drm/amdkfd: remove duplicate include of kfd_svm.h

2021-06-07 Thread Felix Kuehling
Am 2021-06-04 um 10:54 p.m. schrieb Wan Jiabing: > kfd_svm.h is included duplicately in commit 42de677f7 > ("drm/amdkfd: register svm range"). > > After checking possible related header files, > remove the former one to make the code format more reasonable. > > Signed-off-by: Wan Jiabing

Re: [PATCH][next] drm/amd/display: Fix two spelling mistakes, clean wide lines

2021-06-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jun 7, 2021 at 7:58 AM Colin King wrote: > > From: Colin Ian King > > There are two spelling mistakes in dml_print messages, fix these and > clear up checkpatch warning on overly wide line length. > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH] drm/amdgpu: Fix a a typo in a comment

2021-06-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jun 7, 2021 at 6:46 AM Christian König wrote: > > Am 05.06.21 um 11:06 schrieb Christophe JAILLET: > > s/than/then/ > > > > Signed-off-by: Christophe JAILLET > > Acked-by: Christian König > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- > > 1 file

Re: [PATCH] drm/amd/display: Fix duplicate included dce110_hw_sequencer.h

2021-06-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jun 7, 2021 at 6:27 AM Jiapeng Chong wrote: > > Clean up the following includecheck warning: > > ./drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c: > dce110_hw_sequencer.h is included more than once. > > No functional change. > > Reported-by: Abaci

Re: [PATCH] drm/amd/display: remove no need variable

2021-06-07 Thread Alex Deucher
On Sat, Jun 5, 2021 at 8:31 AM Bernard Zhao wrote: > > remove no need variable, just return the DC_OK > > Signed-off-by: Bernard Zhao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[PATCH 28/30] drm/amd/display: Add swizzle visual confirm mode

2021-06-07 Thread Stylon Wang
From: Po-Ting Chen [Why] To support a new visual confirm mode: swizzle to show the specific color at the screen border according to different surface swizzle mode. Currently we only support the Linear mode with red color. Signed-off-by: Po-Ting Chen ---

[PATCH 07/30] drm/amd/display: add visual confirm colors to differentiate layer_index > 0

2021-06-07 Thread Stylon Wang
From: Evgenii Krasnikov [WHY] Currently there is no way to visually identify if there is one or more layers presented fullscreen on the display [HOW] Add new visual confirm colors in get_surface_visual_confirm_color for planes with layer_index > 0 Signed-off-by: Evgenii Krasnikov Reviewed-by:

[PATCH 06/30] drm/amd/display: Refactor visual confirm

2021-06-07 Thread Stylon Wang
From: Wyatt Wood [Why + How] Visual confirm has no asic-specific logic, so we can refactor and unify these functions that are currently spread out across multiple dcn files. Add a new hw sequencer interface update_visual_confirm_color, and a new mpc function pointer set_bg_color. This will allow

[PATCH] drm/amd/pm: fix warning reported by kernel test robot

2021-06-07 Thread Xiaomeng Hou
Kernel test robot throws warning -> >> drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/yellow_carp_ppt.c:483:2: warning: variable 'member_type' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~

Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown()

2021-06-07 Thread Christian König
Am 07.06.21 um 14:27 schrieb Tiezhu Yang: radeon_suspend_kms() puts the hw in the suspend state (all asics), it should always call radeon_suspend_kms() in radeon_pci_shutdown(), this is a normal cleanup process to avoid more operations on radeon, just remove #ifdef CONFIG_PPC64 and the related

[PATCH AUTOSEL 5.4 25/29] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After

[PATCH AUTOSEL 5.4 24/29] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-06-07 Thread Sasha Levin
From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non

[PATCH AUTOSEL 5.10 35/39] drm/amd/amdgpu:save psp ring wptr to avoid attack

2021-06-07 Thread Sasha Levin
From: Victor Zhao [ Upstream commit 2370eba9f552eaae3d8aa1f70b8e9eec5c560f9e ] [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify

[PATCH AUTOSEL 5.10 34/39] drm/amd/display: Fix potential memory leak in DMUB hw_init

2021-06-07 Thread Sasha Levin
From: Roman Li [ Upstream commit c5699e2d863f58221044efdc3fa712dd32d55cde ] [Why] On resume we perform DMUB hw_init which allocates memory: dm_resume->dm_dmub_hw_init->dc_dmub_srv_create->kzalloc That results in memory leak in suspend/resume scenarios. [How] Allocate memory for the DC wrapper

[PATCH AUTOSEL 5.10 33/39] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After

[PATCH AUTOSEL 5.10 32/39] drm/amdgpu: refine amdgpu_fru_get_product_info

2021-06-07 Thread Sasha Levin
From: Jiansong Chen [ Upstream commit 5cfc912582e13b05d71fb7acc4ec69ddfa9af320 ] 1. eliminate potential array index out of bounds. 2. return meaningful value for failure. Signed-off-by: Jiansong Chen Reviewed-by: Jack Gui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.10 31/39] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-06-07 Thread Sasha Levin
From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non

[PATCH AUTOSEL 5.12 45/49] drm/amd/amdgpu:save psp ring wptr to avoid attack

2021-06-07 Thread Sasha Levin
From: Victor Zhao [ Upstream commit 2370eba9f552eaae3d8aa1f70b8e9eec5c560f9e ] [Why] When some tools performing psp mailbox attack, the readback value of register can be a random value which may break psp. [How] Use a psp wptr cache machanism to aovid the change made by attack. v2: unify

[PATCH AUTOSEL 5.12 44/49] drm/amd/display: Fix potential memory leak in DMUB hw_init

2021-06-07 Thread Sasha Levin
From: Roman Li [ Upstream commit c5699e2d863f58221044efdc3fa712dd32d55cde ] [Why] On resume we perform DMUB hw_init which allocates memory: dm_resume->dm_dmub_hw_init->dc_dmub_srv_create->kzalloc That results in memory leak in suspend/resume scenarios. [How] Allocate memory for the DC wrapper

[PATCH AUTOSEL 5.12 43/49] drm/amd/display: Fix overlay validation by considering cursors

2021-06-07 Thread Sasha Levin
From: Rodrigo Siqueira [ Upstream commit 33f409e60eb0c59a4d0d06a62ab4642a988e17f7 ] A few weeks ago, we saw a two cursor issue in a ChromeOS system. We fixed it in the commit: drm/amd/display: Fix two cursor duplication when using overlay (read the commit message for more details) After

[PATCH AUTOSEL 5.12 42/49] drm/amdgpu: refine amdgpu_fru_get_product_info

2021-06-07 Thread Sasha Levin
From: Jiansong Chen [ Upstream commit 5cfc912582e13b05d71fb7acc4ec69ddfa9af320 ] 1. eliminate potential array index out of bounds. 2. return meaningful value for failure. Signed-off-by: Jiansong Chen Reviewed-by: Jack Gui Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.12 41/49] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-06-07 Thread Sasha Levin
From: Bindu Ramamurthy [ Upstream commit ba8e59773ae59818695d1e20b8939282da80ec8c ] [Why] Bandwidth calculations are triggered for non zero streams, and in case of 0 streams, these calculations were skipped with pstate status not being updated. [How] As the pstate status is applicable for non

Re: [PATCH] drm/amd/display: Verify Gamma & Degamma LUT sizes in amdgpu_dm_atomic_check

2021-06-07 Thread Mark Yacoub
On Fri, Jun 4, 2021 at 4:17 PM Harry Wentland wrote: > > > > On 2021-06-04 1:01 p.m., Mark Yacoub wrote: > > From: Mark Yacoub > > > > For each CRTC state, check the size of Gamma and Degamma LUTs so > > unexpected and larger sizes wouldn't slip through. > > > > TEST:

Re: [PATCH] drm/amdgpu: Fix warning of Function parameter or member not described

2021-06-07 Thread Christian König
Am 07.06.21 um 16:21 schrieb Eric Huang: Add the parameter table_freed description on function description. Signed-off-by: Eric Huang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] drm/radeon: Always call radeon_suspend_kms() in radeon_pci_shutdown()

2021-06-07 Thread Alex Deucher
On Mon, Jun 7, 2021 at 8:30 AM Christian König wrote: > > Am 07.06.21 um 14:27 schrieb Tiezhu Yang: > > radeon_suspend_kms() puts the hw in the suspend state (all asics), > > it should always call radeon_suspend_kms() in radeon_pci_shutdown(), > > this is a normal cleanup process to avoid more

  1   2   >