[PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay

2021-06-29 Thread YuBiao Wang
[Why] GPU timing counters are read via KIQ under sriov, which will introduce a delay. [How] It could be directly read by MMIO. v2: Add additional check to prevent carryover issue. v3: Only check for carryover for once to prevent performance issue. Signed-off-by: YuBiao Wang Acked-by: Horace

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Neil Armstrong
Hi, On 29/06/2021 15:58, Thomas Zimmermann wrote: > Print the name of the DRM driver when taking over fbdev devices. Makes > the output to dmesg more consistent. Note that the driver name is only > used for printing a string to the kernel log. No UAPI is affected by this > change. > >

RE: [PATCH v3] drm/amdgpu: Restore msix after FLR

2021-06-29 Thread Zhou, Peng Ju
[AMD Official Use Only] Ping -- BW Pengju Zhou > -Original Message- > From: Peng Ju Zhou > Sent: Friday, June 25, 2021 2:44 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily ; Zhou, Peng Ju > > Subject:

Re: [PATCH v2 2/2] drm/amdgpu: free pasid early before converting a vm

2021-06-29 Thread Das, Nirmoy
On 6/29/2021 1:12 PM, Christian König wrote: Am 29.06.21 um 09:55 schrieb Nirmoy Das: VM code should not be responsible for freeing pasid as pasid gets allocated outside of VM code, before initializing a vm. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8

Re: [PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay

2021-06-29 Thread Christian König
Am 29.06.21 um 11:47 schrieb YuBiao Wang: [Why] GPU timing counters are read via KIQ under sriov, which will introduce a delay. [How] It could be directly read by MMIO. v2: Add additional check to prevent carryover issue. Signed-off-by: YuBiao Wang ---

Re: [PATCH] drm/amdgpu: Set ttm caching flags during bo allocation

2021-06-29 Thread Das, Nirmoy
Thanks for the detailed commit message :) Acked-by: Nirmoy Das On 6/29/2021 1:15 AM, Oak Zeng wrote: The ttm caching flags (ttm_cached, ttm_write_combined etc) are used to determine a buffer object's mapping attributes in both CPU page table and GPU page table (when that buffer is also

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Chen-Yu Tsai
On Tue, Jun 29, 2021 at 9:58 PM Thomas Zimmermann wrote: > > Print the name of the DRM driver when taking over fbdev devices. Makes > the output to dmesg more consistent. Note that the driver name is only > used for printing a string to the kernel log. No UAPI is affected by this > change. > >

Re: [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in dml Makefile

2021-06-29 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jun 29, 2021 at 11:10 AM Harry Wentland wrote: > > On 2021-06-28 9:27 p.m., Reka Norman wrote: > > Setting CONFIG_FRAME_WARN=0 should disable 'stack frame larger than' > > warnings. This is useful for example in KASAN builds. Make the dml > > Makefile respect this

[PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay

2021-06-29 Thread YuBiao Wang
[Why] GPU timing counters are read via KIQ under sriov, which will introduce a delay. [How] It could be directly read by MMIO. v2: Add additional check to prevent carryover issue. Signed-off-by: YuBiao Wang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 13 +++-- 1 file changed, 11

RE: [PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay

2021-06-29 Thread Liu, Monk
[AMD Official Use Only] Please do not use "//" in linux kernel patch , use "/* */" instead After this part fixed the patch is : Reviewed-by: Monk Liu Thanks -- Monk Liu | Cloud-GPU Core team -- -Original

Re: [PATCH v2 1/2] drm/amdgpu: return early for non-TTM_PL_TT type BOs

2021-06-29 Thread Das, Nirmoy
On 6/29/2021 1:05 PM, Christian König wrote: Am 29.06.21 um 09:36 schrieb Nirmoy Das: Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes ttm_resource argument to be TTM_PL_TT type BO's. v2: merge if-conditions Signed-off-by:

Re: [PATCH v2 1/2] drm/amdgpu: return early for non-TTM_PL_TT type BOs

2021-06-29 Thread Christian König
Am 29.06.21 um 09:36 schrieb Nirmoy Das: Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes ttm_resource argument to be TTM_PL_TT type BO's. v2: merge if-conditions Signed-off-by: Nirmoy Das ---

Re: [PATCH 1/2] drm/amd/pm: update the gpu metrics data retrieving for Sienna Cichlid

2021-06-29 Thread Lazar, Lijo
On 6/25/2021 1:42 PM, Evan Quan wrote: Due to the structure layout change: "uint32_t ThrottlerStatus" -> " uint8_t ThrottlingPercentage[THROTTLER_COUNT]". Change-Id: Id5c148b0584d972ae73fb9d7347a312944cec13d Signed-off-by: Evan Quan --- .../pm/inc/smu11_driver_if_sienna_cichlid.h | 63

Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()

2021-06-29 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jun 29, 2021 at 7:42 AM Christian König wrote: > > Am 29.06.21 um 13:44 schrieb Jing Xiangfeng: > > radeon_user_framebuffer_create() misses to call drm_gem_object_put() in > > an error path. Add the missed function call to fix it. > > > > Signed-off-by: Jing

Re: [PATCH v3] drm/amdgpu: Restore msix after FLR

2021-06-29 Thread Alex Deucher
On Fri, Jun 25, 2021 at 2:44 AM Peng Ju Zhou wrote: > > From: "Emily.Deng" > > After FLR, the msix will be cleared, so need to re-enable it. Do we need to store whether we enabled msix in the first place and then decide whether to enable it again in this case? Alex > > Signed-off-by:

Re: [PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-06-29 Thread Christian König
Am 29.06.21 um 09:49 schrieb Nirmoy Das: Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 136 ++---

Re: [PATCH 2/2] drm/amdgpu: raise error on incorrect mem_type

2021-06-29 Thread Das, Nirmoy
On 6/29/2021 1:06 PM, Christian König wrote: Am 29.06.21 um 09:36 schrieb Nirmoy Das: Be more defensive and raise error on wrong mem_type argument in amdgpu_gtt_mgr_has_gart_addr(). Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-   1 file changed, 5

Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()

2021-06-29 Thread Christian König
Am 29.06.21 um 13:44 schrieb Jing Xiangfeng: radeon_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng I'm pretty sure that I already reviewed the same patch a few weeks ago, but it looks like

Re: [PATCH] drm/amdgpu: rectify line endings in umc v8_7_0 IP headers

2021-06-29 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Jun 28, 2021 at 6:53 AM Lukas Bulwahn wrote: > > Commit 6b36fa6143f6 ("drm/amdgpu: add umc v8_7_0 IP headers") adds the new > file ./drivers/gpu/drm/amd/include/asic_reg/umc/umc_8_7_0_sh_mask.h with > DOS line endings, which is very uncommon for the kernel

Re: [PATCH 2/2] drm/amdgpu: raise error on incorrect mem_type

2021-06-29 Thread Christian König
Am 29.06.21 um 09:36 schrieb Nirmoy Das: Be more defensive and raise error on wrong mem_type argument in amdgpu_gtt_mgr_has_gart_addr(). Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v3 1/1] drm/amdgpu: return early for non-TTM_PL_TT type BOs

2021-06-29 Thread Das, Nirmoy
Hi Christian, Could you please pick  this up for drm-misc-next or fixes ? Regards, Nirmoy On 6/29/2021 1:44 PM, Nirmoy Das wrote: Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes ttm_resource argument to be TTM_PL_TT

RE: [PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay

2021-06-29 Thread Chen, Horace
[AMD Official Use Only] Acked-by: Horace Chen -Original Message- From: YuBiao Wang Sent: Tuesday, June 29, 2021 6:01 PM To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ;

Re: [PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-06-29 Thread Das, Nirmoy
On 6/29/2021 1:10 PM, Christian König wrote: Am 29.06.21 um 09:49 schrieb Nirmoy Das: Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 136

[PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Thomas Zimmermann
Print the name of the DRM driver when taking over fbdev devices. Makes the output to dmesg more consistent. Note that the driver name is only used for printing a string to the kernel log. No UAPI is affected by this change. Signed-off-by: Thomas Zimmermann ---

Re: [PATCH] drm/amd/display: Remove assignments in if clauses.

2021-06-29 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jun 25, 2021 at 3:28 AM Mark Yacoub wrote: > > Fixes Commit a46b6bd5 (drm/amd/display: Verify Gamma & Degamma LUT sizes > in amdgpu_dm_atomic_check) > > Tested on Zork: IGT:kms_color > > Signed-off-by: Mark Yacoub > --- >

[PATCH v3 1/1] drm/amdgpu: return early for non-TTM_PL_TT type BOs

2021-06-29 Thread Nirmoy Das
Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes ttm_resource argument to be TTM_PL_TT type BO's. v3: remove extra braces. v2: merge if-conditions. Signed-off-by: Nirmoy Das Reviewed-by: Christian König ---

Re: [PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in dml Makefile

2021-06-29 Thread Harry Wentland
On 2021-06-28 9:27 p.m., Reka Norman wrote: > Setting CONFIG_FRAME_WARN=0 should disable 'stack frame larger than' > warnings. This is useful for example in KASAN builds. Make the dml > Makefile respect this config. > > Fixes the following build warnings with CONFIG_KASAN=y and >

[PATCH 2/2] drm/amdgpu: separate out vm pasid assignment

2021-06-29 Thread Nirmoy Das
Use new helper function amdgpu_vm_set_pasid() to assign vm pasid value. This also ensures that we don't free a pasid from vm code as pasids are allocated somewhere else. Signed-off-by: Nirmoy Das --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 -

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Das, Nirmoy
LGTM Acked-by: Nirmoy Das On 6/29/2021 3:58 PM, Thomas Zimmermann wrote: Print the name of the DRM driver when taking over fbdev devices. Makes the output to dmesg more consistent. Note that the driver name is only used for printing a string to the kernel log. No UAPI is affected by this

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-06-29 Thread Alex Deucher
On Tue, Jun 29, 2021 at 3:57 PM Ketsui wrote: > > I have the 3200G I'm still getting this error with that version. I think the 3200G may be a raven or raven2 variant rather than picasso. Can you try the latest firmware from upstream:

Re: [PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-06-29 Thread Christian König
Am 29.06.21 um 17:19 schrieb Nirmoy Das: Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 149 -

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-06-29 Thread Ketsui
I have the 3200G I'm still getting this error with that version. [ +23.754701] amdgpu :08:00.0: amdgpu: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:2 pasid:32773, for process mpv pid 5016 thread mpv:cs0 pid 5064) [ +0.17] amdgpu :08:00.0: amdgpu: in page starting at address

Re: [PATCH 11/11] drm/amdkfd: inc counter on child ranges with xnack off

2021-06-29 Thread Felix Kuehling
Am 2021-06-29 um 2:02 p.m. schrieb Alex Sierra: > During GPU page table invalidation with xnack off, new ranges > split may occur concurrently in the same prange. Creating a new > child per split. Each child should also increment its > invalid counter, to assure GPU page table updates in these >

[PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-06-29 Thread Nirmoy Das
Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 149 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 6 +- 2 files changed, 73

Re: [PATCH] drm/amdgpu: add license to umc_8_7_0_sh_mask.h

2021-06-29 Thread Harry Wentland
On 2021-06-29 10:14 a.m., Alex Deucher wrote: > Was missing. Add it. > > Fixes: 6b36fa6143f6ca ("drm/amdgpu: add umc v8_7_0 IP headers") > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- > .../include/asic_reg/umc/umc_8_7_0_sh_mask.h | 21 +++ > 1 file

[PATCH 01/11] drm/amdkfd: device pgmap owner at the svm migrate init

2021-06-29 Thread Alex Sierra
pgmap owner member at the svm migrate init could be referenced to either adev or hive, depending on device topology. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 6 +++--- drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 3 +++ 2 files

[PATCH 09/11] drm/amdkfd: add invalid pages debug at vram migration

2021-06-29 Thread Alex Sierra
This is for debug purposes only. It conditionally generates partial migrations to test mixed CPU/GPU memory domain pages in a prange easily. Signed-off-by: Alex Sierra Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 14 ++ 1 file changed, 14 insertions(+)

[PATCH 07/11] drm/amdkfd: skip invalid pages during migrations

2021-06-29 Thread Alex Sierra
Invalid pages can be the result of pages that have been migrated already due to copy-on-write procedure or pages that were never migrated to VRAM in first place. This is not an issue anymore, as pranges now support mixed memory domains (CPU/GPU). Signed-off-by: Alex Sierra Reviewed-by: Felix

[PATCH 02/11] drm/amdkfd: add owner ref param to get hmm pages

2021-06-29 Thread Alex Sierra
The parameter is used in the dev_private_owner to decide if device pages in the range require to be migrated back to system memory, based if they are or not in the same memory domain. In this case, this reference could come from the same memory domain with devices connected to the same hive.

[PATCH 04/11] drm/amdgpu: get owner ref in validate and map

2021-06-29 Thread Alex Sierra
Get the proper owner reference for amdgpu_hmm_range_get_pages function. This is useful for partial migrations. To avoid migrating back to system memory, VRAM pages, that are accessible by all devices in the same memory domain. Ex. multiple devices in the same hive. Signed-off-by: Alex Sierra

[PATCH 05/11] drm/amdkfd: use hmm range fault to get both domain pfns

2021-06-29 Thread Alex Sierra
Now that prange could have mixed domains (VRAM or SYSRAM), actual_loc nor svm_bo can not be used to check its current domain and eventually get its pfns to map them in GPU. Instead, pfns from both domains, are now obtained from hmm_range_fault through amdgpu_hmm_range_get_pages call. This is done

[PATCH 08/11] drm/amdkfd: skip migration for pages already in VRAM

2021-06-29 Thread Alex Sierra
Migration skipped for pages that are already in VRAM domain. These could be the result of previous partial migrations to SYS RAM, and prefetch back to VRAM. Ex. Coherent pages in VRAM that were not written/invalidated after a copy-on-write. Signed-off-by: Alex Sierra ---

[PATCH 03/11] drm/amdkfd: set owner ref to svm range prefault

2021-06-29 Thread Alex Sierra
svm_range_prefault is called right before migrations to VRAM, to make sure pages are resident in system memory before the migration. With partial migrations, this reference is used by hmm range get pages to avoid migrating pages that are already in the same VRAM domain. Signed-off-by: Alex Sierra

[PATCH 06/11] drm/amdkfd: classify and map mixed svm range pages in GPU

2021-06-29 Thread Alex Sierra
[Why] svm ranges can have mixed pages from device or system memory. A good example is, after a prange has been allocated in VRAM and a copy-on-write is triggered by a fork. This invalidates some pages inside the prange. Endding up in mixed pages. [How] By classifying each page inside a prange,

[PATCH 11/11] drm/amdkfd: inc counter on child ranges with xnack off

2021-06-29 Thread Alex Sierra
During GPU page table invalidation with xnack off, new ranges split may occur concurrently in the same prange. Creating a new child per split. Each child should also increment its invalid counter, to assure GPU page table updates in these ranges. Signed-off-by: Alex Sierra ---

[PATCH 10/11] drm/amdkfd: Maintain svm_bo reference in page->zone_device_data

2021-06-29 Thread Alex Sierra
Each zone-device page holds a reference to the SVM BO that manages its backing storage. This is necessary to correctly hold on to the BO in case zone_device pages are shared with a child-process. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 10 --

[PATCH] drm/amdgpu: add license to umc_8_7_0_sh_mask.h

2021-06-29 Thread Alex Deucher
Was missing. Add it. Fixes: 6b36fa6143f6ca ("drm/amdgpu: add umc v8_7_0 IP headers") Signed-off-by: Alex Deucher --- .../include/asic_reg/umc/umc_8_7_0_sh_mask.h | 21 +++ 1 file changed, 21 insertions(+) diff --git

[PATCH 06/12] Revert "drm/amd/display: Always write repeater mode regardless of LTTPR"

2021-06-29 Thread Rodrigo Siqueira
From: Wesley Chalmers This reverts commit 06a2bd7ae7238cf31faeb2216c0e8a3d9b1bedfb Some displays are not lighting up when put in LTTPR Transparent Mode Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 7

[PATCH 11/12] drm/amd/display: Round KHz up when calculating clock requests

2021-06-29 Thread Rodrigo Siqueira
From: Aric Cyr [Why] When requesting clocks from SMU which takes MHz inputs, DC will round down KHz when converting to MHz, thus potentially requesting too low a clock value. [How] Round up (ceil) when converting KHz to MHz for clock requests to SMU. Signed-off-by: Aric Cyr Reviewed-by:

[PATCH 09/12] drm/amd/display: [FW Promotion] Release 0.0.72

2021-06-29 Thread Rodrigo Siqueira
From: Anthony Koo - Updated SCR definition for FW boot options for Separate DCN init for DMUB FW loaded in VBL Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 11 +++ 1 file changed, 7

[PATCH 08/12] drm/amd/display: Adjust types and formatting for future development

2021-06-29 Thread Rodrigo Siqueira
From: Alvin Lee Type adjustments and formatting fixes. Signed-off-by: Alvin Lee Reviewed-by: Dmytro Laktyushkin Acked-by: Rodrigo Siqueira --- .../display/dc/dml/dcn21/display_mode_vba_21.c | 11 ++- .../display/dc/dml/dcn30/display_mode_vba_30.c | 18 ++

[PATCH 03/12] drm/amd/display: Add null checks

2021-06-29 Thread Rodrigo Siqueira
From: Wang Added NULL checks before two problematic statements Signed-off-by: Wang Reviewed-by: Martin Leung Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c

[PATCH 02/12] drm/amd/display: DMUB Outbound Interrupt Process-X86

2021-06-29 Thread Rodrigo Siqueira
From: Chun-Liang Chang [Why] dmub would notify x86 response time violation by GPINT_DATAOUT [How] 1. Use GPINT_DATAOUT to trigger x86 interrupt 2. Register GPINT_DATAOUT interrupt handler. 3. Trigger ACR while GPINT_DATAOUT occurred. Signed-off-by: Chun-Liang Chang Reviewed-by: Jun Lei

[PATCH 12/12] drm/amd/display: increase max EDID size to 2k

2021-06-29 Thread Rodrigo Siqueira
From: Aric Cyr [Why] EDID CTS requires at least 2k (16 blocks) to be readable. [How] Increase EDID buffer size to 2k Signed-off-by: Aric Cyr Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dc_types.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 05/12] drm/amd/display: Fix updating infoframe for DCN3.1 eDP

2021-06-29 Thread Rodrigo Siqueira
From: Nicholas Kazlauskas [Why] We're only treating TMDS as a valid target for infoframe updates which results in PSR being unable to transition from state 4 to state 5. [How] Also allow infoframe updates for DCN3.1 - following how we handle this path for earlier ASIC as well. Signed-off-by:

[PATCH 00/12] DC Patches June 29, 2021

2021-06-29 Thread Rodrigo Siqueira
DC version 3.2.142 brings improvements in multiple areas. In summary, we highlight: - Freesync improvements - Remove unnecessary assert - Firmware release 0.0.72 - Improve the EDID manipulation and DML calculations Alvin Lee (1): drm/amd/display: Adjust types and formatting for future

[PATCH 01/12] drm/amd/display: isolate link training setting override to its own function

2021-06-29 Thread Rodrigo Siqueira
From: Wenjing Liu There is a difference between our default behavior and override behavior. For default behavior we need to decide link training settings within specs' limitation and mandates. For override behavior we do not need to follow all these requirements. We are isolating override

[PATCH 07/12] drm/amd/display: remove faulty assert

2021-06-29 Thread Rodrigo Siqueira
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Wenjing Liu Acked-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

[PATCH 10/12] drm/amd/display: 3.2.142

2021-06-29 Thread Rodrigo Siqueira
From: Aric Cyr DC version 3.2.142 brings improvements in multiple areas. In summary, we highlight: - Freesync improvements - Remove unnecessary assert - Firmware release 0.0.72 - Improve the EDID manipulation and DML calculations Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by:

[PATCH 04/12] drm/amd/display: Add Freesync HDMI support to DM with DMUB

2021-06-29 Thread Rodrigo Siqueira
From: Stylon Wang [Why] Changes in DM needed to support Freesync HDMI on DMUB. [How] Change implementation to parse CEA blocks in case of DMUB-enabled ASICs. Signed-off-by: Stylon Wang Reviewed-by: Nicholas Kazlauskas Acked-by: Rodrigo Siqueira ---

[PATCH] drm/amdgpu: add new dimgrey cavefish DID

2021-06-29 Thread Alex Deucher
Add new PCI device id. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 1a110b06cb6e..6419d75f1f18 100644 ---

[PATCH] drm/amdgpu: Conditionally reset SDMA RAS error counts

2021-06-29 Thread Mukul Joshi
Reset SDMA RAS error counts during init only if persistent EDC harvesting is not supported. Signed-off-by: Mukul Joshi --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-06-29 Thread Alex Deucher
On Wed, Jun 30, 2021 at 12:45 AM Ketsui wrote: > > >I think the 3200G may be a raven or raven2 variant rather than > picasso. > > Are you sure? Examining vbios_version yields this on my system: > > $ cat /sys/class/drm/card0/device/vbios_version > 113-PICASSO-114 > I could be wrong. I can't

Re: [PATCH v3 2/8] mm: remove extra ZONE_DEVICE struct page refcount

2021-06-29 Thread Ralph Campbell
On 6/28/21 9:46 AM, Felix Kuehling wrote: Am 2021-06-17 um 3:16 p.m. schrieb Ralph Campbell: On 6/17/21 8:16 AM, Alex Sierra wrote: From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need

[PATCH] drm/amdgpu/display: drop unused variable

2021-06-29 Thread Alex Deucher
Remove unused variable. Fixes: 00858131205f69 ("Revert "drm/amd/display: Fix overlay validation by considering cursors"") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu/display: drop unused variable

2021-06-29 Thread Harry Wentland
On 2021-06-29 5:02 p.m., Alex Deucher wrote: > Remove unused variable. > > Fixes: 00858131205f69 ("Revert "drm/amd/display: Fix overlay validation by > considering cursors"") > Signed-off-by: Alex Deucher Reviewed-by: Harry Wentland Harry > --- >

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-06-29 Thread Ketsui
>I think the 3200G may be a raven or raven2 variant rather than picasso. Are you sure? Examining vbios_version yields this on my system: $ cat /sys/class/drm/card0/device/vbios_version 113-PICASSO-114 >Can you try the latest firmware from

Re: [PATCH] drm/amdkfd: inc counter on child ranges with xnack off

2021-06-29 Thread Felix Kuehling
Am 2021-06-29 um 5:48 p.m. schrieb Alex Sierra: > During GPU page table invalidation with xnack off, new ranges > split may occur concurrently in the same prange. Creating a new > child per split. Each child should also increment its > invalid counter, to assure GPU page table updates in these >

[PATCH] drm/amdkfd: inc counter on child ranges with xnack off

2021-06-29 Thread Alex Sierra
During GPU page table invalidation with xnack off, new ranges split may occur concurrently in the same prange. Creating a new child per split. Each child should also increment its invalid counter, to assure GPU page table updates in these ranges. Signed-off-by: Alex Sierra ---

Re: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access()

2021-06-29 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Hi Chris, the primary use of amdgpu_device_vram_access() is to gate direct kernel access to VRAM using the MM_INDEX/MM_DATA registers or aperture. It should by design never deal with data sizes != 4 bytes. [kevin]: NOT​​ size aligned, it is offset (address) aligned,

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Simon Ser
On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen wrote: > yes, I think this makes sense, even if it is a property that one can't > tell for sure what it does before hand. > > Using a pair of properties, preference and active, to ask for something > and then check what actually worked is

RE: [PATCH] drm/amdgpu: enable sdma0 tmz for Raven/Renoir(V2)

2021-06-29 Thread Huang, Ray
[AMD Official Use Only] Reviewed-by: Huang Rui -Original Message- From: Liu, Aaron Sent: Monday, June 28, 2021 10:55 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Tuikov, Luben ; Koenig, Christian ; Liu, Aaron Subject: [PATCH] drm/amdgpu: enable sdma0

Re: [PATCH v4 19/27] drm/stm: Don't set struct drm_device.irq_enabled

2021-06-29 Thread yannick Fertre
Hello Thomas, thanks for the patch. Tested-by: Yannick Fertre Best regards On 6/25/21 10:22 AM, Thomas Zimmermann wrote: The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in stm. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent

[PATCH] drm/amd/display: Respect CONFIG_FRAME_WARN=0 in dml Makefile

2021-06-29 Thread Reka Norman
Setting CONFIG_FRAME_WARN=0 should disable 'stack frame larger than' warnings. This is useful for example in KASAN builds. Make the dml Makefile respect this config. Fixes the following build warnings with CONFIG_KASAN=y and CONFIG_FRAME_WARN=0:

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Werner Sembach
Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue, 29 Jun 2021 08:12:54 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen >> wrote: >> >>> yes, I think this makes sense, even if it is a property that one can't >>> tell for sure what it does before hand.

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-06-29 Thread Michel Dänzer
On 2021-06-28 7:16 p.m., Deucher, Alexander wrote: > > Thanks for narrowing this down.  There is new PCO SDMA firmware available > (attached).  Can you try it? Sure, I'll try it, thanks. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-06-29 Thread Werner Sembach
Am 28.06.21 um 19:03 schrieb Werner Sembach: > Am 18.06.21 um 11:11 schrieb Werner Sembach: >> Add a new general drm property "active bpc" which can be used by graphic >> drivers to report the applied bit depth per pixel back to userspace. >> >> While "max bpc" can be used to change the color

Re: [PATCH v2 2/2] drm/amdgpu: free pasid early before converting a vm

2021-06-29 Thread Christian König
Am 29.06.21 um 09:55 schrieb Nirmoy Das: VM code should not be responsible for freeing pasid as pasid gets allocated outside of VM code, before initializing a vm. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8

Re: [PATCH] drm/amdgpu: Set ttm caching flags during bo allocation

2021-06-29 Thread Christian König
Am 29.06.21 um 01:15 schrieb Oak Zeng: The ttm caching flags (ttm_cached, ttm_write_combined etc) are used to determine a buffer object's mapping attributes in both CPU page table and GPU page table (when that buffer is also accessed by GPU). Currently the ttm caching flags are set in function

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Pekka Paalanen
On Tue, 29 Jun 2021 08:12:54 + Simon Ser wrote: > On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen > wrote: > > > yes, I think this makes sense, even if it is a property that one can't > > tell for sure what it does before hand. > > > > Using a pair of properties, preference and

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Werner Sembach
Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue, 29 Jun 2021 08:12:54 + > Simon Ser wrote: > >> On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen >> wrote: >> >>> yes, I think this makes sense, even if it is a property that one can't >>> tell for sure what it does before hand. >>>

[PATCH v2 1/2] drm/amdgpu: return early for non-TTM_PL_TT type BOs

2021-06-29 Thread Nirmoy Das
Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes ttm_resource argument to be TTM_PL_TT type BO's. v2: merge if-conditions Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++- 1 file changed, 2

[PATCH 2/2] drm/amdgpu: raise error on incorrect mem_type

2021-06-29 Thread Nirmoy Das
Be more defensive and raise error on wrong mem_type argument in amdgpu_gtt_mgr_has_gart_addr(). Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

RE: [PATCH 2/2] drm/amd/pm: bump DRIVER_IF_VERSION for Sienna Cichlid

2021-06-29 Thread Quan, Evan
[AMD Official Use Only] Ping.. > -Original Message- > From: Quan, Evan > Sent: Friday, June 25, 2021 4:13 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH 2/2] drm/amd/pm: bump DRIVER_IF_VERSION for Sienna > Cichlid > > To suppress the

RE: [PATCH 1/2] drm/amd/pm: update the gpu metrics data retrieving for Sienna Cichlid

2021-06-29 Thread Quan, Evan
[AMD Official Use Only] Ping.. > -Original Message- > From: Quan, Evan > Sent: Friday, June 25, 2021 4:12 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH 1/2] drm/amd/pm: update the gpu metrics data retrieving > for Sienna Cichlid > >

RE: [PATCH] drm/amdgpu: Set ttm caching flags during bo allocation

2021-06-29 Thread Xu, Feifei
[AMD Official Use Only] Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Oak Zeng Sent: Tuesday, June 29, 2021 7:16 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Zhu, James ; Koenig, Christian ; Zeng, Oak Subject: [PATCH] drm/amdgpu: Set ttm caching

Re: [PATCH 1/2] drm/amdgpu: free pasid early before converting a vm

2021-06-29 Thread Das, Nirmoy
On 6/23/2021 9:05 PM, Felix Kuehling wrote: On 2021-06-23 8:25 a.m., Nirmoy Das wrote: VM code should not be responsible for freeing pasid as pasid gets allocated outside of VM code, before initializing a vm. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |

[PATCH 1/2] drm/amdgpu: use xarray for storing pasid in vm

2021-06-29 Thread Nirmoy Das
Replace idr with xarray as we actually need hash functionality. Cleanup code related to vm pasid by adding helper function. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 136 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 6 +- 2 files changed, 60

[PATCH 2/2] drm/amdgpu: free pasid early before converting a vm

2021-06-29 Thread Nirmoy Das
VM code should not be responsible for freeing pasid as pasid gets allocated outside of VM code, before initializing a vm. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v2 2/2] drm/amdgpu: free pasid early before converting a vm

2021-06-29 Thread Nirmoy Das
VM code should not be responsible for freeing pasid as pasid gets allocated outside of VM code, before initializing a vm. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 -- 2 files changed, 8

RE: [PATCH 2/2] drm/amd/pm: bump DRIVER_IF_VERSION for Sienna Cichlid

2021-06-29 Thread Chen, Guchun
[Public] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Quan, Evan Sent: Tuesday, June 29, 2021 3:44 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 2/2] drm/amd/pm: bump DRIVER_IF_VERSION for Sienna Cichlid [AMD

[PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()

2021-06-29 Thread Jing Xiangfeng
radeon_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng --- drivers/gpu/drm/radeon/radeon_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/radeon/radeon_display.c