Re: [PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay (v5)

2021-07-01 Thread Luben Tuikov
On 2021-07-01 5:57 a.m., YuBiao Wang wrote: > [Why] > GPU timing counters are read via KIQ under sriov, which will introduce > a delay. > > [How] > It could be directly read by MMIO. > > v2: Add additional check to prevent carryover issue. > v3: Only check for carryover for once to prevent

Re: [PATCH v2] drm/amdkfd: Only apply TLB flush optimization on ALdebaran

2021-07-01 Thread Felix Kuehling
Am 2021-06-30 um 7:26 p.m. schrieb Eric Huang: > It is based on reverting two patches back. > drm/amdkfd: Make TLB flush conditional on mapping > drm/amdgpu: Add table_freed parameter to amdgpu_vm_bo_update > > Signed-off-by: Eric Huang I hope we'll be able to change this condition if

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-01 Thread Pekka Paalanen
On Wed, 30 Jun 2021 11:20:18 +0200 Werner Sembach wrote: > Am 30.06.21 um 10:41 schrieb Pekka Paalanen: > > > On Tue, 29 Jun 2021 13:39:18 +0200 > > Werner Sembach wrote: > > > >> Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > >>> On Tue, 29 Jun 2021 08:12:54 + > >>> Simon Ser wrote:

Re: [PATCH] drm/amdgpu: Fix resource leak on probe error path

2021-07-01 Thread Jiri Kosina
On Thu, 24 Jun 2021, Jiri Kosina wrote: > From: Jiri Kosina > > This reverts commit 4192f7b5768912ceda82be2f83c87ea7181f9980. > > It is not true (as stated in the reverted commit changelog) that we never > unmap the BAR on failure; it actually does happen properly on >

[PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

2021-07-01 Thread Emily Deng
Signed-off-by: Emily Deng Signed-off-by: Victor --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c index 33324427b555..7e0d8c092c7e 100644 ---

[PATCH] SWDEV-235359 drm/amdgpu: Correct the irq numbers for virtual ctrc

2021-07-01 Thread Emily Deng
Change-Id: I02035f65b71ec52795c3e8ae979fb582c3cce592 Signed-off-by: Emily Deng Signed-off-by: Victor --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-07-01 Thread Pekka Paalanen
On Wed, 30 Jun 2021 11:42:10 +0200 Werner Sembach wrote: > Am 30.06.21 um 10:21 schrieb Pekka Paalanen: > > On Tue, 29 Jun 2021 13:02:05 +0200 > > Werner Sembach wrote: > > > >> Am 28.06.21 um 19:03 schrieb Werner Sembach: > >>> Am 18.06.21 um 11:11 schrieb Werner Sembach: > Add a

[PATCH] drm/amdgpu: SRIOV flr_work should take write_lock

2021-07-01 Thread Jingwen Chen
[Why] If flr_work takes read_lock, then other threads who takes read_lock can access hardware when host is doing vf flr. [How] flr_work should take write_lock to avoid this case. Signed-off-by: Jingwen Chen --- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 4 ++--

RE: [PATCH v3] drm/amdgpu: Restore msix after FLR

2021-07-01 Thread Zhou, Peng Ju
[AMD Official Use Only] Hi Alex The function amdgpu_restore_msix is used for reset the msix during board reset(sriov reset or asic reset), it moves from host to guest, so I think a flag to indicate if msix enabled is not needed.

[pull] amdgpu, amdkfd, radeon drm-next-5.14

2021-07-01 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The following changes since commit b322a50d17ede5cff6622040f345228afecdcc45: Merge tag 'amd-drm-next-5.14-2021-06-22-1' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2021-06-24 07:57:41 +1000) are available in the Git repository at:

Re: [PATCH v2] drm/amdgpu: Avoid printing of stack contents on firmware load error

2021-07-01 Thread Jiri Kosina
On Thu, 24 Jun 2021, Jiri Kosina wrote: > From: Jiri Kosina > > In case when psp_init_asd_microcode() fails to load ASD microcode file, > psp_v12_0_init_microcode() tries to print the firmware filename that > failed to load before bailing out. > > This is wrong because: > > - the firmware

Re: [PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay (v5)

2021-07-01 Thread Christian König
Am 01.07.21 um 11:57 schrieb YuBiao Wang: [Why] GPU timing counters are read via KIQ under sriov, which will introduce a delay. [How] It could be directly read by MMIO. v2: Add additional check to prevent carryover issue. v3: Only check for carryover for once to prevent performance issue.

Re: [PATCH] drm/amd/pm: drop smu_v13_0_1.c|h files for yellow carp

2021-07-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: Hou, Xiaomeng (Matthew) Sent: Thursday, July 1, 2021 4:31 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) ; Lazar, Lijo ; Liu, Aaron ; Hou, Xiaomeng (Matthew) Subject:

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-01 Thread Werner Sembach
Am 01.07.21 um 10:07 schrieb Pekka Paalanen: > On Wed, 30 Jun 2021 11:20:18 +0200 > Werner Sembach wrote: > >> Am 30.06.21 um 10:41 schrieb Pekka Paalanen: >> >>> On Tue, 29 Jun 2021 13:39:18 +0200 >>> Werner Sembach wrote: >>> Am 29.06.21 um 13:17 schrieb Pekka Paalanen: > On Tue,

Re: [PATCH] drm/amd/pm: drop smu_v13_0_1.c|h files for yellow carp

2021-07-01 Thread Lazar, Lijo
One minor comment below. Reviewed-by: Lijo Lazar On 7/1/2021 2:01 PM, Xiaomeng Hou wrote: Since there's nothing special in smu implementation for yellow carp, it's better to reuse the common smu_v13_0 interfaces and drop the specific smu_v13_0_1.c|h files. Signed-off-by: Xiaomeng Hou ---

RE: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

2021-07-01 Thread Deng, Emily
[AMD Official Use Only] Ping.. >-Original Message- >From: Emily Deng >Sent: Thursday, July 1, 2021 12:38 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deng, Emily ; Zhao, Victor >Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc > >Signed-off-by: Emily Deng

Re: [PATCH v4 03/17] drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property

2021-07-01 Thread Werner Sembach
Am 01.07.21 um 09:42 schrieb Pekka Paalanen: > On Wed, 30 Jun 2021 11:42:10 +0200 > Werner Sembach wrote: > >> Am 30.06.21 um 10:21 schrieb Pekka Paalanen: >>> On Tue, 29 Jun 2021 13:02:05 +0200 >>> Werner Sembach wrote: >>> Am 28.06.21 um 19:03 schrieb Werner Sembach: > Am

Re: [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-07-01 Thread Pekka Paalanen
On Thu, 1 Jul 2021 14:50:13 +0200 Werner Sembach wrote: > Am 01.07.21 um 10:07 schrieb Pekka Paalanen: > > > On Wed, 30 Jun 2021 11:20:18 +0200 > > Werner Sembach wrote: > > > >> Am 30.06.21 um 10:41 schrieb Pekka Paalanen: > >> > >>> On Tue, 29 Jun 2021 13:39:18 +0200 > >>> Werner Sembach

[PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay (v5)

2021-07-01 Thread YuBiao Wang
[Why] GPU timing counters are read via KIQ under sriov, which will introduce a delay. [How] It could be directly read by MMIO. v2: Add additional check to prevent carryover issue. v3: Only check for carryover for once to prevent performance issue. v4: Add comments of the rough frequency where

Re: [PATCH] drm/amdgpu: Fix resource leak on probe error path

2021-07-01 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 1, 2021 at 4:32 AM Jiri Kosina wrote: > > On Thu, 24 Jun 2021, Jiri Kosina wrote: > > > From: Jiri Kosina > > > > This reverts commit 4192f7b5768912ceda82be2f83c87ea7181f9980. > > > > It is not true (as stated in the reverted commit changelog) that we never >

[PATCH] drm/amd/pm: drop smu_v13_0_1.c|h files for yellow carp

2021-07-01 Thread Xiaomeng Hou
Since there's nothing special in smu implementation for yellow carp, it's better to reuse the common smu_v13_0 interfaces and drop the specific smu_v13_0_1.c|h files. Signed-off-by: Xiaomeng Hou --- drivers/gpu/drm/amd/pm/inc/smu_v13_0.h| 1 + drivers/gpu/drm/amd/pm/inc/smu_v13_0_1.h

Re: [PATCH v2] drm/amdgpu: Avoid printing of stack contents on firmware load error

2021-07-01 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 1, 2021 at 4:33 AM Jiri Kosina wrote: > > On Thu, 24 Jun 2021, Jiri Kosina wrote: > > > From: Jiri Kosina > > > > In case when psp_init_asd_microcode() fails to load ASD microcode file, > > psp_v12_0_init_microcode() tries to print the firmware filename that

Re: [PATCH 1/1] drm/amdgpu: Read clock counter via MMIO to reduce delay (v5)

2021-07-01 Thread Lazar, Lijo
A few comments to take care of before submitting the changes. Reviewed-by: Lijo Lazar On 7/1/2021 3:27 PM, YuBiao Wang wrote: [Why] GPU timing counters are read via KIQ under sriov, which will introduce a delay. [How] It could be directly read by MMIO. v2: Add additional check to prevent

RE: [PATCH] drm/amd/pm: drop smu_v13_0_1.c|h files for yellow carp

2021-07-01 Thread Hou, Xiaomeng (Matthew)
[AMD Official Use Only] > >-Original Message- >From: Lazar, Lijo >Sent: Thursday, July 1, 2021 4:51 PM >To: Hou, Xiaomeng (Matthew) ; >amd-gfx@lists.freedesktop.org >Cc: Wang, Kevin(Yang) ; Liu, Aaron >Subject: Re: [PATCH] drm/amd/pm: drop smu_v13_0_1.c|h files for yellow carp > >One

Re: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

2021-07-01 Thread Alex Deucher
Reviewed-by: Alex Deucher On Thu, Jul 1, 2021 at 5:18 AM Deng, Emily wrote: > > [AMD Official Use Only] > > Ping.. > > >-Original Message- > >From: Emily Deng > >Sent: Thursday, July 1, 2021 12:38 PM > >To: amd-gfx@lists.freedesktop.org > >Cc: Deng, Emily ; Zhao, Victor >

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-07-01 Thread Ketsui
I cp'd raven* and picasso* firmware files from upstream version 21.20 and replaced the ones from my distro and I just got another one of these errors. [Jul 1 17:08] amdgpu :08:00.0: amdgpu: [gfxhub0] retry page fault (src_id:0 ring:0 vmid:1 pasid:32778, for process mpv pid 7400 thread mpv:cs0

Re: [Mesa-dev] Requests For Proposals for hosting XDC 2022 are now open

2021-07-01 Thread Samuel Iglesias Gonsálvez
This is a reminder that the call for proposals for hosting XDC 2022 period finishes in two months. Be sure to prepare your submission before you leave on holiday! Sam On Thu, 2021-05-20 at 12:15 +0200, Samuel Iglesias Gonsálvez wrote: > Hello everyone! > > The X.org board is soliciting