Re: [linux-next:master] BUILD REGRESSION d514392f17fd4d386cfadde7f849d97db4ca1fb0

2023-01-24 Thread Nhat Pham
On Fri, Jan 20, 2023 at 9:14 AM kernel test robot wrote: > > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: d514392f17fd4d386cfadde7f849d97db4ca1fb0 Add linux-next > specific files for 20230120 > > Error/Warning reports: > >

Re: [PATCH 2/2] drm/amdgpu: add AMDGPU_INFO_VM_STAT to return GPU VM

2023-01-24 Thread Marek Olšák
A new Gallium HUD "value producer" could be added that reads fdinfo without calling the driver. I still think there is merit in having this in amdgpu_drm.h too. Marek On Tue, Jan 24, 2023 at 3:13 AM Marek Olšák wrote: > The table of exposed driver-specific counters: > >

Re: [PATCH 2/2] drm/amdgpu: add AMDGPU_INFO_VM_STAT to return GPU VM

2023-01-24 Thread Christian König
Am 24.01.23 um 09:27 schrieb Marek Olšák: A new Gallium HUD "value producer" could be added that reads fdinfo without calling the driver. That sounds good. To be honest I would have plenty of use for that. I still think there is merit in having this in amdgpu_drm.h too. Why? Christian.

Re: [PATCH 2/2] drm/amdgpu: add AMDGPU_INFO_VM_STAT to return GPU VM

2023-01-24 Thread Marek Olšák
The table of exposed driver-specific counters: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/src/gallium/drivers/radeonsi/si_query.c#L1751 Counter enums. They use the same interface as e.g. occlusion queries, except that begin_query and end_query save the results in the driver/CPU.

Re: [PATCH 10/10] drm/fbdev-generic: Rename struct fb_info 'fbi' to 'info'

2023-01-24 Thread Thomas Zimmermann
Hi Am 23.01.23 um 21:50 schrieb Sam Ravnborg: Hi Thomas, a quick drive-by comment. On Mon, Jan 23, 2023 at 11:05:59AM +0100, Thomas Zimmermann wrote: The generic fbdev emulation names variables of type struct fb_info both 'fbi' and 'info'. The latter seems to be more common in fbdev code, so

Re: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info

2023-01-24 Thread kernel test robot
Hi Jani, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

Re: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info

2023-01-24 Thread kernel test robot
Hi Jani, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

[PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info

2023-01-24 Thread Jani Nikula
Information parsed from the display EDID should be stored in display info. We can stop clearing ELD separately. Cc: Alex Deucher Cc: Christian König Cc: Pan, Xinhui Cc: amd-gfx@lists.freedesktop.org Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman

[PATCH v2 06/10] drm/fb-helper: Initialize fb-helper's preferred BPP in prepare function

2023-01-24 Thread Thomas Zimmermann
Initialize the fb-helper's preferred_bpp field early from within drm_fb_helper_prepare(); instead of the later client hot-plugging callback. This simplifies the generic fbdev setup function. No real changes, but all drivers' fbdev code has to be adapted. Signed-off-by: Thomas Zimmermann ---

[PATCH v2 05/10] drm/fb-helper: Remove preferred_bpp parameter from fbdev internals

2023-01-24 Thread Thomas Zimmermann
Store the console's preferred BPP value in struct drm_fb_helper and remove the respective function parameters from the internal fbdev code. The BPP value is only required as a fallback and will now always be available in the fb-helper instance. No functional changes. Signed-off-by: Thomas

[PATCH v2 10/10] drm/fbdev-generic: Rename struct fb_info 'fbi' to 'info'

2023-01-24 Thread Thomas Zimmermann
The generic fbdev emulation names variables of type struct fb_info both 'fbi' and 'info'. The latter seems to be more common in fbdev code, so name fbi accordingly. Also replace the duplicate variable in drm_fbdev_fb_destroy(). Signed-off-by: Thomas Zimmermann ---

[PATCH v2 02/10] drm/client: Add hotplug_failed flag

2023-01-24 Thread Thomas Zimmermann
Signal failed hotplugging with a flag in struct drm_client_dev. If set, the client helpers will not further try to set up the fbdev display. This used to be signalled with a combination of cleared pointers in struct drm_fb_helper, which prevents us from initializing these pointers early after

[PATCH v2 03/10] drm/fb-helper: Introduce drm_fb_helper_unprepare()

2023-01-24 Thread Thomas Zimmermann
Move the fb-helper clean-up code into drm_fb_helper_unprepare(). No functional changes. v2: * declare as static inline (kernel test robot) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 14 +- include/drm/drm_fb_helper.h | 5 + 2 files

[PATCH v2 00/10] drm/fb-helper: Various cleanups

2023-01-24 Thread Thomas Zimmermann
Add various cleanups and changes to DRM's fbdev helpers and the generic fbdev emulation. There's no clear theme here, just lots of small things that need to be updated. In the end, the code will better reflect which parts are in the DRM client, which is fbdev emulation, and which are shared

[PATCH v2 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-24 Thread Thomas Zimmermann
Test for connectors in the client code and remove a similar test from the generic fbdev emulation. Do nothing if the test fails. Not having connectors indicates a driver bug. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c| 5 + drivers/gpu/drm/drm_fbdev_generic.c

[PATCH v2 08/10] drm/fbdev-generic: Minimize client unregistering

2023-01-24 Thread Thomas Zimmermann
For uninitialized framebuffers, only release the DRM client and free the fbdev memory. Do not attempt to clean up the framebuffer. DRM fbdev clients have a two-step initialization: first create the DRM client; then create the framebuffer device on the first successful hotplug event. In cases

[PATCH v2 07/10] drm/fbdev-generic: Minimize hotplug error handling

2023-01-24 Thread Thomas Zimmermann
Call drm_fb_helper_init() in the generic-fbdev hotplug helper to revert the effects of drm_fb_helper_init(). No full cleanup is required. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_generic.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git

[PATCH v2 09/10] drm/fbdev-generic: Inline clean-up helpers into drm_fbdev_fb_destroy()

2023-01-24 Thread Thomas Zimmermann
The fbdev framebuffer cleanup in drm_fbdev_fb_destroy() calls drm_fbdev_release() and drm_fbdev_cleanup(). Inline both into the caller. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_generic.c | 17 ++--- 1 file changed, 2 insertions(+), 15

[PATCH v2 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

2023-01-24 Thread Thomas Zimmermann
Initialize the fb-helper structure immediately after its allocation in drm_fbdev_generic_setup(). That will make it easier to fill it with driver-specific values, such as the preferred BPP. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_generic.c | 13 + 1 file

Re: [Intel-gfx] [PATCH 3/3] drm/connector: move ELD and video/audio latencies to display info

2023-01-24 Thread Jani Nikula
b-lkp/linux/commits/Jani-Nikula/drm-connector-move-HDR-sink-metadata-to-display-info/20230124-174322 > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip > patch link: > https://lore.kernel.org/r/20230124094154.2282778-3-jani.nikula%40intel.com > patch subject: [Intel-gfx]

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-24 Thread Naresh Kamboju
powerpc (known build errors for maple_defconfig and cell_defconfig), > > Good to hear! > > Please consider retesting this series on top of 6.2-rc5 or testing the > current kbuild tree, which has this series applied in it: This is the perfect place to test. > https://git.kernel.or

[linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next specific files for 20230124 Error/Warning: (recently discovered and may have been fixed) ERROR: modpost: "devm_platform_ioremap_res

Re: [PATCH v2 10/21] drm/amd/display: Signal mode_changed if colorspace changed

2023-01-24 Thread Leo Li
On 1/13/23 11:24, Harry Wentland wrote: We need to signal mode_changed to make sure we update the output colorspace. v2: No need to call drm_hdmi_avi_infoframe_colorimetry as DC does its own infoframe packing. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc:

Re: [PATCH v2 17/21] drm/amd/display: Format input and output CSC matrix

2023-01-24 Thread Leo Li
On 1/13/23 11:24, Harry Wentland wrote: Format the input and output CSC matrix so they look like 3x4 matrixes. This will make parsing them much easier and allows us to quickly spot potential mistakes. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc:

[PATCH] drm/amdgpu: add force_sg_display module parameter

2023-01-24 Thread Alex Deucher
Add a module parameter to force sg (scatter/gather) display on APUs. Normally we allow displays in both VRAM and GTT, but this option forces displays into GTT so we can explicitly test more scenarios with GTT. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 ++

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-24 Thread Harry Wentland
On 1/23/23 15:30, Sebastian Wick wrote: > A new property to control YCC and subsampling would be the more > complete path here. If we actually want to fix this in the short-term > though, we should handle the YCC and RGB Colorspace values as > equivalent, everywhere. Technically we're breaking

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-24 Thread Harry Wentland
On 1/24/23 10:37, Harry Wentland wrote: > > > On 1/23/23 15:30, Sebastian Wick wrote: >> A new property to control YCC and subsampling would be the more >> complete path here. If we actually want to fix this in the short-term >> though, we should handle the YCC and RGB Colorspace values as >>

Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Sidhartha Kumar
On 1/24/23 12:28 PM, Andrew Morton wrote: On Wed, 25 Jan 2023 00:37:05 +0800 kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next specific files for 20230124

Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Mike Kravetz
next.git master > > > branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next > > > specific files for 20230124 > > > > > > Error/Warning: (recently discovered and may have been fixed) > > > > > > ERROR: modpost: "devm

Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Andrew Morton
On Wed, 25 Jan 2023 00:37:05 +0800 kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: a54df7622717a40ddec95fd98086aff8ba7839a6 Add linux-next > specific files for 20230124 > > Error/Warning: (r

Re: [linux-next:master] BUILD REGRESSION a54df7622717a40ddec95fd98086aff8ba7839a6

2023-01-24 Thread Mike Kravetz
next > > specific files for 20230124 > > > > Error/Warning: (recently discovered and may have been fixed) > > > > ERROR: modpost: "devm_platform_ioremap_resource" [drivers/dma/fsl-edma.ko] > > undefined! > > ERROR: modpost: "devm_platform_

Re: [Intel-gfx] [PATCH v2 06/10] drm/fb-helper: Initialize fb-helper's preferred BPP in prepare function

2023-01-24 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 7d3e7f64a42d66ba8da6e7b66a8d85457ef84570] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-client-Test-for-connectors-before-sending-hotplug-event/20230124-214220 base