Re: [PATCH] drm/amdgpu: expose more memory stats in fdinfo

2023-02-23 Thread Marek Olšák
Updated patch attached. Marek On Mon, Feb 6, 2023 at 4:05 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Just two nit picks: > > +seq_printf(m, "drm-evicted-visible-vram:\t%llu KiB\n", > + stats.evicted_visible_vram/1024UL); > > For the values not standardized for

amdgpu didn't start with pci=nocrs parameter, get error "Fatal error during GPU init"

2023-02-23 Thread Mikhail Gavrilov
Hi, I have a laptop ASUS ROG Strix G15 Advantage Edition G513QY-HQ007. But it is impossible to use without AC power because the system losts nvme when I disconnect the power adapter. Messages from kernel log when it happens: nvme nvme0: controller is down; will reset: CSTS=0x,

Re: [PATCH] drm/amd: use drm_kms_helper_poll_fini in amdgpu_device_suspend to avoid warning

2023-02-23 Thread Bert Karwatzki
When drm_kms_helper_poll_disable is used in amdgpu_device_suspend without drm_kms_helper_poll_init having been called it causes a warning in __flush_work: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 To avoid this one can use drm_kms_helper_poll_fini instead: Send a second time because

RE: [PATCH] drm/amdgpu: Make umc_v8_10_convert_error_address static and remove unused variable

2023-02-23 Thread Zhou1, Tao
Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice > Li > Sent: Friday, February 24, 2023 12:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH] drm/amdgpu: Make umc_v8_10_convert_error_address static > and remove unused variable

Re: amdgpu didn't start with pci=nocrs parameter, get error "Fatal error during GPU init"

2023-02-23 Thread Christian König
Hi Mikhail, this is pretty clearly a problem with the system and/or it's BIOS and not the GPU hw or the driver. The option pci=nocrs makes the kernel ignore additional resource windows the BIOS reports through ACPI. This then most likely leads to problems with amdgpu because it can't bring

RE: [PATCH] drm/amd: use drm_kms_helper_poll_fini in amdgpu_device_suspend to avoid warning

2023-02-23 Thread Chen, Guchun
Hi Bert, Thanks for your patch. As we will can drm_kms_helper_poll_enable in resume, so it may not make sense using drm_kms_helper_poll_fini in suspend, from code pairing perspective. For your case, is it possible to fix the problem by limiting the access of drm_kms_helper_poll_disable with

[PATCH] drm/amdgpu: Make umc_v8_10_convert_error_address static and remove unused variable

2023-02-23 Thread Candice Li
Fixes following warnings: warning: no previous prototype for 'umc_v8_10_convert_error_address' warning: variable 'channel_index' set but not used Reported-by: kernel test robot Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/umc_v8_10.c | 15 +-- 1 file changed, 5

Re: [PATCH] drm/gem: Expose the buffer object handle to userspace last

2023-02-23 Thread Christian König
Am 20.02.23 um 11:23 schrieb Tvrtko Ursulin: On 20/02/2023 10:01, Christian König wrote: Am 20.02.23 um 10:55 schrieb Tvrtko Ursulin: Hi, On 14/02/2023 13:59, Christian König wrote: Am 14.02.23 um 13:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Currently drm_gem_handle_create_tail

Re: Subject [PATCH] drm/radeon: Fix eDP for single-display iMac11,2

2023-02-23 Thread Alex Deucher
I've applied this manually. Please use git to generate and email patches in the future. Thanks! Alex On Sun, Feb 19, 2023 at 12:02 AM Mark Hawrylak wrote: > > From Mark Hawrylak > > Apple iMac11,2 (mid 2010) also with Radeon HD-4670 that has the same > issue as iMac10,1 (late 2009) where the

Re: [PATCH v2 1/3] drm/amd/display: Fix implicit enum conversion

2023-02-23 Thread Alex Deucher
This patch doesn't apply. Please make sure you are using drm-next or linux-next. Alex On Fri, Feb 17, 2023 at 1:15 PM Arthur Grillo wrote: > > Make implicit enum conversion to avoid -Wenum-conversion warning, such > as: > >

RE: [PATCH] drm/amdgpu: support more AV1 encoding requests

2023-02-23 Thread Dong, Ruijing
[AMD Official Use Only - General] Thanks Christian, This is just to cover possible valid ways in kernel as a preparation, av1 encoding in Mesa is still under developing. Thanks, Ruijing -Original Message- From: Christian König Sent: Thursday, February 23, 2023 1:48 AM To: Wu, David ;

Re: [PATCH v2 2/3] drm/amd/display: Remove unused local variables

2023-02-23 Thread Alex Deucher
Applied. Thanks. On Fri, Feb 17, 2023 at 1:15 PM Arthur Grillo wrote: > > Remove local variables that were just set but were never used. This > decrease the number of -Wunused-but-set-variable warnings. > > Signed-off-by: Arthur Grillo > --- >

Re: [PATCH v2 3/3] drm/amd/display: Remove unused local variables and function

2023-02-23 Thread Alex Deucher
Applied. Thanks. On Fri, Feb 17, 2023 at 1:15 PM Arthur Grillo wrote: > > Remove a couple of local variables that are only set but never used, > also remove an static utility function that is never used in consequence > of the variable removal. > > This decrease the number of

[linux-next:master] BUILD REGRESSION 0222aa9800b25ff171d6dcabcabcd5c42c6ffc3f

2023-02-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 0222aa9800b25ff171d6dcabcabcd5c42c6ffc3f Add linux-next specific files for 20230223 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202302062224.byzetxh1-...@intel.com https