Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

On 10/19/2023 2:31 PM, Christian König wrote: > Am 18.10.23 um 19:05 schrieb Shyam Sundar S K: >> >> On 10/18/2023 9:37 PM, Christian König wrote: >>> Am 18.10.23 um 17:47 schrieb Mario Limonciello: On 10/18/2023 08:40, Christian König wrote: > > Am 18.10.23 um 11:28 schrieb Shyam

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

Hi Hans, Apologies for the long delay. On 10/19/2023 12:38 AM, Hans de Goede wrote: > Hi, > > I was not following this at first, so my apologies for > jumping in in the middle of the thread: > > > > >> +static int amd_pmf_gpu_get_cur_state(struct thermal_cooling_device >>

Re: [pull] amdgpu drm-fixes-6.7

On Fri, Nov 17, 2023 at 01:34:41AM -0500, Alex Deucher wrote: > Hi Dave, Sima, > > Fixes for 6.7. > > The following changes since commit b85ea95d086471afb4ad062012a4d73cd328fa86: > > Linux 6.7-rc1 (2023-11-12 16:19:07 -0800) > > are available in the Git repository at: > >

Re: [PATCH v2 01/11] drm/dp_mst: Store the MST PBN divider value in fixed point format

On Fri, Nov 17, 2023 at 12:56:36PM +0200, Ville Syrjälä wrote: > On Thu, Nov 16, 2023 at 03:18:31PM +0200, Imre Deak wrote: > > On UHBR links the PBN divider is a fractional number, accordingly store > > it in fixed point format. For now drm_dp_get_vc_payload_bw() always > > returns a whole number

Re: [PATCH v2 01/11] drm/dp_mst: Store the MST PBN divider value in fixed point format

On Thu, Nov 16, 2023 at 03:18:31PM +0200, Imre Deak wrote: > On UHBR links the PBN divider is a fractional number, accordingly store > it in fixed point format. For now drm_dp_get_vc_payload_bw() always > returns a whole number and all callers will use only the integer part of > it which should

Re: 6.7/regression/KASAN: null-ptr-deref in amdgpu_ras_reset_error_count+0x2d6

On Thu, Nov 16, 2023 at 11:56 PM Alex Deucher wrote: > > This patch should address the issue: > https://patchwork.freedesktop.org/patch/567101/ > If you still see issues, you may also need this series: > https://patchwork.freedesktop.org/series/126220/ > > Alex Thanks. The first one patch is

Re: [PATCH v2 1/6] drm/amdgpu: add lsdma hw ip definition

[Public] enum amd_ip_block_type doc is missing for LSDMA. @@ -85,6 +85,7 @@ enum amd_apu_flags { * @AMD_IP_BLOCK_TYPE_JPEG: JPEG Engine * @AMD_IP_BLOCK_TYPE_VPE: Video Processing Engine * @AMD_IP_BLOCK_TYPE_UMSCH_MM: User Mode Schduler for Multimedia +* @AMD_IP_BLOCK_TYPE_LSDMA: *

[PATCH 1/2] drm/amdgpu/atom: fix vram_usagebyfirmware parsing

The changes to support vram_usagebyfirmware v2.2 changed the behavior to explicitly match 2.1 for everything older rather than just using it by default. If the version is 2.2 or newer, use the 2.2 parsing, for everything else, use the 2.1 parsing. This restores the previous behavior for tables

[PATCH 2/2] drm/amdgpu/atom: make amdgpu_atomfirmware_allocate_fb parsing consistent

For 2.1, ATOM_VRAM_BLOCK_SRIOV_MSG_SHARE_RESERVATION is SR-IOV only. For 2.2, return usage_bytes properly for the non-SR-IOV case. Fixes: 4864f2ee9ee2 ("drm/amdgpu: add vram reservation based on vram_usagebyfirmware_v2_2") Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1215802

Re: [PATCH v8 0/6] drm: Add support for atomic async page-flip

It seems like commits were re-ordered at some point. I think we need "drm: introduce drm_mode_config.atomic_async_page_flip_not_supported" to come before "drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits" because the latter uses atomic_async_page_flip_not_supported. Similarly, "drm: Refuse

Re: [PATCH 4/6] drm/amdkfd: Export DMABufs from KFD using GEM handles

Am 16.11.23 um 22:53 schrieb Felix Kuehling: On 2023-11-07 11:58, Felix Kuehling wrote: Create GEM handles for exporting DMABufs using GEM-Prime APIs. The GEM handles are created in a drm_client_dev context to avoid exposing them in user mode contexts through a DMABuf import. This patch (and

[PATCH] drm/amdgpu: update xgmi num links info post gc9.4.2

GC IP 9.4.2 and up support TA reporting of the number of xGMI links between peers. Tested-by: Vignesh Chander Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

RE: [PATCH] drm/amdgpu: update xgmi num links info post gc9.4.2

[AMD Official Use Only - General] Reviewed-by: Mukul Joshi > -Original Message- > From: Kim, Jonathan > Sent: Friday, November 17, 2023 12:03 PM > To: amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul ; Kim, Jonathan > ; Chander, Vignesh > ; Kim, Jonathan > Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amdgpu: fix AGP addressing when GART is not at 0

On Fri, Nov 10, 2023 at 10:22 AM Christian König wrote: > > Am 10.11.23 um 16:02 schrieb Alex Deucher: > > This worked by luck if the GART aperture ended up at 0. When > > we ended up moving GART on some chips, the GART aperture ended > > up offsetting the the AGP address since the

Re: [PATCH] drm/amdkfd: Copy HW exception data to user event

On 2023-11-17 00:20, David Yat Sin wrote: Fixes issue where user events of type KFD_EVENT_TYPE_HW_EXCEPTION do not have valid data Signed-off-by: David Yat Sin Looks good to me. Do you need a KFD API version bump so ROCr can decide whether the information is valid? Regards,   Felix ---

Re: [PATCH] drm/amdkfd: Copy HW exception data to user event

On 2023-11-17 00:20, David Yat Sin wrote: Fixes issue where user events of type KFD_EVENT_TYPE_HW_EXCEPTION do not have valid data Signed-off-by: David Yat Sin --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v5 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

On 2023-11-16 14:57, Melissa Wen wrote: Add 3D LUT property for plane color transformations using a 3D lookup table. 3D LUT allows for highly accurate and complex color transformations and is suitable to adjust the balance between color channels. It's also more complex to manage and require more

[PATCH] drm/amdgpu: add shared fdinfo stats

Add shared stats. Useful for seeing shared memory. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 6 ++ 3 files changed, 21 insertions(+) diff

RE: [PATCH] drm/amdkfd: Copy HW exception data to user event

[AMD Official Use Only - General] Thanks Eric. The CI builds also detected the wrong use of spaces. So I fixed the tabs with spaces in the patch that I submitted. ~David > -Original Message- > From: amd-gfx On Behalf Of Eric > Huang > Sent: Friday, November 17, 2023 2:50 PM > To:

[PATCH 2/3] drm/amdkfd: Export DMABufs from KFD using GEM handles

Create GEM handles for exporting DMABufs using GEM-Prime APIs. The GEM handles are created in a drm_client_dev context to avoid exposing them in user mode contexts through a DMABuf import. Signed-off-by: Felix Kuehling Reviewed-by: Ramesh Errabolu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c

[PATCH 3/3] drm/amdkfd: Import DMABufs for interop through DRM

Use drm_gem_prime_fd_to_handle to import DMABufs for interop. This ensures that a GEM handle is created on import and that obj->dma_buf will be set and remain set as long as the object is imported into KFD. Signed-off-by: Felix Kuehling Reviewed-by: Ramesh Errabolu Reviewed-by: Xiaogang.Chen

[PATCH 1/3] Revert "drm/prime: Unexport helpers for fd/handle conversion"

This reverts commit 71a7974ac7019afeec105a54447ae1dc7216cbb3. These helper functions are needed for KFD to export and import DMABufs the right way without duplicating the tracking of DMABufs associated with GEM objects while ensuring that move notifier callbacks are working as intended. CC: