Re: [PATCH] drm/amdgpu: fix regression in amdgpu_ucode_init_bo

2016-09-14 Thread Huang Rui
On Wed, Sep 14, 2016 at 04:58:21PM +0200, Christian König wrote: > From: Christian König > > Going into the error case when everything works is a bad idea. > > Signed-off-by: Christian König > --- Christian, thanks. Acked-by: Huang Rui > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++-- >

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Huang Rui
Ah, sorry, this is my mistake to miss the "return 0;". Marek, thanks a lot to point out. I will take care next time. Christian, I see you already send the patch to fix it. Thanks. Thanks, Rui On Wed, Sep 14, 2016 at 10:36:16PM +0800, Koenig, Christian wrote: > Thanks for that info, I was busy mo

Re: [PATCH 3/5] drm/amdgpu:fix RB cost calculator

2016-09-14 Thread Andy Furniss
This has just gone into drm-next-4.9-wip and caused lots of logging noise. Seems to work OK though. Sep 14 23:18:38 ph4 kernel: [drm:gfx_v8_0_ring_emit_fence_gfx [amdgpu]] *ERROR* amdgpu: writing more dwords to the ring than expected! Sep 14 23:18:38 ph4 last message repeated 11 times Sep 14 2

[PATCH 3/4] drm/radeon/atpx: check for ATIF dGPU wake for display events support

2016-09-14 Thread Alex Deucher
Some ATPX laptops implement special circuitry to generate display hotplug events via ACPI when the dGPU is powered off. Check if this is supported. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_atpx_handler.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/dr

[PATCH 2/4] drm/amdgpu/atif: Send a hotplug event when we get dgpu display request

2016-09-14 Thread Alex Deucher
On PX systems, if the platform supports hotplug events ATIF while the dGPU is powered down, handle the event and alert userspace. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/a

[PATCH 1/4] drm/amdgpu/atpx: check for ATIF dGPU wake for display events support

2016-09-14 Thread Alex Deucher
Some ATPX laptops implement special circuitry to generate display hotplug events via ACPI when the dGPU is powered off. Check if this is supported. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 9 ++

[PATCH 4/4] drm/radeon/atif: Send a hotplug event when we get dgpu display request

2016-09-14 Thread Alex Deucher
On PX systems, if the platform supports hotplug events ATIF while the dGPU is powered down, handle the event and alert userspace. Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_acpi.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/radeon/rad

Re: [PATCH xf86-video-ati 4/4] DRI2: Fix radeon_dri2_exchange_buffers width/height copy'n'paste error

2016-09-14 Thread Alex Deucher
On Wed, Sep 14, 2016 at 4:14 AM, Michel Dänzer wrote: > From: Qiang Yu > > Signed-off-by: Qiang Yu > (Ported from amdgpu commit 73c8dc000ad6b2b53ba3aa7155f5e8f6b55623b7) > > Signed-off-by: Michel Dänzer For the series: Reviewed-by: Alex Deucher > --- > src/radeon_dri2.c | 2 +- > 1 file cha

RE: [PATCH] drm/amd/powerplay: fix potential issue of array access violation

2016-09-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Wednesday, September 14, 2016 7:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amd/powerplay: fix potential issue of array access > violation >

RE: [PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed

2016-09-14 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Monk Liu > Sent: Wednesday, September 14, 2016 7:48 AM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, Monk > Subject: [PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed > > Change-Id:

Re: [PATCH] drm/amdgpu: fix regression in amdgpu_ucode_init_bo

2016-09-14 Thread Alex Deucher
On Wed, Sep 14, 2016 at 10:58 AM, Christian König wrote: > From: Christian König > > Going into the error case when everything works is a bad idea. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++-- > 1 file changed, 2 ins

[PATCH] drm/amdgpu: fix regression in amdgpu_ucode_init_bo

2016-09-14 Thread Christian König
From: Christian König Going into the error case when everything works is a bad idea. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Christian König
Thanks for that info, I was busy most of the day bisecting this regression as well. Yeah, the bug is rather obvious, there is a "return 0;" in the good case missing here. So after loading the firmware we release it again. I will hack together a patch, just give me a minute. Christian. Am

Re: [PATCH] drm/amd/powerplay: Partially revert change initialize platform caps

2016-09-14 Thread Alex Deucher
On Wed, Sep 14, 2016 at 4:38 AM, Rex Zhu wrote: > partially revert commit I36f3c9e3a28cbf290652edfb6e19109da660c4f1 > this will lead APU can't work. > > Change-Id: I2233e2f21058540ff782e27e07fa0d0937692ace > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerpla

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-14 Thread Marek Olšák
Hi, This patch causes a massive performance drop (by a factor of 100) followed by GPU hangs with F1 2015 (it needs more than 3GB of memory, the card has 2GB). The game normally works really well (30+ FPS on Polaris11 2GB, 40+ FPS on Tonga 2GB). It should be fixed or the commit should be reverted

Re: [PATCH] drm/amdgpu/si/dpm: fix swapped ck enable

2016-09-14 Thread StDenis, Tom
Yup, that looks better. My apologies. Guess that's the downside of having assertions for enable and disable in the same driver. Reviewed-by: Tom St Denis From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, September 14, 2016 09:47 To: amd-gfx@lists.f

Re: [PATCH] drm/amdgpu/si/dpm: fix swapped ck enable

2016-09-14 Thread Christian König
Am 14.09.2016 um 15:47 schrieb Alex Deucher: Fixes a regression in: drm/amd/amdgpu: Tidy up SI SMC code bug: https://bugs.freedesktop.org/show_bug.cgi?id=97801 Signed-off-by: Alex Deucher Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/si_smc.c | 4 ++-- 1 file changed, 2

[PATCH] drm/amdgpu/si/dpm: fix swapped ck enable

2016-09-14 Thread Alex Deucher
Fixes a regression in: drm/amd/amdgpu: Tidy up SI SMC code bug: https://bugs.freedesktop.org/show_bug.cgi?id=97801 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si_smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_smc.c b/d

RE: [PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed

2016-09-14 Thread Liu, Monk
Sorry, ignore this one, it's not correct and I have sent another one BR Monk -Original Message- From: Monk Liu [mailto:monk@amd.com] Sent: Wednesday, September 14, 2016 7:48 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH 4/4] drm/amdgpu:determine if vPost is nee

[PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed

2016-09-14 Thread Monk Liu
Change-Id: Ic4bb5cb748180d60a672f9e160f1f3308397029b Signed-off-by: Monk Liu Conflicts: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 48 +++--- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH 3/4] drm/amdgpu:correct smc fw version error

2016-09-14 Thread Monk Liu
original method get wrong smc fw version. Change-Id: I1483613a44a231179a280ccde698ff3310d23d8e Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu

[PATCH 1/4] drm/amdgpu:add fw version entry to info

2016-09-14 Thread Monk Liu
From: Frank Min Change-Id: I11cc6e44c0b25eab2fe7a5960160ab02595ee71b Signed-off-by: Frank Min --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 42 ++ drivers/gpu/drm/amd/include/cgs_common.h | 1 + drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 1 +

[PATCH 2/4] drm/amdgpu:changes of virtualization cases probe

2016-09-14 Thread Monk Liu
1,Changes on virtualization detections 2,Don't load smu & mc firmware if using sr-iov bios 3,skip vPost for sriov & force vPost if dev pass-through Change-Id: I13059b1cf6b6de2532b62c7604d8961b56401bfe Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 38 +++

[PATCH] drm/amd/powerplay: fix potential issue of array access violation

2016-09-14 Thread Rex Zhu
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c index bfe1a14..1167205 100644 --- a/drivers/gpu/drm/amd/powe

[PATCH 2/4] drm/amdgpu:changes of virtualization cases probe

2016-09-14 Thread Monk Liu
1,Changes on virtualization detections 2,Don't load smu & mc firmware if using sr-iov bios 3,skip vPost for sriov & force vPost if dev pass-through Change-Id: I13059b1cf6b6de2532b62c7604d8961b56401bfe Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 38 +++

[PATCH 3/4] drm/amdgpu:correct smc fw version error

2016-09-14 Thread Monk Liu
original method get wrong smc fw version. Change-Id: I1483613a44a231179a280ccde698ff3310d23d8e Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu

[PATCH 4/4] drm/amdgpu:determine if vPost is needed indeed

2016-09-14 Thread Monk Liu
Change-Id: Ic4bb5cb748180d60a672f9e160f1f3308397029b Signed-off-by: Monk Liu Conflicts: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH 1/4] drm/amdgpu:add fw version entry to info

2016-09-14 Thread Monk Liu
From: Frank Min Change-Id: I11cc6e44c0b25eab2fe7a5960160ab02595ee71b Signed-off-by: Frank Min --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c| 42 ++ drivers/gpu/drm/amd/include/cgs_common.h | 1 + drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 1 +

Re: [PATCH] drm/amdgpu: gtt offset should be 64 bit

2016-09-14 Thread Flora Cui
yes. i just find it out. it's commit 9040cf0a in 4.6 branch yet not in 4.7. please ignore this commit. On Wed, Sep 14, 2016 at 11:32:32AM +0200, Christian König wrote: > Am 14.09.2016 um 11:13 schrieb Flora Cui: > >Change-Id: I05618a472b1ebf381575d02e226264609bf4db7f > >Signed-off-by: Flora Cui >

[PATCH xf86-video-amdgpu] Use --with-xorg-conf-dir=$prefix/share/X11/xorg.conf.d by default

2016-09-14 Thread Michel Dänzer
From: Michel Dänzer We were using the result of `pkg-config --variable=sysconfigdir xorg-server` before, which may not be inside $prefix, so make install might fail for 10-amdgpu.conf . Fixes make distcheck in that case, and possibly also 10-amdgpu.conf seemingly missing from some distribution p

Re: [PATCH] drm/amdgpu: gtt offset should be 64 bit

2016-09-14 Thread Christian König
Am 14.09.2016 um 11:13 schrieb Flora Cui: Change-Id: I05618a472b1ebf381575d02e226264609bf4db7f Signed-off-by: Flora Cui Didn't Felix came up with the same patch a few weeks ago? Anyway the fix is clearly not committed. Patch is Reviewed-by: Christian König . Regards, Christian. --- dri

[PATCH] drm/amdgpu: gtt offset should be 64 bit

2016-09-14 Thread Flora Cui
Change-Id: I05618a472b1ebf381575d02e226264609bf4db7f Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 10 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/dri

Re: [PATCH] drm/amd/powerplay: Partially revert change initialize platform caps

2016-09-14 Thread Huang Rui
On Wed, Sep 14, 2016 at 04:38:37PM +0800, Rex Zhu wrote: > partially revert commit I36f3c9e3a28cbf290652edfb6e19109da660c4f1 > this will lead APU can't work. > > Change-Id: I2233e2f21058540ff782e27e07fa0d0937692ace > Signed-off-by: Rex Zhu Reviewed-by: Huang Rui > --- > drivers/gpu/drm/amd/po

[PATCH] drm/amd/powerplay: Partially revert change initialize platform caps

2016-09-14 Thread Rex Zhu
partially revert commit I36f3c9e3a28cbf290652edfb6e19109da660c4f1 this will lead APU can't work. Change-Id: I2233e2f21058540ff782e27e07fa0d0937692ace Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH xf86-video-ati 1/4] Destroy all dedicated scanout buffers during CloseScreen

2016-09-14 Thread Michel Dänzer
From: Michel Dänzer Fixes leaking active scanout buffers across a server reset, which also fixes server reset with glamor and active scanout buffers. (Ported from amdgpu commit d96dabc71b1b32dc4b422a9633cdd4e0e95da052) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 10 ++ 1

[PATCH xf86-video-ati 2/4] Fix radeon_mode_hotplug crash on multi GPU platform.

2016-09-14 Thread Michel Dänzer
From: Qiang Yu On multi GPU platform, some screen is created by other GPU DDX. Signed-off-by: Qiang Yu (Ported from amdgpu commit 978242977e5dc905e1d5a46b1b0d34b356c7af26) Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH xf86-video-ati 3/4] DRI2: Add interpolated_vblanks in radeon_dri2_get_crtc_msc

2016-09-14 Thread Michel Dänzer
From: Michel Dänzer We need that in radeon_dri2_drawable_crtc as well for priv->vblank_delta to work as intended. radeon_dri2_get_msc was already doing this. Fixes hangs in some cases when using VDPAU via DRI2 and moving the window between CRTCs. (Ported from amdgpu commit abd1a7901c95e4bc7841

[PATCH xf86-video-ati 4/4] DRI2: Fix radeon_dri2_exchange_buffers width/height copy'n'paste error

2016-09-14 Thread Michel Dänzer
From: Qiang Yu Signed-off-by: Qiang Yu (Ported from amdgpu commit 73c8dc000ad6b2b53ba3aa7155f5e8f6b55623b7) Signed-off-by: Michel Dänzer --- src/radeon_dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/radeon_dri2.c b/src/radeon_dri2.c index 79501f0..69fd0ea 10064