[PATCH 2/2] drm/amdgpu/si/dpm: fix phase shedding setup

2016-09-27 Thread Alex Deucher
Used the wrong index to setup the phase shedding mask. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 2 +- drivers/gpu/drm/amd/amdgpu/sislands_smc.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[pull] radeon and amdgpu drm-fixes-4.8

2016-09-27 Thread Alex Deucher
Hi Dave, Just a couple of small fixes for 4.8: - dpm stability fix for some SI parts - fix a regression in 4.8 on display tear down The following changes since commit 47a66e45d7a7613322549c2475ea9d809baaf514: drm: Only use compat ioctl for addfb2 on X86/IA64 (2016-09-19 17:28:20 +1000) are

[PATCH 2/2] drm/amdgpu/si/dpm: sync up quirks from radeon

2016-09-27 Thread Alex Deucher
Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si_dpm.c index e2db4a7..73ccf33 100644 ---

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Edward O'Callaghan
Excellent point Christian, it did occur to me that endianness could be a problem so will definitely fix this one up as Tom suggested. Kind Regards, Edward. On 09/27/2016 11:02 PM, StDenis, Tom wrote: > Better would be to add them to a bitmask header and then use > REG_GET_FIELD() so it's nice

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread StDenis, Tom
Better would be to add them to a bitmask header and then use REG_GET_FIELD() so it's nice and clean looking. Tom From: amd-gfx on behalf of Christian König Sent: Tuesday, September 27, 2016

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Oded Gabbay
Christian is correct. That is not portable to other architectures Oded On Tue, Sep 27, 2016 at 3:52 PM, Christian König wrote: > NAK, don't use bitfields to decode hardware values. They aren't portable. > > Regards, > Christian. > > > Am 27.09.2016 um 14:47 schrieb

Additional amdkfd cleanups for 4.9

2016-09-27 Thread Edward O'Callaghan
These additional minor changes apply on top of my previous set. Nothing too interesting here just yet more clean ups to make way for future changes. Please review, Kind Regards, Edward O'Callaghan (2): [PATCH 1/2] drm/amdkfd: Use kfd_vm_info struct to carry consts state [PATCH 2/2] drm/amdkfd:

[PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

2016-09-27 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 15 +-- drivers/gpu/drm/amd/amdkfd/cik_int.h | 20 2 files changed, 21 insertions(+), 14 deletions(-) diff --git

[PATCH 1/2] drm/amdkfd: Use kfd_vm_info struct to carry consts state

2016-09-27 Thread Edward O'Callaghan
Use a struct to carry the calculated const state inside the main kfd_dev state to use where we need it. Minor cleanups while we are here. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 9 ++---

Re: VRAM manager

2016-09-27 Thread Edward O'Callaghan
This series is, to the best of my ability, Reviewed-by: Edward O'Callaghan On 09/27/2016 07:49 PM, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > > Anybody brave enough to give it an review? > >

Re: VRAM manager

2016-09-27 Thread Mike Lothian
Hi Christian It's working for me on my Tonga now, thanks for fixing those bugs Feel free to add a testing by Cheers Mike On 27 September 2016 at 10:49, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > >

Re: [PATCH 6/6] drm/amdgpu: add VRAM manager v2

2016-09-27 Thread zhoucm1
On 2016年09月27日 17:49, Christian König wrote: From: Christian König Split VRAM allocations into 4MB blocks. v2: fix typo in comment, some suggested cleanups v3: document how to disable the feature, fix rebase issue Signed-off-by: Christian König

VRAM manager

2016-09-27 Thread Christian König
Hi guys, after fixing all those nasty little bugs this seems to be stable now. Anybody brave enough to give it an review? Cheers, Christian. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 5/6] drm/amdgpu: enable amdgpu_move_blit to handle multiple MM nodes v2

2016-09-27 Thread Christian König
From: Christian König This allows us to move scattered buffers around. v2: fix a couple of typos, handle scattered to scattered moves as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 118

[PATCH 3/6] drm/amdgpu: set at least the node size in the gtt manager

2016-09-27 Thread Christian König
From: Christian König Otherwise the new VM code becomes confused. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

[PATCH 4/6] drm/amdgpu: handle multiple MM nodes in the VMs v2

2016-09-27 Thread Christian König
From: Christian König This allows us to map scattered VRAM BOs to the VMs. v2: fix offset handling, use pfn instead of offset, fix PAGE_SIZE != AMDGPU_GPU_PAGE_SIZE case Signed-off-by: Christian König ---

[PATCH 1/6] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS flag v3

2016-09-27 Thread Christian König
From: Christian König Add a flag noting that a BO must be created using linear VRAM and set this flag on all in kernel users where appropriate. Hopefully I haven't missed anything. v2: add it in a few more places, fix CPU mapping. v3: rename to VRAM_CONTIGUOUS, fix

[PATCH 2/6] drm/amdgpu: use explicit limit for VRAM_CONTIGUOUS

2016-09-27 Thread Christian König
From: Christian König Split VRAM won't have a valid offset, so just set an explicit limit when the flag is given to trigger reallocation if necessary. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9

Re: [PATCH] drm/amdgpu: add version bump for raster config programming

2016-09-27 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 26, 2016 at 10:46 PM, Alex Deucher wrote: > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 0/3] drm/amdgpu: implement raster configuration

2016-09-27 Thread Christian König
Am 27.09.2016 um 01:13 schrieb Marek Olšák: On Mon, Sep 26, 2016 at 10:42 PM, Deucher, Alexander wrote: -Original Message- From: Marek Olšák [mailto:mar...@gmail.com] Sent: Monday, September 26, 2016 4:39 PM To: Huang, Ray Cc: amd-gfx mailing list; Deucher,

Re: [PATCH] drm/amdgpu: add version bump for raster config programming

2016-09-27 Thread Christian König
Am 26.09.2016 um 22:46 schrieb Alex Deucher: Signed-off-by: Alex Deucher Reviewed-by: Christian König . BTW: I've never been a fan of bumping only once per cycle. We are not short on numbers and it really sucks to bump only once when you

Re: [PATCH] drm/amdgpu/vce: take all rings into account for idle checks

2016-09-27 Thread Christian König
Am 26.09.2016 um 21:21 schrieb Alex Deucher: Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git