Re: [PATCH 1/7] drm/amdgpu: remove adev pointer from struct amdgpu_bo

2016-10-02 Thread Grazvydas Ignotas
On Thu, Sep 29, 2016 at 10:52 AM, Christian König wrote: > From: Christian König > > It's completely pointsless to have two pointers to the > device in the same structur. Several typos here... Gražvydas

Re: [PATCH 4/9] drm/amdgpu:keep bo pinned in prefered domain

2016-10-02 Thread Grazvydas Ignotas
Hi, this patch causes failure on my polaris10 card: [drm:gfx_v8_0_ring_test_ring] *ERROR* amdgpu: ring 0 test failed (scratch(0xC040)=0xCAFEDEAD) [drm:amdgpu_init] *ERROR* hw_init of IP block failed -22 amdgpu :01:00.0: amdgpu_init failed Gražvydas On Wed, Sep 28, 2016 at 11:36 AM, Monk

[PATCH] drm/amdgpu/dce11: add missing drm_mode_config_cleanup call

2016-10-02 Thread Grazvydas Ignotas
All other amdgpu/dce_v* files have this call, it's only mysteriously missing from dce_v11_0.c since the file was added and causes leaks. Fixes: aaa36a976bbb ("drm/amdgpu: Add initial VI support") Signed-off-by: Grazvydas Ignotas --- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1

[PATCH] drm/amdgpu: warn if dp aux is still attached on free

2016-10-02 Thread Grazvydas Ignotas
If this happens (and it recently did), we free a structure while part of it is still in use, which results in non-obvious crashes. The way it's detached is not trivial (DRM core has to call the connector .destroy callback and things must be torn down in the right order), so better detect it and

[PATCH] drm/amdgpu: also track late init state

2016-10-02 Thread Grazvydas Ignotas
Successful sw_init() and hw_init() states are tracked, but not late_init(). Various error paths may result in amdgpu_fini() being called before .late init is done, so late_init needs to be tracked to avoid unexpected or multiple .late_fini() calls. Signed-off-by: Grazvydas Ignotas