Re: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-09 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/10/2016 06:23 AM, Grazvydas Ignotas wrote: > Currently the driver crashes if smu7_enable_dpm_tasks() returns early, > which it does if DPM is already active. It seems to be better just to > continue anyway, at least I haven't noticed any ill effects. It's als

[PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-09 Thread Grazvydas Ignotas
Currently the driver crashes if smu7_enable_dpm_tasks() returns early, which it does if DPM is already active. It seems to be better just to continue anyway, at least I haven't noticed any ill effects. It's also unclear at what state the hardware was left by the previous driver, so IMO it's better

Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

2016-10-09 Thread Tom St Denis
Yup that's what I said in another part of the thread :-) i'm a trailblazer of bad ideas at times :-) hehehehe Tom On Sun, Oct 9, 2016 at 11:13 AM Christian König wrote: > Am 05.10.2016 um 21:42 schrieb Alex Deucher: > > Looks like fallout from a rebase or merge. > > > > Signed-off-by: Alex Deu

[PATCH] drm/amdgpu: use .early_unregister hook to remove DP AUX i2c

2016-10-09 Thread Grazvydas Ignotas
When DisplayPort AUX channel i2c adapter is registered, drm_connector's kdev member is used as a parent, so we get sysfs structure like: /drm/card1/card1-DP-2/i2c-12 Because of that, there is a problem when drm core (and not the driver) calls drm_connector_unregister(), it removes parent sysfs en

Re: [PATCH 1/2] drm/amd/amdgpu: enable clockgating only after late init

2016-10-09 Thread Christian König
Am 07.10.2016 um 20:50 schrieb Alex Deucher: From: Arindam Nath Sometimes during multiple reboots, the system hangs during bootup. The issue is very random and happens once in around 50 reboots or so. It seems if clockgating is enabled before late init, the GFX engine sometimes does not respon

Re: [PATCH 1/6] drm/amdgpu: move dpm related definitions to amdgpu_dpm.h

2016-10-09 Thread Christian König
Am 07.10.2016 um 20:28 schrieb Alex Deucher: No intended functional change. Signed-off-by: Alex Deucher Patches #1-#4 and #6 are Reviewed-by: Christian König . Patch #5 is fine with me, but I think Rex is going to object because it pulls the amdgpu IOCTL definitions into the powerplay cod

Re: [PATCH] drm/amdgpu: drop atom scratch save/restore in gpu reset

2016-10-09 Thread Christian König
Am 06.10.2016 um 17:27 schrieb Alex Deucher: This is already handled by the dce IP modules in their suspend and resume code. No need to do it again. Signed-off-by: Alex Deucher Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 1 file changed, 4 dele

Re: [PATCH] drm/amdgpu: remove duplicate evict_vram in suspend path

2016-10-09 Thread Christian König
Am 05.10.2016 um 21:42 schrieb Alex Deucher: Looks like fallout from a rebase or merge. Signed-off-by: Alex Deucher NAK, this is done on purpose and is for evicting the GART table using memcpy. Tom wanted to remove that as well and it makes resume then fail horrible on dGPUs. We should

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-09 Thread Tom St Denis
Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. (v2) Fix broadcast range checking Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read

2016-10-09 Thread Tom St Denis
Allow any of the se/sh/instance fields to be specified as a broadcast by submitting 0x3FF. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgp